Attachment 358221 Details for Bug 193092 – Proposed patch

[patch] Proposed patch

ews-buildbot-git.patch (text/plain), 2.14 KB, created by Aakash Jain on 2019-01-02 16:14:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-02 16:14:07 PST

Size: 2.14 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 239579)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-02  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Use git on OpenSource EWS bots
>+        https://bugs.webkit.org/show_bug.cgi?id=193092
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (CheckOutSource): Use git instead of svn.
>+        (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
>+
> 2019-01-02  Daniel Bates  <dabates@apple.com>
> 
>         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 239578)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -23,7 +23,7 @@
> from buildbot.process import buildstep, logobserver, properties
> from buildbot.process.results import Results, SUCCESS, FAILURE, WARNINGS, SKIPPED, EXCEPTION, RETRY
> from buildbot.steps import master, shell, transfer
>-from buildbot.steps.source import svn
>+from buildbot.steps.source import git
> from twisted.internet import defer
> 
> import re
>@@ -90,14 +90,15 @@ class ConfigureBuild(buildstep.BuildStep
>         return '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id)
> 
> 
>-class CheckOutSource(svn.SVN):
>+class CheckOutSource(git.Git):
>     CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR = (0, 2)
> 
>     def __init__(self, **kwargs):
>-        self.repourl = 'https://svn.webkit.org/repository/webkit/trunk'
>+        self.repourl = 'https://git.webkit.org/git/WebKit.git'
>         super(CheckOutSource, self).__init__(repourl=self.repourl,
>                                                 retry=self.CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR,
>-                                                preferLastChangedRev=True,
>+                                                timeout=2 * 60 * 60,
>+                                                progress=True,
>                                                 **kwargs)
> 
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193092: 358221