Attachment 358203 Details for Bug 193087 – Patch

[patch] Patch

bug-193087-20190102161215.patch (text/plain), 3.21 KB, created by cvazac on 2019-01-02 14:12:16 PST

(hide)

Description:

Filename:

MIME Type:

Creator: cvazac

Created: 2019-01-02 14:12:16 PST

Size: 3.21 KB

patch

obsolete

>Subversion Revision: 239568
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 97a0991c7a404612ffb4f3e467652ca7a3fff60b..95a3d725333604ade839e6e310cdbcb9fc4850ba 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-02  Charles Vazac  <cvazac@gmail.com>
>+
>+        Fix resourcetimingbufferfull bubbles attribute
>+        https://bugs.webkit.org/show_bug.cgi?id=193087
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This change is covered by web-platform-tests [1].
>+
>+        [1] https://github.com/web-platform-tests/wpt/blob/master/resource-timing/buffer-full-when-populate-entries.html#L20
>+
>+        * page/Performance.cpp:
>+        (WebCore::Performance::resourceTimingBufferFullTimerFired):
>+
> 2019-01-01  Jeff Miller  <jeffm@apple.com>
> 
>         Update user-visible copyright strings to include 2019
>diff --git a/Source/WebCore/page/Performance.cpp b/Source/WebCore/page/Performance.cpp
>index 80e9daee9109c03ac20b032833eaaa48af7d3174..d51b26d880ec895d7d699edfbcaba2e65a8465a5 100644
>--- a/Source/WebCore/page/Performance.cpp
>+++ b/Source/WebCore/page/Performance.cpp
>@@ -216,7 +216,7 @@ void Performance::resourceTimingBufferFullTimerFired()
>         ASSERT(m_backupResourceTimingBuffer.isEmpty());
> 
>         m_resourceTimingBufferFullFlag = true;
>-        dispatchEvent(Event::create(eventNames().resourcetimingbufferfullEvent, Event::CanBubble::Yes, Event::IsCancelable::No));
>+        dispatchEvent(Event::create(eventNames().resourcetimingbufferfullEvent, Event::CanBubble::No, Event::IsCancelable::No));
> 
>         if (m_resourceTimingBufferFullFlag) {
>             for (auto& entry : backupBuffer)
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 4a85e5fbb6bcc0a74bb554f3d975fd9fe6ea9fc8..a98637eab31b7ba439cdf84ce1895edd7694cf30 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-02  Charles Vazac  <cvazac@gmail.com>
>+
>+        Fix resourcetimingbufferfull bubbles attribute
>+        https://bugs.webkit.org/show_bug.cgi?id=193087
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * http/wpt/resource-timing/rt-performance-extensions.js:
>+        (promise_test):
>+
> 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Support PHP 7.3 in Debian.
>diff --git a/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js b/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js
>index 0ba50aa71f19dcf730ecd9baa9293e59265ba1ac..9fa40a16d8fc9d157a422ca1bb4cd037ebe7085d 100644
>--- a/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js
>+++ b/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js
>@@ -102,7 +102,7 @@ promise_test(function(t) {
>         assert_equals(entries.length, 2, "context should have observed 1 resource");
>         assert_equals(performance.getEntriesByType("resource").length, 1, "context global buffer should be full at 1 resource");
>         assert_equals(bufferFullEvent.target, performance, "event should dispatch at the performance object");
>-        assert_true(bufferFullEvent.bubbles, "event should bubble");
>+        assert_false(bufferFullEvent.bubbles, "event should not bubble");
>     });
> }, "resourcetimingbufferfull event properties", {timeout: 3000});
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193087: 358195 | 358196 | 358200 | 358201 | 358203