WebKit Bugzilla
Attachment 358190 Details for
Bug 193082
: Remove logic handling DNT header during redirects
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193082-20190102112328.patch (text/plain), 2.78 KB, created by
Brent Fulgham
on 2019-01-02 11:23:29 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Brent Fulgham
Created:
2019-01-02 11:23:29 PST
Size:
2.78 KB
patch
obsolete
>Subversion Revision: 239569 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 5c23432fe891564907ceb8a768a7d6eae8558ebc..55195e0e6c8817a2bf6ef5cc8469ed25d01af023 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,18 @@ >+2019-01-02 Brent Fulgham <bfulgham@apple.com> >+ >+ Remove logic handling DNT header during redirects >+ https://bugs.webkit.org/show_bug.cgi?id=193082 >+ <rdar://problem/45555965> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Don't both looking for (and passing along) DNT headers during redirects. >+ >+ * NetworkProcess/NetworkLoadChecker.cpp: >+ (WebKit::NetworkLoadChecker::check): >+ (WebKit::NetworkLoadChecker::prepareRedirectedRequest): >+ * NetworkProcess/NetworkLoadChecker.h: >+ > 2019-01-01 Jeff Miller <jeffm@apple.com> > > Update user-visible copyright strings to include 2019 >diff --git a/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp b/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp >index dab152e9f3fd25c056fef466330065a666858da5..ba76eeb0eac574e53e6e7e9fc8c6d6899528a7d8 100644 >--- a/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp >+++ b/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp >@@ -84,19 +84,11 @@ void NetworkLoadChecker::check(ResourceRequest&& request, ContentSecurityPolicyC > m_loadInformation.request = request; > > m_firstRequestHeaders = request.httpHeaderFields(); >- // FIXME: We should not get this information from the request but directly from some NetworkProcess setting. >- m_dntHeaderValue = m_firstRequestHeaders.get(HTTPHeaderName::DNT); >- if (m_dntHeaderValue.isNull() && m_sessionID.isEphemeral()) { >- m_dntHeaderValue = "1"; >- request.setHTTPHeaderField(HTTPHeaderName::DNT, m_dntHeaderValue); >- } > checkRequest(WTFMove(request), client, WTFMove(handler)); > } > > void NetworkLoadChecker::prepareRedirectedRequest(ResourceRequest& request) > { >- if (!m_dntHeaderValue.isNull()) >- request.setHTTPHeaderField(HTTPHeaderName::DNT, m_dntHeaderValue); > } > > static inline NetworkLoadChecker::RedirectionRequestOrError redirectionError(const ResourceResponse& redirectResponse, String&& errorMessage) >diff --git a/Source/WebKit/NetworkProcess/NetworkLoadChecker.h b/Source/WebKit/NetworkProcess/NetworkLoadChecker.h >index 5fcd8d0952297c2974477550d6019842b1459c9e..709f42d2f3c4944c6ece36290979781fc2dcafe0 100644 >--- a/Source/WebKit/NetworkProcess/NetworkLoadChecker.h >+++ b/Source/WebKit/NetworkProcess/NetworkLoadChecker.h >@@ -143,7 +143,6 @@ private: > size_t m_redirectCount { 0 }; > URL m_previousURL; > WebCore::PreflightPolicy m_preflightPolicy; >- String m_dntHeaderValue; > String m_referrer; > bool m_checkContentExtensions { false }; > bool m_shouldCaptureExtraNetworkLoadMetrics { false };
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193082
:
358190
|
358198
|
358199
|
358209
|
358256