Attachment 358185 Details for Bug 193048 – Patch

[patch] Patch

bug-193048-20190102105704.patch (text/plain), 1.93 KB, created by Daniel Bates on 2019-01-02 10:57:05 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-01-02 10:57:05 PST

Size: 1.93 KB

patch

obsolete

>Subversion Revision: 239568
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a1b9151ecb857bfa7a679104caad95b8fc5ecca0..f5f4d5f41045bb0e54ec3c3522425c034917669f 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-01-02  Daniel Bates  <dabates@apple.com>
>+
>+        [iOS] Pressing Tab key doesn't move to next cell with Google Sheets
>+        https://bugs.webkit.org/show_bug.cgi?id=193048
>+        <rdar://problem/46433836>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WebCore knows how interpret the Tab and Shift + Tab keys. When building with UIKit keyboard additions
>+        we do not need to register key commands for handling them from the UIProcess code. Instead UIKit will
>+        sends key events for these commands to us. This will make the behavior of these key commands when executed
>+        in an editable field match the behavior of these command when executed in a non-editable field since
>+        both code paths will now go through WebCore.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView keyCommands]): Deleted.
>+
> 2018-12-19  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Interpret text key commands on keydown and app key commands on keypress
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index bda7729d1330ecc33fc7c85012314c071a529c2e..aca6e01d5caa8c95603585e2307095e421178157 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -3304,6 +3304,7 @@ - (void)accessoryDone
>     [self resignFirstResponder];
> }
> 
>+#if !USE(UIKIT_KEYBOARD_ADDITIONS)
> - (NSArray *)keyCommands
> {
>     if (!_page->editorState().isContentEditable)
>@@ -3315,6 +3316,7 @@ - (NSArray *)keyCommands
>     ] retain];
>     return editableKeyCommands;
> }
>+#endif
> 
> - (void)_nextAccessoryTabForWebView:(id)sender
> {

Flags:

dbates: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193048: 358120 | 358185 | 359811