WebKit Bugzilla
Attachment 358134 Details for
Bug 193050
: [JSC] Identifier validity should be based on ID_Start / ID_Continue properties
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193050-20181229014829.patch (text/plain), 27.58 KB, created by
Ross Kirsling
on 2018-12-28 23:48:30 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Ross Kirsling
Created:
2018-12-28 23:48:30 PST
Size:
27.58 KB
patch
obsolete
>Subversion Revision: 239556 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 17e010891210bef58b46a33cef329ca3a41b7833..1143e163d78ff4b4e00f0ce74dda31bb6906a43d 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,25 @@ >+2018-12-29 Ross Kirsling <ross.kirsling@sony.com> >+ >+ [JSC] Identifier validity should be based on ID_Start / ID_Continue properties >+ https://bugs.webkit.org/show_bug.cgi?id=193050 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ From https://tc39.github.io/ecma262/#sec-names-and-keywords: >+ UnicodeIDStart:: >+ any Unicode code point with the Unicode property "ID_Start" >+ UnicodeIDContinue:: >+ any Unicode code point with the Unicode property "ID_Continue" >+ >+ * parser/Lexer.cpp: >+ (JSC::Lexer<T>::Lexer): >+ (JSC::isNonLatin1IdentStart): >+ (JSC::isNonLatin1IdentPart): >+ (JSC::isIdentPart): >+ (JSC::Lexer<T>::lex): >+ Ensure identifier start / part is based on ID_Start / ID_Continue. >+ (Implies a special case for U+00B7, which is Latin-1 but Other_ID_Continue.) >+ > 2018-12-27 Alex Christensen <achristensen@webkit.org> > > Resurrect Mac CMake build >diff --git a/Source/JavaScriptCore/parser/Lexer.cpp b/Source/JavaScriptCore/parser/Lexer.cpp >index cb460d7c1c18c1bfdf492ce877cacac0122d9003..122c4d91d4b17c54e714faf428b3194412f0ea18 100644 >--- a/Source/JavaScriptCore/parser/Lexer.cpp >+++ b/Source/JavaScriptCore/parser/Lexer.cpp >@@ -57,6 +57,10 @@ enum CharacterType { > CharacterZero, > CharacterNumber, > >+ // For single-byte characters grandfathered into Other_ID_Continue -- namely just U+00B7 MIDDLE DOT. >+ // (http://unicode.org/reports/tr31/#Backward_Compatibility) >+ CharacterOtherIdentifierPart, >+ > CharacterInvalid, > CharacterLineTerminator, > CharacterExclamationMark, >@@ -278,7 +282,7 @@ static constexpr const unsigned short typesOfLatin1Characters[256] = { > /* 180 - Sk category */ CharacterInvalid, > /* 181 - Ll category */ CharacterIdentifierStart, > /* 182 - So category */ CharacterInvalid, >-/* 183 - Po category */ CharacterInvalid, >+/* 183 - Po category */ CharacterOtherIdentifierPart, > /* 184 - Sk category */ CharacterInvalid, > /* 185 - No category */ CharacterInvalid, > /* 186 - Ll category */ CharacterIdentifierStart, >@@ -727,7 +731,7 @@ ALWAYS_INLINE void Lexer<T>::skipWhitespace() > > static NEVER_INLINE bool isNonLatin1IdentStart(UChar c) > { >- return U_GET_GC_MASK(c) & U_GC_L_MASK; >+ return u_hasBinaryProperty(c, UCHAR_ID_START); > } > > static ALWAYS_INLINE bool isLatin1(LChar) >@@ -757,16 +761,15 @@ static inline bool isIdentStart(UChar32 c) > > static NEVER_INLINE bool isNonLatin1IdentPart(UChar32 c) > { >- // FIXME: ES6 says this should be based on the Unicode property ID_Continue now instead. >- return (U_GET_GC_MASK(c) & (U_GC_L_MASK | U_GC_MN_MASK | U_GC_MC_MASK | U_GC_ND_MASK | U_GC_PC_MASK)) || c == 0x200C || c == 0x200D; >+ return u_hasBinaryProperty(c, UCHAR_ID_CONTINUE) || c == 0x200C || c == 0x200D; > } > > static ALWAYS_INLINE bool isIdentPart(LChar c) > { > // Character types are divided into two groups depending on whether they can be part of an >- // identifier or not. Those whose type value is less or equal than CharacterNumber can be >+ // identifier or not. Those whose type value is less or equal than CharacterOtherIdentifierPart can be > // part of an identifier. (See the CharacterType definition for more details.) >- return typesOfLatin1Characters[c] <= CharacterNumber; >+ return typesOfLatin1Characters[c] <= CharacterOtherIdentifierPart; > } > > static ALWAYS_INLINE bool isIdentPart(UChar32 c) >@@ -2312,6 +2315,7 @@ start: > goto parseIdent; > > FALLTHROUGH; >+ case CharacterOtherIdentifierPart: > case CharacterInvalid: > m_lexErrorMessage = invalidCharacterMessage(); > token = ERRORTOK; >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 76c38d92500820641145ee49c7c8d94fec3584c1..0b009931b77d7610a8c17c0cb267184ac8297b4b 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,39 @@ >+2018-12-29 Ross Kirsling <ross.kirsling@sony.com> >+ >+ [JSC] Identifier validity should be based on ID_Start / ID_Continue properties >+ https://bugs.webkit.org/show_bug.cgi?id=193050 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt: >+ * sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt: >+ * sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt: >+ * sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt: >+ * sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt: >+ * sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt: >+ * sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt: >+ * sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt: >+ * sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt: >+ * sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt: >+ * sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt: >+ * sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt: >+ * sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt: >+ * sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt: >+ * sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt: >+ * sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt: >+ * sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt: >+ * sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt: >+ * sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt: >+ * sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: >+ * sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt: >+ * sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: >+ * sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: >+ * sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: >+ * sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt: >+ * sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: >+ * sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt: >+ Update expectations for outdated tests. >+ > 2018-12-23 Carlos Garcia Campos <cgarcia@igalia.com> > > Unreviewed GTK+ gardening. Rebaseline fast/text/zero-font-size.html after r239539. >diff --git a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt >index 62631585fc111d2b45e8cb9ec2d6c47d81493723..509047a100008ae65a27b24a154c5e9475758de4 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A1.1_T2 > >-FAIL SputnikError: #2118 >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt >index 1eba35f704456e1e83fe489f2346c779c267176b..0e724a6a907a1cb6271ee249ad7c9f8736f20d27 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A1.1_T6 > >-FAIL SputnikError: #2160 >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt >index bca1057ae535556391caddc3fcf756611faa662b..c02ea1addce18c5308ef92b75ea3a0d8b021519c 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.2_T2 > >-FAIL SputnikError: #2118 >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt >index 1465e32811a3db52fe0a8b3ed5fde49343ef8cd1..4c66185ef089871d058d71aad555f1986e3712c4 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.2_T6 > >-FAIL SputnikError: #2160 >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt >index 914ec9a0a7974a99488d2bd3e799d0b3e846cffb..91f6ea8ad02603d9bd21355a711e59c45c6635f2 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.3_T1 > >-FAIL SputnikError: #01F6-01F9 >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt >index d7ed407438cd07f65ca255b4f74195ca45fbcae9..810c9250c2b6e3310e96793c82d52beb869912d3 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.3_T2 > >-FAIL SputnikError: #01F6-01F9 >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt >index 270b7c7794ecb39f221e7812ba6c24699a73d563..0e724a6a907a1cb6271ee249ad7c9f8736f20d27 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A1.1_T6 > >-FAIL SputnikError: #16EE >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt >index 9e6534eaf6dd61b7720cab1da297c0652fa4f736..9b064e10a0bca1264f1da9618221d86ea7d80fd7 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A2.3 > >-FAIL SputnikError: #1369 >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt >index 13cfde5d9b062c1d03f388acb72ed923890146e5..2f8b35ce9feb132f7f210e25aa54f7bbcb3d93ef 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A3.1 > >-FAIL SputnikError: #0221 >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt >index deef42c4e113b25a4a9ab550f2f08cb5fb0973fd..4c66185ef089871d058d71aad555f1986e3712c4 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.2_T6 > >-FAIL SputnikError: #16EE >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt >index c263932d837f047e3a1210ad363c033600ab5689..1b2381cbd2628b312c497c29a39e284171b0d075 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.2_T9 > >-FAIL SputnikError: #1369 >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt >index 1093f9afc7f3f0499337688e806dc53d4cd290f9..91f6ea8ad02603d9bd21355a711e59c45c6635f2 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.3_T1 > >-FAIL SputnikError: #0221 >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt >index 2e2f0b8d593f57698090613a433bec5b09e75505..810c9250c2b6e3310e96793c82d52beb869912d3 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.3_T2 > >-FAIL SputnikError: #0221 >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt >index 270b7c7794ecb39f221e7812ba6c24699a73d563..0e724a6a907a1cb6271ee249ad7c9f8736f20d27 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A1.1_T6 > >-FAIL SputnikError: #16EE >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt >index 6495e3258744966e636727ba139f51b5992c8a0d..2f8b35ce9feb132f7f210e25aa54f7bbcb3d93ef 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A3.1 > >-FAIL SputnikError: #0242-024F >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt >index deef42c4e113b25a4a9ab550f2f08cb5fb0973fd..4c66185ef089871d058d71aad555f1986e3712c4 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.2_T6 > >-FAIL SputnikError: #16EE >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt >index 1babac0b801538c3e32fb322fb98bf06fc23e2f4..91f6ea8ad02603d9bd21355a711e59c45c6635f2 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.3_T1 > >-FAIL SputnikError: #0242-024F >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt >index 570215b7a357d423885e4553fdae4510892f35ef..810c9250c2b6e3310e96793c82d52beb869912d3 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.3_T2 > >-FAIL SputnikError: #0242-024F >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt >index 270b7c7794ecb39f221e7812ba6c24699a73d563..0e724a6a907a1cb6271ee249ad7c9f8736f20d27 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A1.1_T6 > >-FAIL SputnikError: #16EE >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt >index 89355d2a0e3770edb8b3580834e385e9f938d316..2f8b35ce9feb132f7f210e25aa54f7bbcb3d93ef 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A3.1 > >-FAIL SputnikError: #02EC >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt >index deef42c4e113b25a4a9ab550f2f08cb5fb0973fd..4c66185ef089871d058d71aad555f1986e3712c4 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.2_T6 > >-FAIL SputnikError: #16EE >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt >index 11bd73853b1bdc7f54fff61d2823c883193ed4b6..91f6ea8ad02603d9bd21355a711e59c45c6635f2 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.3_T1 > >-FAIL SputnikError: #02EC >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt >index bf49904f6e84e72e54c0fff2c80b06c124e71f9b..810c9250c2b6e3310e96793c82d52beb869912d3 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.3_T2 > >-FAIL SputnikError: #02EC >+FAIL SputnikError: #00B7 > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt >index 2e4dfe450773b1e32831aa2c7bdd12724364e1f4..77e38a44deca22d8e53d4fdd8273dd6d2ef942e2 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A1.1_T4 > >-PASS >+FAIL SputnikError: #2E2F > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt >index 270b7c7794ecb39f221e7812ba6c24699a73d563..0e724a6a907a1cb6271ee249ad7c9f8736f20d27 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A1.1_T6 > >-FAIL SputnikError: #16EE >+PASS > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt >index 004f20ffceb93035149172adc33c29bdb746be6e..594c41d53113c2ca936905d90ee25f9c6f7cc6b2 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.2_T4 > >-PASS >+FAIL SputnikError: #2E2F > > TEST COMPLETE > >diff --git a/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt b/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt >index deef42c4e113b25a4a9ab550f2f08cb5fb0973fd..4c66185ef089871d058d71aad555f1986e3712c4 100644 >--- a/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt >+++ b/LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt >@@ -1,6 +1,6 @@ > S7.6_A5.2_T6 > >-FAIL SputnikError: #16EE >+PASS > > TEST COMPLETE > >diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog >index 9e350a323faf25b7963d0be326807ff5799ed587..250e97f6c21244c8cc8e664824847802ff75a2c2 100644 >--- a/JSTests/ChangeLog >+++ b/JSTests/ChangeLog >@@ -1,3 +1,14 @@ >+2018-12-29 Ross Kirsling <ross.kirsling@sony.com> >+ >+ [JSC] Identifier validity should be based on ID_Start / ID_Continue properties >+ https://bugs.webkit.org/show_bug.cgi?id=193050 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * test262.yaml: >+ * test262/expectations.yaml: >+ Mark 16 tests as passing. >+ > 2018-12-13 Yusuke Suzuki <yusukesuzuki@slowstart.org> > > [BigInt] Support BigInt in JSON.stringify >diff --git a/JSTests/test262.yaml b/JSTests/test262.yaml >index bcc74712b52925f771a5154fac75ca18abe540e5..bc4fc0c71f3ecbfd263b2489441c7877266fdc72 100644 >--- a/JSTests/test262.yaml >+++ b/JSTests/test262.yaml >@@ -89044,21 +89044,21 @@ > - path: test262/test/language/identifier-resolution/unscopables.js > cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] > - path: test262/test/language/identifiers/other_id_continue-escaped.js >- cmd: runTest262 :fail, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [] >+ cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [] > - path: test262/test/language/identifiers/other_id_continue-escaped.js >- cmd: runTest262 :fail, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] >+ cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] > - path: test262/test/language/identifiers/other_id_continue.js >- cmd: runTest262 :fail, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [] >+ cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [] > - path: test262/test/language/identifiers/other_id_continue.js >- cmd: runTest262 :fail, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] >+ cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] > - path: test262/test/language/identifiers/other_id_start-escaped.js >- cmd: runTest262 :fail, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [] >+ cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [] > - path: test262/test/language/identifiers/other_id_start-escaped.js >- cmd: runTest262 :fail, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] >+ cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] > - path: test262/test/language/identifiers/other_id_start.js >- cmd: runTest262 :fail, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [] >+ cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [] > - path: test262/test/language/identifiers/other_id_start.js >- cmd: runTest262 :fail, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] >+ cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] > - path: test262/test/language/identifiers/part-digits-via-escape-hex.js > cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [] > - path: test262/test/language/identifiers/part-digits-via-escape-hex.js >@@ -89598,21 +89598,21 @@ > - path: test262/test/language/identifiers/vals-rus-alpha-upper.js > cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] > - path: test262/test/language/identifiers/vertical-tilde-continue-escaped.js >- cmd: runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [] >+ cmd: runTest262 :normal, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [] > - path: test262/test/language/identifiers/vertical-tilde-continue-escaped.js >- cmd: runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] >+ cmd: runTest262 :normal, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] > - path: test262/test/language/identifiers/vertical-tilde-continue.js >- cmd: runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [] >+ cmd: runTest262 :normal, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [] > - path: test262/test/language/identifiers/vertical-tilde-continue.js >- cmd: runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] >+ cmd: runTest262 :normal, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] > - path: test262/test/language/identifiers/vertical-tilde-start-escaped.js >- cmd: runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [] >+ cmd: runTest262 :normal, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [] > - path: test262/test/language/identifiers/vertical-tilde-start-escaped.js >- cmd: runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] >+ cmd: runTest262 :normal, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] > - path: test262/test/language/identifiers/vertical-tilde-start.js >- cmd: runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [] >+ cmd: runTest262 :normal, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [] > - path: test262/test/language/identifiers/vertical-tilde-start.js >- cmd: runTest262 :fail, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] >+ cmd: runTest262 :normal, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [:strict] > - path: test262/test/language/import/dup-bound-names.js > cmd: runTest262 :normal, "SyntaxError", ["../../../harness/assert.js", "../../../harness/sta.js"], [:module] > - path: test262/test/language/import/escaped-as-import-specifier.js >diff --git a/JSTests/test262/expectations.yaml b/JSTests/test262/expectations.yaml >index f8de46233ff51194a1bbbb6091eda05991344a31..3be8dec314fa1669b3309cb407bc9010a7dde87e 100644 >--- a/JSTests/test262/expectations.yaml >+++ b/JSTests/test262/expectations.yaml >@@ -6953,33 +6953,9 @@ test/language/global-code/script-decl-func-err-non-extensible.js: > test/language/global-code/script-decl-var-err.js: > default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all' > strict mode: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all' >-test/language/identifiers/other_id_continue-escaped.js: >- default: "SyntaxError: Invalid unicode escape in identifier: 'a\\u2118'" >- strict mode: "SyntaxError: Invalid unicode escape in identifier: 'a\\u2118'" >-test/language/identifiers/other_id_continue.js: >- default: "SyntaxError: Invalid character '\\u2118'" >- strict mode: "SyntaxError: Invalid character '\\u2118'" >-test/language/identifiers/other_id_start-escaped.js: >- default: "SyntaxError: Invalid unicode escape in identifier: '\\u2118'" >- strict mode: "SyntaxError: Invalid unicode escape in identifier: '\\u2118'" >-test/language/identifiers/other_id_start.js: >- default: "SyntaxError: Invalid character '\\u2118'" >- strict mode: "SyntaxError: Invalid character '\\u2118'" > test/language/identifiers/val-yield-strict.js: > default: 'Test262: This statement should not be evaluated.' > strict mode: "SyntaxError: Cannot use 'yield' as a variable name in strict mode." >-test/language/identifiers/vertical-tilde-continue-escaped.js: >- default: 'Test262: This statement should not be evaluated.' >- strict mode: 'Test262: This statement should not be evaluated.' >-test/language/identifiers/vertical-tilde-continue.js: >- default: 'Test262: This statement should not be evaluated.' >- strict mode: 'Test262: This statement should not be evaluated.' >-test/language/identifiers/vertical-tilde-start-escaped.js: >- default: 'Test262: This statement should not be evaluated.' >- strict mode: 'Test262: This statement should not be evaluated.' >-test/language/identifiers/vertical-tilde-start.js: >- default: 'Test262: This statement should not be evaluated.' >- strict mode: 'Test262: This statement should not be evaluated.' > test/language/literals/numeric/numeric-separator-literal-bil-bd-nsl-bd.js: > default: 'SyntaxError: No space between binary literal and identifier' > strict mode: 'SyntaxError: No space between binary literal and identifier'
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193050
:
358123
|
358124
|
358125
|
358126
|
358127
|
358128
| 358134