Attachment 358133 Details for Bug 193054 – Patch

[patch] Patch

bug-193054-20181228230240.patch (text/plain), 2.74 KB, created by dewei_zhu on 2018-12-28 23:02:41 PST

(hide)

Description:

Filename:

MIME Type:

Creator: dewei_zhu

Created: 2018-12-28 23:02:41 PST

Size: 2.74 KB

patch

obsolete

>Subversion Revision: 239556
>diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
>index 0936909761a24f17dcf3aa9b7a42ee14d24be505..167fcb777d0f5a5833a112efb306db54a7ae0ea4 100644
>--- a/Websites/perf.webkit.org/ChangeLog
>+++ b/Websites/perf.webkit.org/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-28  Dewei Zhu  <dewei_zhu@apple.com>
>+
>+        Should expose other authors from same analysis task to finalize script.
>+        https://bugs.webkit.org/show_bug.cgi?id=193054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add support to send notification to other authors from same analysis task by exposing
>+        their information to finalize script.
>+
>+        * tools/js/analysis-results-notifier.js:
>+        (AnalysisResultsNotifier.prototype.async.sendNotificationsForTestGroups):
>+
> 2018-12-14  Dewei Zhu  <dewei_zhu@apple.com>
> 
>         Extend commits table to contain testability information.
>diff --git a/Websites/perf.webkit.org/tools/js/analysis-results-notifier.js b/Websites/perf.webkit.org/tools/js/analysis-results-notifier.js
>index 48e2129ebea45fefb92e1918b55d0d4fb9fc1d42..e8e0eb864399778c7e45bc5050b82190f7b9df75 100644
>--- a/Websites/perf.webkit.org/tools/js/analysis-results-notifier.js
>+++ b/Websites/perf.webkit.org/tools/js/analysis-results-notifier.js
>@@ -36,11 +36,21 @@ class AnalysisResultsNotifier {
>     {
>         for (const testGroup of testGroups) {
>             await testGroup.fetchTask();
>+            const allTestGroupsFromSameTask = await TestGroup.fetchForTask(testGroup.task().id());
>+            const otherTestGroupsFromSameTask = allTestGroupsFromSameTask.filter((otherTestGroup) => otherTestGroup.id() != testGroup.id());
>             const title = `"${testGroup.task().name()}" - "${testGroup.name()}" has finished`;
>             const message = await AnalysisResultsNotifier._messageForTestGroup(testGroup, title);
>             let content = AnalysisResultsNotifier._instantiateNotificationTemplate(this._messageTemplate, title, message);
>             content = this._applyRules(testGroup.platform().name(), testGroup.test().path()[0].name(), !!testGroup.author(), content);
>-            const testGroupInfo = {author: testGroup.author()};
>+
>+            const otherAuthorsFromSameTask = new Set;
>+            for (const otherTestGroup of otherTestGroupsFromSameTask)
>+            {
>+                if (testGroup.author() == otherTestGroup.author())
>+                    continue;
>+                otherAuthorsFromSameTask.add(otherTestGroup.author());
>+            }
>+            const testGroupInfo = {author: testGroup.author(), otherAuthorsFromSameTask: Array.from(otherAuthorsFromSameTask)};
> 
>             const tempDir = fs.mkdtempSync(os.tmpdir());
>             const tempFilePath = path.join(tempDir, 'temp-content.json');

Flags:

rniwa: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193054: 358132 | 358133