Attachment 358129 Details for Bug 193053 – Patch

[patch] Patch

bug-193053-20181228213607.patch (text/plain), 8.22 KB, created by Ross Kirsling on 2018-12-28 19:36:08 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Ross Kirsling

Created: 2018-12-28 19:36:08 PST

Size: 8.22 KB

patch

obsolete

>Subversion Revision: 239556
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 2842d800182ad71f6aa1308e45e47a6cb82481e3..d3aad27d2fcf8ce1d5d9993ba6203608fa1b8ba7 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-28  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        test262-runner misbehaves when test file YAML has a trailing space
>+        https://bugs.webkit.org/show_bug.cgi?id=193053
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/test262/Runner.pm:
>+        (parseData):
>+        Accept trailing space when parsing a test file's YAML block.
>+
> 2018-12-27  Alex Christensen  <achristensen@webkit.org>
> 
>         Resurrect Mac CMake build
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index 6af261df24206dcf1587b08977f461379fa1572e..e948a440c3cf928221a9e05c42ea9f77d98b752a 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -871,7 +871,7 @@ sub parseData {
> 
>     my $parsed;
>     my $found = '';
>-    if ($contents =~ /\/\*(---[\r\n]+[\S\s]*)[\r\n]+---\*\//m) {
>+    if ($contents =~ /\/\*(---[\r\n]+[\S\s]*)[\r\n]+\s*---\*\//m) {
>         $found = $1;
>     };
> 
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index 9e350a323faf25b7963d0be326807ff5799ed587..bb117831a4340ba399a76bf1edc1991b81e90b40 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-12-28  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        test262-runner misbehaves when test file YAML has a trailing space
>+        https://bugs.webkit.org/show_bug.cgi?id=193053
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * test262/expectations.yaml:
>+        Mark two dozen tests as passing (and correct the output of another).
>+
> 2018-12-13  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
> 
>         [BigInt] Support BigInt in JSON.stringify
>diff --git a/JSTests/test262/expectations.yaml b/JSTests/test262/expectations.yaml
>index f8de46233ff51194a1bbbb6091eda05991344a31..806fb8e6fde095454752d4b29e2ff865cca2171d 100644
>--- a/JSTests/test262/expectations.yaml
>+++ b/JSTests/test262/expectations.yaml
>@@ -1049,9 +1049,6 @@ test/built-ins/Object/defineProperties/15.2.3.7-5-a-16.js:
> test/built-ins/Object/defineProperties/15.2.3.7-5-b-248.js:
>   default: 'TypeError: Property description must be an object.'
>   strict mode: 'TypeError: Property description must be an object.'
>-test/built-ins/Object/defineProperty/15.2.3.6-4-289-1.js:
>-  default: "ReferenceError: Can't find variable: verifyEqualTo"
>-  strict mode: "ReferenceError: Can't find variable: verifyEqualTo"
> test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments.js:
>   default: 'Test262Error: Expected SameValue(ÃÂ«nullÃÂ», ÃÂ«[object Arguments]ÃÂ») to be true'
> test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller.js:
>@@ -6782,18 +6779,6 @@ test/language/expressions/object/method-definition/yield-as-function-expression-
>   strict mode: "SyntaxError: Cannot use 'yield' as a function name in strict mode."
> test/language/expressions/object/method-definition/yield-as-identifier-in-nested-function.js:
>   strict mode: "SyntaxError: Unexpected keyword 'yield'. Cannot use yield expression out of generator."
>-test/language/expressions/object/method-definition/yield-as-logical-or-expression.js:
>-  default: "SyntaxError: Unexpected token '?'"
>-  strict mode: "SyntaxError: Unexpected token '?'"
>-test/language/expressions/object/method-definition/yield-as-parameter.js:
>-  default: "SyntaxError: Cannot use 'yield' as a parameter name in a generator function."
>-  strict mode: "SyntaxError: Cannot use 'yield' as a parameter name in strict mode."
>-test/language/expressions/object/method-definition/yield-star-after-newline.js:
>-  default: "SyntaxError: Unexpected token '*'"
>-  strict mode: "SyntaxError: Unexpected token '*'"
>-test/language/expressions/object/method-definition/yield-weak-binding.js:
>-  default: "SyntaxError: Unexpected number '3'"
>-  strict mode: "SyntaxError: Unexpected number '3'"
> test/language/expressions/object/scope-gen-meth-body-lex-distinct.js:
>   default: 'Test262Error: Expected a SyntaxError to be thrown but no exception was thrown at all'
> test/language/expressions/object/scope-gen-meth-param-elem-var-close.js:
>@@ -6965,9 +6950,6 @@ test/language/identifiers/other_id_start-escaped.js:
> test/language/identifiers/other_id_start.js:
>   default: "SyntaxError: Invalid character '\\u2118'"
>   strict mode: "SyntaxError: Invalid character '\\u2118'"
>-test/language/identifiers/val-yield-strict.js:
>-  default: 'Test262: This statement should not be evaluated.'
>-  strict mode: "SyntaxError: Cannot use 'yield' as a variable name in strict mode."
> test/language/identifiers/vertical-tilde-continue-escaped.js:
>   default: 'Test262: This statement should not be evaluated.'
>   strict mode: 'Test262: This statement should not be evaluated.'
>@@ -7182,8 +7164,7 @@ test/language/module-code/instn-resolve-order-depth.js:
> test/language/module-code/instn-resolve-order-src.js:
>   module: "SyntaxError: 'break' is only valid inside a switch or loop statement."
> test/language/module-code/instn-star-as-props-dflt-skip.js:
>-  default: "SyntaxError: Unexpected token '{'. import call expects exactly one argument."
>-  strict mode: "SyntaxError: Unexpected token '{'. import call expects exactly one argument."
>+  module: "SyntaxError: Unexpected identifier 'as'. Expected 'from' before exported module name."
> test/language/module-code/instn-star-props-nrml.js:
>   module: "SyntaxError: Unexpected identifier 'as'. Expected 'from' before exported module name."
> test/language/module-code/namespace/internals/define-own-property.js:
>@@ -7217,24 +7198,6 @@ test/language/statements/class/class-name-ident-static.js:
> test/language/statements/class/classelementname-abrupt-completion.js:
>   default: "SyntaxError: Unexpected token '}'. Expected an opening '(' before a method's parameter list."
>   strict mode: "SyntaxError: Unexpected token '}'. Expected an opening '(' before a method's parameter list."
>-test/language/statements/class/definition/methods-gen-yield-as-function-expression-binding-identifier.js:
>-  default: "SyntaxError: Cannot use 'yield' as a function name in strict mode."
>-  strict mode: "SyntaxError: Cannot use 'yield' as a function name in strict mode."
>-test/language/statements/class/definition/methods-gen-yield-as-identifier-in-nested-function.js:
>-  default: "SyntaxError: Unexpected keyword 'yield'. Cannot use yield expression out of generator."
>-  strict mode: "SyntaxError: Unexpected keyword 'yield'. Cannot use yield expression out of generator."
>-test/language/statements/class/definition/methods-gen-yield-as-logical-or-expression.js:
>-  default: "SyntaxError: Unexpected token '?'"
>-  strict mode: "SyntaxError: Unexpected token '?'"
>-test/language/statements/class/definition/methods-gen-yield-as-parameter.js:
>-  default: "SyntaxError: Cannot use 'yield' as a parameter name in strict mode."
>-  strict mode: "SyntaxError: Cannot use 'yield' as a parameter name in strict mode."
>-test/language/statements/class/definition/methods-gen-yield-star-after-newline.js:
>-  default: "SyntaxError: Unexpected token '*'"
>-  strict mode: "SyntaxError: Unexpected token '*'"
>-test/language/statements/class/definition/methods-gen-yield-weak-binding.js:
>-  default: "SyntaxError: Unexpected number '3'"
>-  strict mode: "SyntaxError: Unexpected number '3'"
> test/language/statements/class/dstr-private-gen-meth-ary-init-iter-close.js:
>   default: "SyntaxError: Invalid character: '#'"
>   strict mode: "SyntaxError: Invalid character: '#'"
>@@ -11097,9 +11060,6 @@ test/language/statements/labeled/value-yield-non-strict-escaped.js:
>   default: "SyntaxError: Unexpected escaped characters in keyword token: 'yi\\u0065ld'"
> test/language/statements/labeled/value-yield-non-strict.js:
>   strict mode: "SyntaxError: Cannot use 'yield' as a label in strict mode."
>-test/language/statements/labeled/value-yield-strict.js:
>-  default: 'Test262: This statement should not be evaluated.'
>-  strict mode: "SyntaxError: Cannot use 'yield' as a label in strict mode."
> test/language/statements/let/block-local-closure-set-before-initialization.js:
>   default: 'Test262Error: Expected a ReferenceError to be thrown but no exception was thrown at all'
> test/language/statements/let/syntax/attempt-to-redeclare-let-binding-with-function-declaration.js:

Actions: View | Formatted Diff | Diff

Attachments on bug 193053: 358129 | 358277