WebKit Bugzilla
Attachment 358122 Details for
Bug 192734
: SourceProviders should use an actual URL instead of a string
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192734-20181228135510.patch (text/plain), 77.04 KB, created by
Keith Miller
on 2018-12-28 13:55:11 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Keith Miller
Created:
2018-12-28 13:55:11 PST
Size:
77.04 KB
patch
obsolete
>Subversion Revision: 239556 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 17e010891210bef58b46a33cef329ca3a41b7833..5152c391ec3b8c0f3a0f53e524bb0bae6d46a8d4 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,45 @@ >+2018-12-28 Keith Miller <keith_miller@apple.com> >+ >+ SourceProviders should use an actual URL instead of a string >+ https://bugs.webkit.org/show_bug.cgi?id=192734 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ This will be useful for the Module loader API in the future where >+ by default it will use the relative path from the referring module >+ to resolve dependencies. >+ >+ * API/JSBase.cpp: >+ (JSEvaluateScript): >+ (JSCheckScriptSyntax): >+ * API/JSScriptRef.cpp: >+ (OpaqueJSScript::create): >+ (OpaqueJSScript::OpaqueJSScript): >+ * API/glib/JSCContext.cpp: >+ (jsc_context_check_syntax): >+ * jsc.cpp: >+ (jscSource): >+ (GlobalObject::moduleLoaderFetch): >+ (functionRun): >+ (functionCheckModuleSyntax): >+ (runWithOptions): >+ * parser/SourceCode.h: >+ (JSC::makeSource): >+ * parser/SourceProvider.cpp: >+ (JSC::SourceProvider::SourceProvider): >+ * parser/SourceProvider.h: >+ (JSC::SourceProvider::url const): >+ (JSC::StringSourceProvider::create): >+ (JSC::StringSourceProvider::StringSourceProvider): >+ (JSC::WebAssemblySourceProvider::create): >+ (JSC::WebAssemblySourceProvider::WebAssemblySourceProvider): >+ * runtime/FunctionConstructor.cpp: >+ (JSC::constructFunctionSkippingEvalEnabledCheck): >+ * tools/CodeProfile.h: >+ (JSC::CodeProfile::CodeProfile): >+ * tools/FunctionOverrides.cpp: >+ (JSC::initializeOverrideInfo): >+ > 2018-12-27 Alex Christensen <achristensen@webkit.org> > > Resurrect Mac CMake build >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index e79aa6e5a7232824e41737095dbbbcb0f0922cc2..64e4b4c9fdc995edba00267933bb49b025890e0c 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,74 @@ >+2018-12-28 Keith Miller <keith_miller@apple.com> >+ >+ SourceProviders should use an actual URL instead of a string >+ https://bugs.webkit.org/show_bug.cgi?id=192734 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Remove ScriptSourceCode's URL member and make the url() method >+ reference the URL on the SourceProvider. Also, avoid some >+ ref count churn. >+ >+ Additionally, this patch fixes an existing bug in >+ WorkletGlobalScope() that would use a ScriptSourceCode after >+ WTFMoving it. >+ >+ * bindings/js/CachedScriptSourceProvider.h: >+ (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider): >+ * bindings/js/ScheduledAction.cpp: >+ (WebCore::ScheduledAction::execute): >+ * bindings/js/ScriptController.cpp: >+ (WebCore::ScriptController::executeScriptInWorld): >+ (WebCore::ScriptController::executeScript): >+ * bindings/js/ScriptSourceCode.h: >+ (WebCore::ScriptSourceCode::ScriptSourceCode): >+ (WebCore::ScriptSourceCode::m_code): >+ (WebCore::ScriptSourceCode::url const): >+ (WebCore::ScriptSourceCode::m_url): Deleted. >+ * dom/ScriptElement.cpp: >+ (WebCore::ScriptElement::prepareScript): >+ (WebCore::ScriptElement::requestModuleScript): >+ (WebCore::ScriptElement::executePendingScript): >+ * html/HTMLMediaElement.cpp: >+ (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): >+ * page/Frame.cpp: >+ (WebCore::Frame::injectUserScriptImmediately): >+ * workers/WorkerGlobalScope.cpp: >+ (WebCore::WorkerGlobalScope::importScripts): >+ * workers/WorkerThread.cpp: >+ (WebCore::WorkerThread::workerThread): >+ * xml/parser/XMLDocumentParserLibxml2.cpp: >+ (WebCore::XMLDocumentParser::endElementNs): >+ >+ * bindings/js/CachedScriptSourceProvider.h: >+ (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider): >+ * bindings/js/ScheduledAction.cpp: >+ (WebCore::ScheduledAction::execute): >+ * bindings/js/ScriptController.cpp: >+ (WebCore::ScriptController::executeScriptInWorld): >+ (WebCore::ScriptController::executeScript): >+ * bindings/js/ScriptSourceCode.h: >+ (WebCore::ScriptSourceCode::ScriptSourceCode): >+ (WebCore::ScriptSourceCode::m_code): >+ (WebCore::ScriptSourceCode::url const): >+ (WebCore::ScriptSourceCode::m_url): Deleted. >+ * dom/ScriptElement.cpp: >+ (WebCore::ScriptElement::prepareScript): >+ (WebCore::ScriptElement::requestModuleScript): >+ (WebCore::ScriptElement::executePendingScript): >+ * html/HTMLMediaElement.cpp: >+ (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): >+ * page/Frame.cpp: >+ (WebCore::Frame::injectUserScriptImmediately): >+ * workers/WorkerGlobalScope.cpp: >+ (WebCore::WorkerGlobalScope::importScripts): >+ * workers/WorkerThread.cpp: >+ (WebCore::WorkerThread::workerThread): >+ * worklets/WorkletGlobalScope.cpp: >+ (WebCore::WorkletGlobalScope::WorkletGlobalScope): >+ * xml/parser/XMLDocumentParserLibxml2.cpp: >+ (WebCore::XMLDocumentParser::endElementNs): >+ > 2018-12-27 Alex Christensen <achristensen@webkit.org> > > Resurrect Mac CMake build >diff --git a/Source/JavaScriptCore/API/JSBase.cpp b/Source/JavaScriptCore/API/JSBase.cpp >index fed818243e8f0021b4b9e99754f8814703b219d3..734b2ec37c58b45cec93267299ea58b9b027dcd3 100644 >--- a/Source/JavaScriptCore/API/JSBase.cpp >+++ b/Source/JavaScriptCore/API/JSBase.cpp >@@ -64,7 +64,7 @@ JSValueRef JSEvaluateScript(JSContextRef ctx, JSStringRef script, JSObjectRef th > // evaluate sets "this" to the global object if it is NULL > JSGlobalObject* globalObject = vm.vmEntryGlobalObject(exec); > auto sourceURLString = sourceURL ? sourceURL->string() : String(); >- SourceCode source = makeSource(script->string(), SourceOrigin { sourceURLString }, sourceURLString, TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber())); >+ SourceCode source = makeSource(script->string(), SourceOrigin { sourceURLString }, URL({ }, sourceURLString), TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber())); > > NakedPtr<Exception> evaluationException; > JSValue returnValue = profiledEvaluate(globalObject->globalExec(), ProfilingReason::API, source, jsThisObject, evaluationException); >@@ -103,7 +103,7 @@ bool JSCheckScriptSyntax(JSContextRef ctx, JSStringRef script, JSStringRef sourc > startingLineNumber = std::max(1, startingLineNumber); > > auto sourceURLString = sourceURL ? sourceURL->string() : String(); >- SourceCode source = makeSource(script->string(), SourceOrigin { sourceURLString }, sourceURLString, TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber())); >+ SourceCode source = makeSource(script->string(), SourceOrigin { sourceURLString }, URL({ }, sourceURLString), TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber())); > > JSValue syntaxException; > bool isValidSyntax = checkSyntax(vm.vmEntryGlobalObject(exec)->globalExec(), source, &syntaxException); >diff --git a/Source/JavaScriptCore/API/JSScriptRef.cpp b/Source/JavaScriptCore/API/JSScriptRef.cpp >index bb720dbe8d71a828dd86d8fd78a9e358df3a720f..253caa8972edeefe503a6c59aeb0f35d0e872dc7 100644 >--- a/Source/JavaScriptCore/API/JSScriptRef.cpp >+++ b/Source/JavaScriptCore/API/JSScriptRef.cpp >@@ -41,9 +41,9 @@ using namespace JSC; > > struct OpaqueJSScript : public SourceProvider { > public: >- static WTF::Ref<OpaqueJSScript> create(VM& vm, const SourceOrigin& sourceOrigin, const String& url, int startingLineNumber, const String& source) >+ static WTF::Ref<OpaqueJSScript> create(VM& vm, const SourceOrigin& sourceOrigin, URL&& url, int startingLineNumber, const String& source) > { >- return WTF::adoptRef(*new OpaqueJSScript(vm, sourceOrigin, url, startingLineNumber, source)); >+ return WTF::adoptRef(*new OpaqueJSScript(vm, sourceOrigin, WTFMove(url), startingLineNumber, source)); > } > > unsigned hash() const override >@@ -59,8 +59,8 @@ public: > VM& vm() const { return m_vm; } > > private: >- OpaqueJSScript(VM& vm, const SourceOrigin& sourceOrigin, const String& url, int startingLineNumber, const String& source) >- : SourceProvider(sourceOrigin, url, TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber()), SourceProviderSourceType::Program) >+ OpaqueJSScript(VM& vm, const SourceOrigin& sourceOrigin, URL&& url, int startingLineNumber, const String& source) >+ : SourceProvider(sourceOrigin, WTFMove(url), TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber()), SourceProviderSourceType::Program) > , m_vm(vm) > , m_source(source.isNull() ? *StringImpl::empty() : *source.impl()) > { >@@ -94,7 +94,7 @@ JSScriptRef JSScriptCreateReferencingImmortalASCIIText(JSContextGroupRef context > startingLineNumber = std::max(1, startingLineNumber); > > auto sourceURLString = url ? url->string() : String(); >- auto result = OpaqueJSScript::create(vm, SourceOrigin { sourceURLString }, sourceURLString, startingLineNumber, String(StringImpl::createFromLiteral(source, length))); >+ auto result = OpaqueJSScript::create(vm, SourceOrigin { sourceURLString }, URL({ }, sourceURLString), startingLineNumber, String(StringImpl::createFromLiteral(source, length))); > > ParserError error; > if (!parseScript(vm, SourceCode(result.copyRef()), error)) { >@@ -116,7 +116,7 @@ JSScriptRef JSScriptCreateFromString(JSContextGroupRef contextGroup, JSStringRef > startingLineNumber = std::max(1, startingLineNumber); > > auto sourceURLString = url ? url->string() : String(); >- auto result = OpaqueJSScript::create(vm, SourceOrigin { sourceURLString }, sourceURLString, startingLineNumber, source->string()); >+ auto result = OpaqueJSScript::create(vm, SourceOrigin { sourceURLString }, URL({ }, sourceURLString), startingLineNumber, source->string()); > > ParserError error; > if (!parseScript(vm, SourceCode(result.copyRef()), error)) { >diff --git a/Source/JavaScriptCore/API/glib/JSCContext.cpp b/Source/JavaScriptCore/API/glib/JSCContext.cpp >index 40ea5c14917b3cdd4f7eec0a24be200f7cc077a9..2fd7cdb1e8d61544b71cdaba1d456218afc9ede6 100644 >--- a/Source/JavaScriptCore/API/glib/JSCContext.cpp >+++ b/Source/JavaScriptCore/API/glib/JSCContext.cpp >@@ -945,7 +945,7 @@ JSCCheckSyntaxResult jsc_context_check_syntax(JSCContext* context, const char* c > > String sourceURLString = uri ? String::fromUTF8(uri) : String(); > JSC::SourceCode source = JSC::makeSource(String::fromUTF8(code, length < 0 ? strlen(code) : length), JSC::SourceOrigin { sourceURLString }, >- sourceURLString, TextPosition(OrdinalNumber::fromOneBasedInt(lineNumber), OrdinalNumber())); >+ URL({ }sourceURLString), TextPosition(OrdinalNumber::fromOneBasedInt(lineNumber), OrdinalNumber())); > bool success = false; > JSC::ParserError error; > switch (mode) { >diff --git a/Source/JavaScriptCore/jsc.cpp b/Source/JavaScriptCore/jsc.cpp >index add5a4e2ab51bccba4c74952a4ad6966f4c3eaa1..128d40d590b774ed9033ec5c6011be5502aafbd5 100644 >--- a/Source/JavaScriptCore/jsc.cpp >+++ b/Source/JavaScriptCore/jsc.cpp >@@ -87,6 +87,7 @@ > #include <wtf/MonotonicTime.h> > #include <wtf/NeverDestroyed.h> > #include <wtf/StringPrintStream.h> >+#include <wtf/URLParser.h> > #include <wtf/WallTime.h> > #include <wtf/text/StringBuilder.h> > >@@ -459,13 +460,6 @@ static inline String stringFromUTF(const Vector& utf8) > return String::fromUTF8WithLatin1Fallback(utf8.data(), utf8.size()); > } > >-template<typename Vector> >-static inline SourceCode jscSource(const Vector& utf8, const SourceOrigin& sourceOrigin, const String& filename) >-{ >- String str = stringFromUTF(utf8); >- return makeSource(str, sourceOrigin, filename); >-} >- > class GlobalObject : public JSGlobalObject { > private: > GlobalObject(VM&, Structure*); >@@ -956,6 +950,14 @@ static bool fetchScriptFromLocalFileSystem(const String& fileName, Vector<char>& > return true; > } > >+template<typename Vector> >+static inline SourceCode jscSource(const Vector& utf8, const SourceOrigin& sourceOrigin, const String& filename) >+{ >+ URL url = URL::fileURLWithFileSystemPath(absolutePath(filename)); >+ String str = stringFromUTF(utf8); >+ return makeSource(str, sourceOrigin, WTFMove(url)); >+} >+ > template<typename Vector> > static bool fetchModuleFromLocalFileSystem(const String& fileName, Vector& buffer) > { >@@ -1019,11 +1021,13 @@ JSInternalPromise* GlobalObject::moduleLoaderFetch(JSGlobalObject* globalObject, > if (!fetchModuleFromLocalFileSystem(moduleKey, buffer)) > return reject(createError(exec, makeString("Could not open file '", moduleKey, "'."))); > >+ >+ URL moduleURL = URL({ }, moduleKey); > #if ENABLE(WEBASSEMBLY) > // FileSystem does not have mime-type header. The JSC shell recognizes WebAssembly's magic header. > if (buffer.size() >= 4) { > if (buffer[0] == '\0' && buffer[1] == 'a' && buffer[2] == 's' && buffer[3] == 'm') { >- auto source = SourceCode(WebAssemblySourceProvider::create(WTFMove(buffer), SourceOrigin { moduleKey }, moduleKey)); >+ auto source = SourceCode(WebAssemblySourceProvider::create(WTFMove(buffer), SourceOrigin { moduleKey }, WTFMove(moduleURL))); > catchScope.releaseAssertNoException(); > auto sourceCode = JSSourceCode::create(vm, WTFMove(source)); > catchScope.releaseAssertNoException(); >@@ -1034,7 +1038,7 @@ JSInternalPromise* GlobalObject::moduleLoaderFetch(JSGlobalObject* globalObject, > } > #endif > >- auto sourceCode = JSSourceCode::create(vm, makeSource(stringFromUTF(buffer), SourceOrigin { moduleKey }, moduleKey, TextPosition(), SourceProviderSourceType::Module)); >+ auto sourceCode = JSSourceCode::create(vm, makeSource(stringFromUTF(buffer), SourceOrigin { moduleKey }, WTFMove(moduleURL), TextPosition(), SourceProviderSourceType::Module)); > catchScope.releaseAssertNoException(); > auto result = deferred->resolve(exec, sourceCode); > catchScope.clearException(); >@@ -1327,7 +1331,8 @@ EncodedJSValue JSC_HOST_CALL functionRun(ExecState* exec) > NakedPtr<Exception> exception; > StopWatch stopWatch; > stopWatch.start(); >- evaluate(globalObject->globalExec(), jscSource(script, SourceOrigin { absolutePath(fileName) }, fileName), JSValue(), exception); >+ fileName = absolutePath(fileName); >+ evaluate(globalObject->globalExec(), jscSource(script, SourceOrigin { fileName }, fileName), JSValue(), exception); > stopWatch.stop(); > > if (exception) { >@@ -2081,7 +2086,7 @@ EncodedJSValue JSC_HOST_CALL functionCheckModuleSyntax(ExecState* exec) > stopWatch.start(); > > ParserError error; >- bool validSyntax = checkModuleSyntax(exec, makeSource(source, { }, String(), TextPosition(), SourceProviderSourceType::Module), error); >+ bool validSyntax = checkModuleSyntax(exec, makeSource(source, { }, URL(), TextPosition(), SourceProviderSourceType::Module), error); > RETURN_IF_EXCEPTION(scope, encodedJSValue()); > stopWatch.stop(); > >@@ -2440,8 +2445,10 @@ static void runWithOptions(GlobalObject* globalObject, CommandLine& options, boo > > bool isLastFile = i == scripts.size() - 1; > if (isModule) { >- if (!promise) >- promise = loadAndEvaluateModule(globalObject->globalExec(), makeSource(stringFromUTF(scriptBuffer), SourceOrigin { absolutePath(fileName) }, fileName, TextPosition(), SourceProviderSourceType::Module), jsUndefined()); >+ if (!promise) { >+ URL fileNameURL = URL::fileURLWithFileSystemPath(absolutePath(fileName)); >+ promise = loadAndEvaluateModule(globalObject->globalExec(), makeSource(stringFromUTF(scriptBuffer), SourceOrigin { absolutePath(fileName) }, WTFMove(fileNameURL), TextPosition(), SourceProviderSourceType::Module), jsUndefined()); >+ } > scope.clearException(); > > JSFunction* fulfillHandler = JSNativeStdFunction::create(vm, globalObject, 1, String(), [&success, &options, isLastFile](ExecState* exec) { >diff --git a/Source/JavaScriptCore/parser/SourceCode.h b/Source/JavaScriptCore/parser/SourceCode.h >index 7807ce49ce0565686223c44f2dac1b09ae9734a5..313cfa45aaf922b07b045bbee0363859cbd4c09b 100644 >--- a/Source/JavaScriptCore/parser/SourceCode.h >+++ b/Source/JavaScriptCore/parser/SourceCode.h >@@ -100,9 +100,9 @@ namespace JSC { > OrdinalNumber m_startColumn; > }; > >- inline SourceCode makeSource(const String& source, const SourceOrigin& sourceOrigin, const String& url = String(), const TextPosition& startPosition = TextPosition(), SourceProviderSourceType sourceType = SourceProviderSourceType::Program) >+ inline SourceCode makeSource(const String& source, const SourceOrigin& sourceOrigin, URL&& url = URL(), const TextPosition& startPosition = TextPosition(), SourceProviderSourceType sourceType = SourceProviderSourceType::Program) > { >- return SourceCode(StringSourceProvider::create(source, sourceOrigin, url, startPosition, sourceType), startPosition.m_line.oneBasedInt(), startPosition.m_column.oneBasedInt()); >+ return SourceCode(StringSourceProvider::create(source, sourceOrigin, WTFMove(url), startPosition, sourceType), startPosition.m_line.oneBasedInt(), startPosition.m_column.oneBasedInt()); > } > > inline SourceCode SourceCode::subExpression(unsigned openBrace, unsigned closeBrace, int firstLine, int startColumn) const >diff --git a/Source/JavaScriptCore/parser/SourceProvider.cpp b/Source/JavaScriptCore/parser/SourceProvider.cpp >index 5f97aa4d9fa24147379542483bfc227362de3c55..5c198fdb13ad8b7953e5b6dd06dd7cda7e01cc58 100644 >--- a/Source/JavaScriptCore/parser/SourceProvider.cpp >+++ b/Source/JavaScriptCore/parser/SourceProvider.cpp >@@ -31,11 +31,11 @@ > > namespace JSC { > >-SourceProvider::SourceProvider(const SourceOrigin& sourceOrigin, const String& url, const TextPosition& startPosition, SourceProviderSourceType sourceType) >- : m_sourceType(sourceType) >+SourceProvider::SourceProvider(const SourceOrigin& sourceOrigin, URL&& url, const TextPosition& startPosition, SourceProviderSourceType sourceType) >+ : m_url(WTFMove(url)) >+ , m_sourceType(sourceType) > , m_validated(false) > , m_sourceOrigin(sourceOrigin) >- , m_url(url) > , m_startPosition(startPosition) > { > } >diff --git a/Source/JavaScriptCore/parser/SourceProvider.h b/Source/JavaScriptCore/parser/SourceProvider.h >index 04f26735bf0e4277074a7017214e051626f8a51a..40c7aa7ed16cfab667fa40613dc029f6b4198b35 100644 >--- a/Source/JavaScriptCore/parser/SourceProvider.h >+++ b/Source/JavaScriptCore/parser/SourceProvider.h >@@ -30,6 +30,7 @@ > > #include "SourceOrigin.h" > #include <wtf/RefCounted.h> >+#include <wtf/URL.h> > #include <wtf/text/TextPosition.h> > #include <wtf/text/WTFString.h> > >@@ -45,7 +46,7 @@ namespace JSC { > public: > static const intptr_t nullID = 1; > >- JS_EXPORT_PRIVATE SourceProvider(const SourceOrigin&, const String& url, const TextPosition& startPosition, SourceProviderSourceType); >+ JS_EXPORT_PRIVATE SourceProvider(const SourceOrigin&, URL&&, const TextPosition& startPosition, SourceProviderSourceType); > > JS_EXPORT_PRIVATE virtual ~SourceProvider(); > >@@ -57,7 +58,7 @@ namespace JSC { > } > > const SourceOrigin& sourceOrigin() const { return m_sourceOrigin; } >- const String& url() const { return m_url; } >+ const URL& url() const { return m_url; } > const String& sourceURL() const { return m_sourceURLDirective; } > const String& sourceMappingURL() const { return m_sourceMappingURLDirective; } > >@@ -80,10 +81,10 @@ namespace JSC { > private: > JS_EXPORT_PRIVATE void getID(); > >+ URL m_url; > SourceProviderSourceType m_sourceType; > bool m_validated : 1; > SourceOrigin m_sourceOrigin; >- String m_url; > String m_sourceURLDirective; > String m_sourceMappingURLDirective; > TextPosition m_startPosition; >@@ -92,9 +93,9 @@ namespace JSC { > > class StringSourceProvider : public SourceProvider { > public: >- static Ref<StringSourceProvider> create(const String& source, const SourceOrigin& sourceOrigin, const String& url, const TextPosition& startPosition = TextPosition(), SourceProviderSourceType sourceType = SourceProviderSourceType::Program) >+ static Ref<StringSourceProvider> create(const String& source, const SourceOrigin& sourceOrigin, URL&& url, const TextPosition& startPosition = TextPosition(), SourceProviderSourceType sourceType = SourceProviderSourceType::Program) > { >- return adoptRef(*new StringSourceProvider(source, sourceOrigin, url, startPosition, sourceType)); >+ return adoptRef(*new StringSourceProvider(source, sourceOrigin, WTFMove(url), startPosition, sourceType)); > } > > unsigned hash() const override >@@ -108,8 +109,8 @@ namespace JSC { > } > > private: >- StringSourceProvider(const String& source, const SourceOrigin& sourceOrigin, const String& url, const TextPosition& startPosition, SourceProviderSourceType sourceType) >- : SourceProvider(sourceOrigin, url, startPosition, sourceType) >+ StringSourceProvider(const String& source, const SourceOrigin& sourceOrigin, URL&& url, const TextPosition& startPosition, SourceProviderSourceType sourceType) >+ : SourceProvider(sourceOrigin, WTFMove(url), startPosition, sourceType) > , m_source(source.isNull() ? *StringImpl::empty() : *source.impl()) > { > } >@@ -120,9 +121,9 @@ namespace JSC { > #if ENABLE(WEBASSEMBLY) > class WebAssemblySourceProvider : public SourceProvider { > public: >- static Ref<WebAssemblySourceProvider> create(Vector<uint8_t>&& data, const SourceOrigin& sourceOrigin, const String& url) >+ static Ref<WebAssemblySourceProvider> create(Vector<uint8_t>&& data, const SourceOrigin& sourceOrigin, URL&& url) > { >- return adoptRef(*new WebAssemblySourceProvider(WTFMove(data), sourceOrigin, url)); >+ return adoptRef(*new WebAssemblySourceProvider(WTFMove(data), sourceOrigin, WTFMove(url))); > } > > unsigned hash() const override >@@ -141,8 +142,8 @@ namespace JSC { > } > > private: >- WebAssemblySourceProvider(Vector<uint8_t>&& data, const SourceOrigin& sourceOrigin, const String& url) >- : SourceProvider(sourceOrigin, url, TextPosition(), SourceProviderSourceType::WebAssembly) >+ WebAssemblySourceProvider(Vector<uint8_t>&& data, const SourceOrigin& sourceOrigin, URL&& url) >+ : SourceProvider(sourceOrigin, WTFMove(url), TextPosition(), SourceProviderSourceType::WebAssembly) > , m_source("[WebAssembly source]") > , m_data(WTFMove(data)) > { >diff --git a/Source/JavaScriptCore/runtime/FunctionConstructor.cpp b/Source/JavaScriptCore/runtime/FunctionConstructor.cpp >index 168774964d2107e45e6c974abba32231acbf9ac5..c84c972dceaf80993446acba2f0cb3d4da5dca1f 100644 >--- a/Source/JavaScriptCore/runtime/FunctionConstructor.cpp >+++ b/Source/JavaScriptCore/runtime/FunctionConstructor.cpp >@@ -142,7 +142,7 @@ JSObject* constructFunctionSkippingEvalEnabledCheck( > program = builder.toString(); > } > >- SourceCode source = makeSource(program, sourceOrigin, sourceURL, position); >+ SourceCode source = makeSource(program, sourceOrigin, URL({ }, sourceURL), position); > JSObject* exception = nullptr; > FunctionExecutable* function = FunctionExecutable::fromGlobalCode(functionName, *exec, source, exception, overrideLineNumber, functionConstructorParametersEndPosition); > if (!function) { >diff --git a/Source/JavaScriptCore/tools/CodeProfile.h b/Source/JavaScriptCore/tools/CodeProfile.h >index 4fa357d507d969f44755b8c1ae1a975879294af1..3dd0ddce5269e6ed0106a6bc48d0f2d4c90af58a 100644 >--- a/Source/JavaScriptCore/tools/CodeProfile.h >+++ b/Source/JavaScriptCore/tools/CodeProfile.h >@@ -35,7 +35,7 @@ class CodeProfile { > WTF_MAKE_FAST_ALLOCATED; > public: > CodeProfile(const SourceCode& source, CodeProfile* parent) >- : m_file(source.provider()->url().utf8()) >+ : m_file(String(source.provider()->url()).utf8()) > , m_lineNumber(source.firstLine().oneBasedInt()) > , m_parent(parent) > { >diff --git a/Source/JavaScriptCore/tools/FunctionOverrides.cpp b/Source/JavaScriptCore/tools/FunctionOverrides.cpp >index e83b6ee8a96ff2e936355fd191fbf8f16db66131..75e0999d26f80be397ca102dce329b6d13b83893 100644 >--- a/Source/JavaScriptCore/tools/FunctionOverrides.cpp >+++ b/Source/JavaScriptCore/tools/FunctionOverrides.cpp >@@ -126,7 +126,7 @@ static void initializeOverrideInfo(const SourceCode& origCode, const String& new > newProviderStr.append(origHeader); > newProviderStr.append(newBody); > >- Ref<SourceProvider> newProvider = StringSourceProvider::create(newProviderStr, SourceOrigin { "<overridden>" }, "<overridden>"); >+ Ref<SourceProvider> newProvider = StringSourceProvider::create(newProviderStr, SourceOrigin { "<overridden>" }, URL({ }, "<overridden>")); > > info.firstLine = 1; > info.lineCount = 1; // Faking it. This doesn't really matter for now. >diff --git a/Source/WebCore/bindings/js/CachedScriptSourceProvider.h b/Source/WebCore/bindings/js/CachedScriptSourceProvider.h >index 763a0e2328b33afe6d9c12b0ed729dd48425490e..ae444c64536b235ca165746d940a170bc91caeab 100644 >--- a/Source/WebCore/bindings/js/CachedScriptSourceProvider.h >+++ b/Source/WebCore/bindings/js/CachedScriptSourceProvider.h >@@ -1,5 +1,5 @@ > /* >- * Copyright (C) 2008 Apple Inc. All rights reserved. >+ * Copyright (C) 2008-2018 Apple Inc. All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > * modification, are permitted provided that the following conditions >@@ -48,7 +48,7 @@ public: > > private: > CachedScriptSourceProvider(CachedScript* cachedScript, JSC::SourceProviderSourceType sourceType, Ref<CachedScriptFetcher>&& scriptFetcher) >- : SourceProvider(JSC::SourceOrigin { cachedScript->response().url(), WTFMove(scriptFetcher) }, cachedScript->response().url(), TextPosition(), sourceType) >+ : SourceProvider(JSC::SourceOrigin { cachedScript->response().url(), WTFMove(scriptFetcher) }, URL(cachedScript->response().url()), TextPosition(), sourceType) > , m_cachedScript(cachedScript) > { > m_cachedScript->addClient(*this); >diff --git a/Source/WebCore/bindings/js/ScheduledAction.cpp b/Source/WebCore/bindings/js/ScheduledAction.cpp >index 0343df82eefd447a1830ddb2039a220dc47bc79d..cc999daeb27df062578e1828a61f400439e8a2ee 100644 >--- a/Source/WebCore/bindings/js/ScheduledAction.cpp >+++ b/Source/WebCore/bindings/js/ScheduledAction.cpp >@@ -150,7 +150,7 @@ void ScheduledAction::execute(WorkerGlobalScope& workerGlobalScope) > JSWorkerGlobalScope* contextWrapper = scriptController->workerGlobalScopeWrapper(); > executeFunctionInContext(contextWrapper, contextWrapper, workerGlobalScope); > } else { >- ScriptSourceCode code(m_code, workerGlobalScope.url()); >+ ScriptSourceCode code(m_code, URL(workerGlobalScope.url())); > scriptController->evaluate(code); > } > } >diff --git a/Source/WebCore/bindings/js/ScriptController.cpp b/Source/WebCore/bindings/js/ScriptController.cpp >index 280b7e53835cea42c7dea66dd9ae6b64b405c1c8..785c66ec47a27a313b8cb0e4f2df836634dbe255 100644 >--- a/Source/WebCore/bindings/js/ScriptController.cpp >+++ b/Source/WebCore/bindings/js/ScriptController.cpp >@@ -543,7 +543,7 @@ void ScriptController::clearScriptObjects() > JSValue ScriptController::executeScriptInWorld(DOMWrapperWorld& world, const String& script, bool forceUserGesture, ExceptionDetails* exceptionDetails) > { > UserGestureIndicator gestureIndicator(forceUserGesture ? Optional<ProcessingUserGestureState>(ProcessingUserGesture) : WTF::nullopt); >- ScriptSourceCode sourceCode(script, m_frame.document()->url(), TextPosition(), JSC::SourceProviderSourceType::Program, CachedScriptFetcher::create(m_frame.document()->charset())); >+ ScriptSourceCode sourceCode(script, URL(m_frame.document()->url()), TextPosition(), JSC::SourceProviderSourceType::Program, CachedScriptFetcher::create(m_frame.document()->charset())); > > if (!canExecuteScripts(AboutToExecuteScript) || isPaused()) > return { }; >@@ -572,7 +572,7 @@ bool ScriptController::canExecuteScripts(ReasonForCallingCanExecuteScripts reaso > JSValue ScriptController::executeScript(const String& script, bool forceUserGesture, ExceptionDetails* exceptionDetails) > { > UserGestureIndicator gestureIndicator(forceUserGesture ? Optional<ProcessingUserGestureState>(ProcessingUserGesture) : WTF::nullopt); >- return executeScript(ScriptSourceCode(script, m_frame.document()->url(), TextPosition(), JSC::SourceProviderSourceType::Program, CachedScriptFetcher::create(m_frame.document()->charset())), exceptionDetails); >+ return executeScript(ScriptSourceCode(script, URL(m_frame.document()->url()), TextPosition(), JSC::SourceProviderSourceType::Program, CachedScriptFetcher::create(m_frame.document()->charset())), exceptionDetails); > } > > JSValue ScriptController::executeScript(const ScriptSourceCode& sourceCode, ExceptionDetails* exceptionDetails) >diff --git a/Source/WebCore/bindings/js/ScriptSourceCode.h b/Source/WebCore/bindings/js/ScriptSourceCode.h >index b7d7eb93cbacb74a81c007e5ef0981225bc9a97a..286a344f22e99bf83e59b97aea2d0f42b7a51273 100644 >--- a/Source/WebCore/bindings/js/ScriptSourceCode.h >+++ b/Source/WebCore/bindings/js/ScriptSourceCode.h >@@ -44,10 +44,9 @@ namespace WebCore { > > class ScriptSourceCode { > public: >- ScriptSourceCode(const String& source, const URL& url = URL(), const TextPosition& startPosition = TextPosition(), JSC::SourceProviderSourceType sourceType = JSC::SourceProviderSourceType::Program) >- : m_provider(JSC::StringSourceProvider::create(source, JSC::SourceOrigin { url.string() }, url.string(), startPosition, sourceType)) >+ ScriptSourceCode(const String& source, URL&& url = URL(), const TextPosition& startPosition = TextPosition(), JSC::SourceProviderSourceType sourceType = JSC::SourceProviderSourceType::Program) >+ : m_provider(JSC::StringSourceProvider::create(source, JSC::SourceOrigin { url.string() }, WTFMove(url), startPosition, sourceType)) > , m_code(m_provider.copyRef(), startPosition.m_line.oneBasedInt(), startPosition.m_column.oneBasedInt()) >- , m_url(url) > { > } > >@@ -58,10 +57,9 @@ public: > { > } > >- ScriptSourceCode(const String& source, const URL& url, const TextPosition& startPosition, JSC::SourceProviderSourceType sourceType, Ref<CachedScriptFetcher>&& scriptFetcher) >- : m_provider(JSC::StringSourceProvider::create(source, JSC::SourceOrigin { url.string(), WTFMove(scriptFetcher) }, url.string(), startPosition, sourceType)) >+ ScriptSourceCode(const String& source, URL&& url, const TextPosition& startPosition, JSC::SourceProviderSourceType sourceType, Ref<CachedScriptFetcher>&& scriptFetcher) >+ : m_provider(JSC::StringSourceProvider::create(source, JSC::SourceOrigin { url.string(), WTFMove(scriptFetcher) }, WTFMove(url), startPosition, sourceType)) > , m_code(m_provider.copyRef(), startPosition.m_line.oneBasedInt(), startPosition.m_column.oneBasedInt()) >- , m_url(url) > { > } > >@@ -75,13 +73,12 @@ public: > > CachedScript* cachedScript() const { return m_cachedScript.get(); } > >- const URL& url() const { return m_url; } >+ const URL& url() const { return m_provider->url(); } > > private: > Ref<JSC::SourceProvider> m_provider; > JSC::SourceCode m_code; > CachedResourceHandle<CachedScript> m_cachedScript; >- URL m_url; > }; > > } // namespace WebCore >diff --git a/Source/WebCore/dom/ScriptElement.cpp b/Source/WebCore/dom/ScriptElement.cpp >index 6a3fed430b317ea0586845b0c411e697e3ea6dec..0b7db0b7238c32afe3ca4b6fb28726be69b5b74f 100644 >--- a/Source/WebCore/dom/ScriptElement.cpp >+++ b/Source/WebCore/dom/ScriptElement.cpp >@@ -264,7 +264,7 @@ bool ScriptElement::prepareScript(const TextPosition& scriptStartPosition, Legac > } else { > ASSERT(scriptType == ScriptType::Classic); > TextPosition position = document.isInDocumentWrite() ? TextPosition() : scriptStartPosition; >- executeClassicScript(ScriptSourceCode(scriptContent(), document.url(), position, JSC::SourceProviderSourceType::Program, InlineClassicScript::create(*this))); >+ executeClassicScript(ScriptSourceCode(scriptContent(), URL(document.url()), position, JSC::SourceProviderSourceType::Program, InlineClassicScript::create(*this))); > } > > return true; >@@ -347,7 +347,7 @@ bool ScriptElement::requestModuleScript(const TextPosition& scriptStartPosition) > auto script = LoadableModuleScript::create(nonce, emptyString(), crossOriginMode, scriptCharset(), m_element.localName(), m_element.isInUserAgentShadowTree()); > > TextPosition position = m_element.document().isInDocumentWrite() ? TextPosition() : scriptStartPosition; >- ScriptSourceCode sourceCode(scriptContent(), m_element.document().url(), position, JSC::SourceProviderSourceType::Module, script.copyRef()); >+ ScriptSourceCode sourceCode(scriptContent(), URL(m_element.document().url()), position, JSC::SourceProviderSourceType::Module, script.copyRef()); > > ASSERT(m_element.document().contentSecurityPolicy()); > const auto& contentSecurityPolicy = *m_element.document().contentSecurityPolicy(); >@@ -435,7 +435,7 @@ void ScriptElement::executePendingScript(PendingScript& pendingScript) > else { > ASSERT(!pendingScript.error()); > ASSERT_WITH_MESSAGE(scriptType() == ScriptType::Classic, "Module script always have a loadableScript pointer."); >- executeClassicScript(ScriptSourceCode(scriptContent(), m_element.document().url(), pendingScript.startingPosition(), JSC::SourceProviderSourceType::Program, InlineClassicScript::create(*this))); >+ executeClassicScript(ScriptSourceCode(scriptContent(), URL(m_element.document().url()), pendingScript.startingPosition(), JSC::SourceProviderSourceType::Program, InlineClassicScript::create(*this))); > dispatchLoadEventRespectingUserGestureIndicator(); > } > } >diff --git a/Source/WebCore/html/HTMLMediaElement.cpp b/Source/WebCore/html/HTMLMediaElement.cpp >index fecfbbca752ebfebe1c68453df5310d526042b9a..9fd9d4f73e285d26150b6cc06e05dd6b0bc38a29 100644 >--- a/Source/WebCore/html/HTMLMediaElement.cpp >+++ b/Source/WebCore/html/HTMLMediaElement.cpp >@@ -7231,7 +7231,7 @@ bool HTMLMediaElement::ensureMediaControlsInjectedScript() > #else > URL scriptURL; > #endif >- scriptController.evaluateInWorld(ScriptSourceCode(mediaControlsScript, scriptURL), world); >+ scriptController.evaluateInWorld(ScriptSourceCode(mediaControlsScript, WTFMove(scriptURL)), world); > if (UNLIKELY(scope.exception())) { > scope.clearException(); > return false; >diff --git a/Source/WebCore/page/Frame.cpp b/Source/WebCore/page/Frame.cpp >index 25d3e55ac2eed0976bfdd461a36bbc4355528050..73bafdb46602785ff41415fe2699a0ab710a19ca 100644 >--- a/Source/WebCore/page/Frame.cpp >+++ b/Source/WebCore/page/Frame.cpp >@@ -738,7 +738,7 @@ void Frame::injectUserScriptImmediately(DOMWrapperWorld& world, const UserScript > > document->topDocument().setAsRunningUserScripts(); > loader().client().willInjectUserScript(world); >- m_script->evaluateInWorld(ScriptSourceCode(script.source(), script.url()), world); >+ m_script->evaluateInWorld(ScriptSourceCode(script.source(), URL(script.url())), world); > } > > RenderView* Frame::contentRenderer() const >diff --git a/Source/WebCore/workers/WorkerGlobalScope.cpp b/Source/WebCore/workers/WorkerGlobalScope.cpp >index 0e2a5091255c6d67ec88a2f657d439edb4d2b3e0..345c0e4edab7632a20a85f17bd8704b166478d09 100644 >--- a/Source/WebCore/workers/WorkerGlobalScope.cpp >+++ b/Source/WebCore/workers/WorkerGlobalScope.cpp >@@ -312,7 +312,7 @@ ExceptionOr<void> WorkerGlobalScope::importScripts(const Vector<String>& urls) > InspectorInstrumentation::scriptImported(*this, scriptLoader->identifier(), scriptLoader->script()); > > NakedPtr<JSC::Exception> exception; >- m_script->evaluate(ScriptSourceCode(scriptLoader->script(), scriptLoader->responseURL()), exception); >+ m_script->evaluate(ScriptSourceCode(scriptLoader->script(), URL(scriptLoader->responseURL())), exception); > if (exception) { > m_script->setException(exception); > return { }; >diff --git a/Source/WebCore/workers/WorkerThread.cpp b/Source/WebCore/workers/WorkerThread.cpp >index 9795543e1bfe588049f36c1f95712a1f02c36bc5..eb5631c3918008fa25658698828886cfc8369e36 100644 >--- a/Source/WebCore/workers/WorkerThread.cpp >+++ b/Source/WebCore/workers/WorkerThread.cpp >@@ -190,7 +190,7 @@ void WorkerThread::workerThread() > } > > String exceptionMessage; >- scriptController->evaluate(ScriptSourceCode(m_startupData->m_sourceCode, m_startupData->m_scriptURL), &exceptionMessage); >+ scriptController->evaluate(ScriptSourceCode(m_startupData->m_sourceCode, URL(m_startupData->m_scriptURL)), &exceptionMessage); > > callOnMainThread([evaluateCallback = WTFMove(m_evaluateCallback), message = exceptionMessage.isolatedCopy()] { > if (evaluateCallback) >diff --git a/Source/WebCore/worklets/WorkletGlobalScope.cpp b/Source/WebCore/worklets/WorkletGlobalScope.cpp >index 7234031570fe305e8e934c75a57d66d487e28853..f36a10f1d540eb1e37df5526c275976231dcf909 100644 >--- a/Source/WebCore/worklets/WorkletGlobalScope.cpp >+++ b/Source/WebCore/worklets/WorkletGlobalScope.cpp >@@ -61,7 +61,7 @@ WorkletGlobalScope::WorkletGlobalScope(Document& document, ScriptSourceCode&& co > ASSERT(document.page()); > > setSecurityOriginPolicy(SecurityOriginPolicy::create(m_topOrigin.copyRef())); >- setContentSecurityPolicy(std::make_unique<ContentSecurityPolicy>(URL { code.url() }, *this)); >+ setContentSecurityPolicy(std::make_unique<ContentSecurityPolicy>(URL { m_code.url() }, *this)); > } > > WorkletGlobalScope::~WorkletGlobalScope() >diff --git a/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp b/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp >index e71478609676350616ba872880a29f138661ac5b..ba67b75df427f30d0b71bd8074d3e4f4ab1f5501 100644 >--- a/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp >+++ b/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp >@@ -877,7 +877,7 @@ void XMLDocumentParser::endElementNs() > // the libxml2 and Qt XMLDocumentParser implementations. > > if (scriptElement.readyToBeParserExecuted()) >- scriptElement.executeClassicScript(ScriptSourceCode(scriptElement.scriptContent(), document()->url(), m_scriptStartPosition, JSC::SourceProviderSourceType::Program, InlineClassicScript::create(scriptElement))); >+ scriptElement.executeClassicScript(ScriptSourceCode(scriptElement.scriptContent(), URL(document()->url()), m_scriptStartPosition, JSC::SourceProviderSourceType::Program, InlineClassicScript::create(scriptElement))); > else if (scriptElement.willBeParserExecuted() && scriptElement.loadableScript()) { > m_pendingScript = PendingScript::create(scriptElement, *scriptElement.loadableScript()); > m_pendingScript->setClient(*this); >diff --git a/JSTests/ChakraCore/test/Basics/bug650104.baseline-jsc b/JSTests/ChakraCore/test/Basics/bug650104.baseline-jsc >index 25c5c870feb1ba9c01b78b17a64cb8d90330617a..dcac4eb854ecf0796184475a8dad4c377171f960 100644 >--- a/JSTests/ChakraCore/test/Basics/bug650104.baseline-jsc >+++ b/JSTests/ChakraCore/test/Basics/bug650104.baseline-jsc >@@ -1,4 +1,4 @@ > name: push -2885562136746910000number > undefined > Exception: TypeError: Number().push is not a function. (In 'Number().push()', 'Number().push' is undefined) >-global code@bug650104.js:18:14 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Basics/bug650104.js:18:14 >diff --git a/JSTests/ChakraCore/test/Error/NativeErrors_v4.baseline-jsc b/JSTests/ChakraCore/test/Error/NativeErrors_v4.baseline-jsc >index afed372a0a17b32f2202ec7bf047e0a41606129a..6e3a9295ec35222f3c8e8533d0b25713e86b8b75 100644 >--- a/JSTests/ChakraCore/test/Error/NativeErrors_v4.baseline-jsc >+++ b/JSTests/ChakraCore/test/Error/NativeErrors_v4.baseline-jsc >@@ -5,8 +5,8 @@ line = (number) 1 > number = (undefined)undefined > stack = (string) eval code > eval@[native code] >-Test@NativeErrors.js:49:20 >-global code@NativeErrors.js:68:5 >+Test@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:49:20 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:68:5 > toString() = EvalError > > RangeError('This is a range error') >@@ -16,8 +16,8 @@ line = (number) 1 > number = (undefined)undefined > stack = (string) eval code > eval@[native code] >-Test@NativeErrors.js:49:20 >-global code@NativeErrors.js:69:5 >+Test@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:49:20 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:69:5 > toString() = RangeError: This is a range error > > ReferenceError >@@ -27,8 +27,8 @@ line = (number) 1 > number = (undefined)undefined > stack = (string) eval code > eval@[native code] >-Test@NativeErrors.js:49:20 >-global code@NativeErrors.js:70:5 >+Test@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:49:20 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:70:5 > toString() = ReferenceError > > SyntaxError >@@ -38,8 +38,8 @@ line = (number) 1 > number = (undefined)undefined > stack = (string) eval code > eval@[native code] >-Test@NativeErrors.js:49:20 >-global code@NativeErrors.js:71:5 >+Test@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:49:20 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:71:5 > toString() = SyntaxError > > TypeError('This is a type error') >@@ -49,8 +49,8 @@ line = (number) 1 > number = (undefined)undefined > stack = (string) eval code > eval@[native code] >-Test@NativeErrors.js:49:20 >-global code@NativeErrors.js:72:5 >+Test@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:49:20 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:72:5 > toString() = TypeError: This is a type error > > URIError >@@ -60,8 +60,8 @@ line = (number) 1 > number = (undefined)undefined > stack = (string) eval code > eval@[native code] >-Test@NativeErrors.js:49:20 >-global code@NativeErrors.js:73:5 >+Test@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:49:20 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/NativeErrors.js:73:5 > toString() = URIError > > RegExpError >diff --git a/JSTests/ChakraCore/test/Error/inlineSameFunc.baseline-jsc b/JSTests/ChakraCore/test/Error/inlineSameFunc.baseline-jsc >index 18f65a7df917b1dc55ffcba66d48d9e3ff8beb1a..12c420f9ad293e3e00104c28600ddd5856a886d1 100644 >--- a/JSTests/ChakraCore/test/Error/inlineSameFunc.baseline-jsc >+++ b/JSTests/ChakraCore/test/Error/inlineSameFunc.baseline-jsc >@@ -1,4 +1,4 @@ >-f@inlineSameFunc.js:11:16 >-f@inlineSameFunc.js:13:6 >-f@inlineSameFunc.js:13:6 >-global code@inlineSameFunc.js:19:5 >+f@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/inlineSameFunc.js:11:16 >+f@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/inlineSameFunc.js:13:6 >+f@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/inlineSameFunc.js:13:6 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/inlineSameFunc.js:19:5 >diff --git a/JSTests/ChakraCore/test/Error/validate_line_column.baseline-jsc b/JSTests/ChakraCore/test/Error/validate_line_column.baseline-jsc >index 6324ea20383cc4e07d3b1d9e516d45c3fc599191..6a5ce2e18abe6dd22a81e3ee0e60ca7045619fc4 100644 >--- a/JSTests/ChakraCore/test/Error/validate_line_column.baseline-jsc >+++ b/JSTests/ChakraCore/test/Error/validate_line_column.baseline-jsc >@@ -1,30 +1,30 @@ >-validate_line_column.js:17:9 >-foo@validate_line_column.js:10:17 >-global code@validate_line_column.js:16:4 >-validate_line_column.js:21:11 >-foo@validate_line_column.js:10:17 >-global code@validate_line_column.js:20:4 >-validate_line_column.js:26:7 >-foo@validate_line_column.js:10:17 >-global code@validate_line_column.js:24:4 >-validate_line_column.js:30:14 >-foo@validate_line_column.js:10:17 >-global code@validate_line_column.js:29:4 >-validate_line_column.js:35:7 >-foo@validate_line_column.js:10:17 >-global code@validate_line_column.js:33:4 >-validate_line_column.js:40:7 >-foo@validate_line_column.js:10:17 >-global code@validate_line_column.js:38:4 >-validate_line_column.js:45:7 >-foo@validate_line_column.js:10:17 >-global code@validate_line_column.js:43:4 >-validate_line_column.js:50:7 >-foo@validate_line_column.js:10:17 >-global code@validate_line_column.js:48:4 >-validate_line_column.js:55:7 >-foo@validate_line_column.js:10:17 >-global code@validate_line_column.js:53:4 >-validate_line_column.js:60:9 >-foo@validate_line_column.js:10:17 >-global code@validate_line_column.js:58:4 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:17:9 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:10:17 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:16:4 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:21:11 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:10:17 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:20:4 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:26:7 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:10:17 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:24:4 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:30:14 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:10:17 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:29:4 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:35:7 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:10:17 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:33:4 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:40:7 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:10:17 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:38:4 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:45:7 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:10:17 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:43:4 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:50:7 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:10:17 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:48:4 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:55:7 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:10:17 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:53:4 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:60:9 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:10:17 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Error/validate_line_column.js:58:4 >diff --git a/JSTests/ChakraCore/test/Function/deferredBadContinue.baseline-jsc b/JSTests/ChakraCore/test/Function/deferredBadContinue.baseline-jsc >index 591d7ffc1ea3a1e7cf3e3dc205d52f33213b78c0..9b92cf4776b913f81adecd8d98e14ea1c6d38b5b 100644 >--- a/JSTests/ChakraCore/test/Function/deferredBadContinue.baseline-jsc >+++ b/JSTests/ChakraCore/test/Function/deferredBadContinue.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Cannot continue to the label 'LABEL1' as it is not targeting a loop. >-at deferredBadContinue.js:14 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Function/deferredBadContinue.js:14 >diff --git a/JSTests/ChakraCore/test/LetConst/defer1.baseline-jsc b/JSTests/ChakraCore/test/LetConst/defer1.baseline-jsc >index 61570dbd42e589b3bb7f8fd72dc6e25a44d2a5ac..37de47bd81070b7271c0691ae382cbe32f4341e9 100644 >--- a/JSTests/ChakraCore/test/LetConst/defer1.baseline-jsc >+++ b/JSTests/ChakraCore/test/LetConst/defer1.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Cannot declare a let variable twice: 'x'. >-at defer1.js:6 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/LetConst/defer1.js:6 >diff --git a/JSTests/ChakraCore/test/LetConst/defer2.baseline-jsc b/JSTests/ChakraCore/test/LetConst/defer2.baseline-jsc >index 346454407749278c9515a26a734046f569df56cd..a01c789f4c9d96fe4090798c469e6308f39f4f0c 100644 >--- a/JSTests/ChakraCore/test/LetConst/defer2.baseline-jsc >+++ b/JSTests/ChakraCore/test/LetConst/defer2.baseline-jsc >@@ -1,4 +1,4 @@ > Exception: TypeError: Attempted to assign to readonly property. >-g@defer2.js:7:15 >-f@defer2.js:11:6 >-global code@defer2.js:13:2 >+g@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/LetConst/defer2.js:7:15 >+f@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/LetConst/defer2.js:11:6 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/LetConst/defer2.js:13:2 >diff --git a/JSTests/ChakraCore/test/LetConst/defer5.baseline-jsc b/JSTests/ChakraCore/test/LetConst/defer5.baseline-jsc >index 5cc0182c4dcea350d0298fd80b837260897002f7..66f2ddb13996113086914e4a698c907b429e806a 100644 >--- a/JSTests/ChakraCore/test/LetConst/defer5.baseline-jsc >+++ b/JSTests/ChakraCore/test/LetConst/defer5.baseline-jsc >@@ -1,4 +1,4 @@ > Exception: ReferenceError: Cannot access uninitialized variable. >-foo@defer5.js:11:12 >-test@defer5.js:14:8 >-global code@defer5.js:18:5 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/LetConst/defer5.js:11:12 >+test@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/LetConst/defer5.js:14:8 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/LetConst/defer5.js:18:5 >diff --git a/JSTests/ChakraCore/test/Object/forIn.error.baseline-jsc b/JSTests/ChakraCore/test/Object/forIn.error.baseline-jsc >index 11561f2167a8632bdb06754e7750eb1ebf877b56..49eb7acd62d406d68ff70cacedf913ea69df66e1 100644 >--- a/JSTests/ChakraCore/test/Object/forIn.error.baseline-jsc >+++ b/JSTests/ChakraCore/test/Object/forIn.error.baseline-jsc >@@ -1,2 +1,2 @@ >-foo@forIn.error.js:10:20 >-global code@forIn.error.js:18:6 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Object/forIn.error.js:10:20 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/Object/forIn.error.js:18:6 >diff --git a/JSTests/ChakraCore/test/StackTrace/ErrorPrototype.baseline-jsc b/JSTests/ChakraCore/test/StackTrace/ErrorPrototype.baseline-jsc >index f891828417b1495030778783a7d6a8e547979177..a42e818485699bbd32515717259a58546d18a925 100644 >--- a/JSTests/ChakraCore/test/StackTrace/ErrorPrototype.baseline-jsc >+++ b/JSTests/ChakraCore/test/StackTrace/ErrorPrototype.baseline-jsc >@@ -1,10 +1,10 @@ > Prototype is new Error() >-runtest@ErrorPrototype.js:46:38 >-global code@ErrorPrototype.js:62:8 >+runtest@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/ErrorPrototype.js:46:38 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/ErrorPrototype.js:62:8 > > Prototype has new Error() >-runtest@ErrorPrototype.js:46:38 >-global code@ErrorPrototype.js:62:8 >+runtest@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/ErrorPrototype.js:46:38 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/ErrorPrototype.js:62:8 > > Prototype is Error.prototype > undefined >@@ -13,12 +13,12 @@ Prototype has Error.prototype > undefined > > Prototype is new RangeError() >-runtest@ErrorPrototype.js:48:43 >-global code@ErrorPrototype.js:62:8 >+runtest@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/ErrorPrototype.js:48:43 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/ErrorPrototype.js:62:8 > > Prototype has new RangeError() >-runtest@ErrorPrototype.js:48:43 >-global code@ErrorPrototype.js:62:8 >+runtest@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/ErrorPrototype.js:48:43 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/ErrorPrototype.js:62:8 > > Prototype is RangeError.prototype > undefined >diff --git a/JSTests/ChakraCore/test/StackTrace/FunctionName.js.baseline-jsc b/JSTests/ChakraCore/test/StackTrace/FunctionName.js.baseline-jsc >index 103c3db82eea89bb24dba4593f909943a0db9bdd..a2da798725cd7ff3b14baf528ce898a4387a082e 100644 >--- a/JSTests/ChakraCore/test/StackTrace/FunctionName.js.baseline-jsc >+++ b/JSTests/ChakraCore/test/StackTrace/FunctionName.js.baseline-jsc >@@ -1,8 +1,8 @@ >-foo@FunctionName.js:24:24 >-func@FunctionName.js:28:12 >+foo@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/FunctionName.js:24:24 >+func@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/FunctionName.js:28:12 > anonymous > eval code > eval@[native code] >-FunctionName.js:35:17 >-bar@FunctionName.js:36:11 >-global code@FunctionName.js:39:8 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/FunctionName.js:35:17 >+bar@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/FunctionName.js:36:11 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/StackTrace/FunctionName.js:39:8 >diff --git a/JSTests/ChakraCore/test/es6/globalCatchNewTargetSyntaxError.baseline-jsc b/JSTests/ChakraCore/test/es6/globalCatchNewTargetSyntaxError.baseline-jsc >index 692195c0e925c648850beee0fb65a251efa5357c..e17e36b1cf1bc92ff67afb3c18e9622be93576e7 100644 >--- a/JSTests/ChakraCore/test/es6/globalCatchNewTargetSyntaxError.baseline-jsc >+++ b/JSTests/ChakraCore/test/es6/globalCatchNewTargetSyntaxError.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: new.target is only valid inside functions. >-at globalCatchNewTargetSyntaxError.js:6 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/globalCatchNewTargetSyntaxError.js:6 >diff --git a/JSTests/ChakraCore/test/es6/globalLambdaNewTargetSyntaxError.baseline-jsc b/JSTests/ChakraCore/test/es6/globalLambdaNewTargetSyntaxError.baseline-jsc >index fc03dab5da00ab9b8383d715b9ce788dcff0e36f..a1947a024cee0d24e2c5fda5e1a316c4a1b140dc 100644 >--- a/JSTests/ChakraCore/test/es6/globalLambdaNewTargetSyntaxError.baseline-jsc >+++ b/JSTests/ChakraCore/test/es6/globalLambdaNewTargetSyntaxError.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: new.target is not valid inside arrow functions in global code. >-at globalLambdaNewTargetSyntaxError.js:6 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/globalLambdaNewTargetSyntaxError.js:6 >diff --git a/JSTests/ChakraCore/test/es6/globalNewTargetSyntaxError.baseline-jsc b/JSTests/ChakraCore/test/es6/globalNewTargetSyntaxError.baseline-jsc >index 88e6bc8a8027841f067dd3abcf678d134988df22..68cf26331c58d58177aa76c44285c356df2d3071 100644 >--- a/JSTests/ChakraCore/test/es6/globalNewTargetSyntaxError.baseline-jsc >+++ b/JSTests/ChakraCore/test/es6/globalNewTargetSyntaxError.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: new.target is only valid inside functions. >-at globalNewTargetSyntaxError.js:6 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/globalNewTargetSyntaxError.js:6 >diff --git a/JSTests/ChakraCore/test/es6/globalParamCatchNewTargetSyntaxError.baseline-jsc b/JSTests/ChakraCore/test/es6/globalParamCatchNewTargetSyntaxError.baseline-jsc >index 5393e5d6249d5fe7aadc61eea09c9101c9b1620e..297191132202dfa3ea2091acd52c83f745d4ee14 100644 >--- a/JSTests/ChakraCore/test/es6/globalParamCatchNewTargetSyntaxError.baseline-jsc >+++ b/JSTests/ChakraCore/test/es6/globalParamCatchNewTargetSyntaxError.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Unexpected identifier 'a'. Cannot declare a lexical variable twice: 'a'. >-at globalParamCatchNewTargetSyntaxError.js:7 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/globalParamCatchNewTargetSyntaxError.js:7 >diff --git a/JSTests/ChakraCore/test/es6/supersyntax02.baseline-jsc b/JSTests/ChakraCore/test/es6/supersyntax02.baseline-jsc >index c61f7d2f361d02c966df71eafa8a110159faad5e..ee563c1c7f2361963f1c992bafcb2a9363aa996c 100644 >--- a/JSTests/ChakraCore/test/es6/supersyntax02.baseline-jsc >+++ b/JSTests/ChakraCore/test/es6/supersyntax02.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: super is not valid in this context. >-at supersyntax02.js:7 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/supersyntax02.js:7 >diff --git a/JSTests/ChakraCore/test/es6/supersyntax05.baseline-jsc b/JSTests/ChakraCore/test/es6/supersyntax05.baseline-jsc >index c9ef88ced3e086f87b00e7135ca6959ab7938c76..c68246e669c05663a1e602cbf6aaf1baf6efc893 100644 >--- a/JSTests/ChakraCore/test/es6/supersyntax05.baseline-jsc >+++ b/JSTests/ChakraCore/test/es6/supersyntax05.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: super is not valid in this context. >-at supersyntax05.js:8 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/supersyntax05.js:8 >diff --git a/JSTests/ChakraCore/test/es6/supersyntax06.baseline-jsc b/JSTests/ChakraCore/test/es6/supersyntax06.baseline-jsc >index d0b3671501840f6ac398d07d3147a535e2dddbae..37d283ff3ff8b09fc33ee4bc7b259144848d6f03 100644 >--- a/JSTests/ChakraCore/test/es6/supersyntax06.baseline-jsc >+++ b/JSTests/ChakraCore/test/es6/supersyntax06.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: super is not valid in this context. >-at supersyntax06.js:8 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/supersyntax06.js:8 >diff --git a/JSTests/ChakraCore/test/es6/unicode_6_identifier_Blue511452.baseline-jsc b/JSTests/ChakraCore/test/es6/unicode_6_identifier_Blue511452.baseline-jsc >index 263a039ef707e36691a51449563843fb594b1155..ace696bf67a40378d040ebbe1e82f042a2e9177b 100644 >--- a/JSTests/ChakraCore/test/es6/unicode_6_identifier_Blue511452.baseline-jsc >+++ b/JSTests/ChakraCore/test/es6/unicode_6_identifier_Blue511452.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Invalid escape in identifier: 'a\' >-at unicode_6_identifier_Blue511452.js:7 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/unicode_6_identifier_Blue511452.js:7 >diff --git a/JSTests/ChakraCore/test/es6/unicode_6_identifier_Blue524737.baseline-jsc b/JSTests/ChakraCore/test/es6/unicode_6_identifier_Blue524737.baseline-jsc >index 99d6d8be4f5c2a42b6ca7c243325389dfc621f52..3b887bb09fb9a00735e5ab05d297b78ffd10a2e3 100644 >--- a/JSTests/ChakraCore/test/es6/unicode_6_identifier_Blue524737.baseline-jsc >+++ b/JSTests/ChakraCore/test/es6/unicode_6_identifier_Blue524737.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Invalid unicode escape in identifier: '\u{134071' >-at unicode_6_identifier_Blue524737.js:6 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/unicode_6_identifier_Blue524737.js:6 >diff --git a/JSTests/ChakraCore/test/es6/unicode_blue_533163_utf8.baseline-jsc b/JSTests/ChakraCore/test/es6/unicode_blue_533163_utf8.baseline-jsc >index 2c2954dcfee62c58139746591d6082cd9fc1070d..1e96c890f842ef82109c5ec6519db09e544a3a95 100644 >--- a/JSTests/ChakraCore/test/es6/unicode_blue_533163_utf8.baseline-jsc >+++ b/JSTests/ChakraCore/test/es6/unicode_blue_533163_utf8.baseline-jsc >@@ -1,3 +1,3 @@ > Exception: ReferenceError: Cannot access uninitialized variable. >-testcase@unicode_blue_533163_utf8.js:6:18 >-global code@unicode_blue_533163_utf8.js:11:9 >+testcase@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/unicode_blue_533163_utf8.js:6:18 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/es6/unicode_blue_533163_utf8.js:11:9 >diff --git a/JSTests/ChakraCore/test/fieldopts/fieldhoist6.baseline-jsc b/JSTests/ChakraCore/test/fieldopts/fieldhoist6.baseline-jsc >index 1140b55e6b254afe6caf60d0a7e784830c660b54..0c601cfa86bd9bde4e74da22798f9a2e3b26feeb 100644 >--- a/JSTests/ChakraCore/test/fieldopts/fieldhoist6.baseline-jsc >+++ b/JSTests/ChakraCore/test/fieldopts/fieldhoist6.baseline-jsc >@@ -1,3 +1,3 @@ > Exception: ReferenceError: Can't find variable: f >-fieldhoist6.js:13:6 >-global code@fieldhoist6.js:20:3 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist6.js:13:6 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist6.js:20:3 >diff --git a/JSTests/ChakraCore/test/fieldopts/fieldhoist6b.baseline-jsc b/JSTests/ChakraCore/test/fieldopts/fieldhoist6b.baseline-jsc >index 83dc4a77a67e2f35f81d2d1da6481f223f40def0..9ad9b467d930b1e48ddfe0e1d9b8e7e7b72934aa 100644 >--- a/JSTests/ChakraCore/test/fieldopts/fieldhoist6b.baseline-jsc >+++ b/JSTests/ChakraCore/test/fieldopts/fieldhoist6b.baseline-jsc >@@ -1,3 +1,3 @@ > Exception: ReferenceError: Can't find variable: f >-fieldhoist6b.js:13:6 >-global code@fieldhoist6b.js:20:3 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist6b.js:13:6 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist6b.js:20:3 >diff --git a/JSTests/ChakraCore/test/fieldopts/fieldhoist7.baseline-jsc b/JSTests/ChakraCore/test/fieldopts/fieldhoist7.baseline-jsc >index 18744743074f5c7d335e2902096923c3bd0fe392..9664f6b68ee151b186641f70222463af43db9ff2 100644 >--- a/JSTests/ChakraCore/test/fieldopts/fieldhoist7.baseline-jsc >+++ b/JSTests/ChakraCore/test/fieldopts/fieldhoist7.baseline-jsc >@@ -1,3 +1,3 @@ > Exception: ReferenceError: Can't find variable: obj3 >-fieldhoist7.js:7:32 >-global code@fieldhoist7.js:18:3 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist7.js:7:32 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist7.js:18:3 >diff --git a/JSTests/ChakraCore/test/fieldopts/fieldhoist_negzero.baseline-jsc b/JSTests/ChakraCore/test/fieldopts/fieldhoist_negzero.baseline-jsc >index 235a0d65931e7fd1551cfedd0054d16d1ee0d5ac..c61413eed88f8370c8a3860d1d30d6d68a44c204 100644 >--- a/JSTests/ChakraCore/test/fieldopts/fieldhoist_negzero.baseline-jsc >+++ b/JSTests/ChakraCore/test/fieldopts/fieldhoist_negzero.baseline-jsc >@@ -1,3 +1,3 @@ > Exception: ReferenceError: Can't find variable: obj0 >-fieldhoist_negzero.js:9:32 >-global code@fieldhoist_negzero.js:12:3 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist_negzero.js:9:32 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist_negzero.js:12:3 >diff --git a/JSTests/ChakraCore/test/fieldopts/fieldhoist_nullfieldhoist.baseline-jsc b/JSTests/ChakraCore/test/fieldopts/fieldhoist_nullfieldhoist.baseline-jsc >index 7560d56471a8579f5cc4dc64046c73bafb7ec949..dfe435a644efb6c76ceaff7a02f51378a0663b0a 100644 >--- a/JSTests/ChakraCore/test/fieldopts/fieldhoist_nullfieldhoist.baseline-jsc >+++ b/JSTests/ChakraCore/test/fieldopts/fieldhoist_nullfieldhoist.baseline-jsc >@@ -1,3 +1,3 @@ > Exception: TypeError: undefined is not an object (evaluating 'o.x') >-test_Neg_A@fieldhoist_nullfieldhoist.js:11:14 >-global code@fieldhoist_nullfieldhoist.js:17:11 >+test_Neg_A@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist_nullfieldhoist.js:11:14 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist_nullfieldhoist.js:17:11 >diff --git a/JSTests/ChakraCore/test/fieldopts/fieldhoist_undefined_global.baseline-jsc b/JSTests/ChakraCore/test/fieldopts/fieldhoist_undefined_global.baseline-jsc >index df4fafbb20c8e1a8ef1164225c26a0ff3ac32fed..6ccfd986457ab4ce7f3a8d8a8f3cb20a255d1a5a 100644 >--- a/JSTests/ChakraCore/test/fieldopts/fieldhoist_undefined_global.baseline-jsc >+++ b/JSTests/ChakraCore/test/fieldopts/fieldhoist_undefined_global.baseline-jsc >@@ -1,3 +1,3 @@ > Exception: ReferenceError: Can't find variable: d >-fieldhoist_undefined_global.js:12:10 >-global code@fieldhoist_undefined_global.js:15:3 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist_undefined_global.js:12:10 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist_undefined_global.js:15:3 >diff --git a/JSTests/ChakraCore/test/fieldopts/fieldhoist_unreachable.baseline-jsc b/JSTests/ChakraCore/test/fieldopts/fieldhoist_unreachable.baseline-jsc >index ee8d8c7da58128c3873e1cf8f58092f0ee5fe30c..b067220ab40510268b950fecc054a92a238079b4 100644 >--- a/JSTests/ChakraCore/test/fieldopts/fieldhoist_unreachable.baseline-jsc >+++ b/JSTests/ChakraCore/test/fieldopts/fieldhoist_unreachable.baseline-jsc >@@ -1,3 +1,3 @@ > Exception: ReferenceError: Can't find variable: obj9 >-fieldhoist_unreachable.js:13:9 >-global code@fieldhoist_unreachable.js:15:3 >+file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist_unreachable.js:13:9 >+global code@file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/fieldopts/fieldhoist_unreachable.js:15:3 >diff --git a/JSTests/ChakraCore/test/strict/bug212755.baseline-jsc b/JSTests/ChakraCore/test/strict/bug212755.baseline-jsc >index 496ebf16ebbbdff151a9d31ffb41f503cd64c78c..ec198077d77bd50ea08d54db8ad2546df87238a7 100644 >--- a/JSTests/ChakraCore/test/strict/bug212755.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/bug212755.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: 'with' statements are not valid in strict mode. >-at bug212755.js:21 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/bug212755.js:21 >diff --git a/JSTests/ChakraCore/test/strict/delete.baseline-jsc b/JSTests/ChakraCore/test/strict/delete.baseline-jsc >index 9ab4eb05b813b4434bec204035f045bfe1cc5154..bc053b90953ab395156255882f65ff6eefd0522c 100644 >--- a/JSTests/ChakraCore/test/strict/delete.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/delete.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Cannot delete unqualified property 'a' in strict mode. >-at delete.js:9 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/delete.js:9 >diff --git a/JSTests/ChakraCore/test/strict/formal_samename1.baseline-jsc b/JSTests/ChakraCore/test/strict/formal_samename1.baseline-jsc >index c2feb54573252ecdcf71ac06a481597a6800075e..d4958b537596d4a6451be588667ef6d2504baf29 100644 >--- a/JSTests/ChakraCore/test/strict/formal_samename1.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/formal_samename1.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Cannot declare a parameter named 'x' in strict mode as it has already been declared. >-at formal_samename1.js:9 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/formal_samename1.js:9 >diff --git a/JSTests/ChakraCore/test/strict/formal_samename2.baseline-jsc b/JSTests/ChakraCore/test/strict/formal_samename2.baseline-jsc >index e2467f0d4e6a14f9103ab44d5a6defc08812e60b..843ab7f8bd2a6012f4d9052bf2354c24eb2258da 100644 >--- a/JSTests/ChakraCore/test/strict/formal_samename2.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/formal_samename2.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Invalid parameters or function name in strict mode. >-at formal_samename2.js:8 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/formal_samename2.js:8 >diff --git a/JSTests/ChakraCore/test/strict/multiunit.baseline-jsc b/JSTests/ChakraCore/test/strict/multiunit.baseline-jsc >index 4e0d2318c333e39d45cf60be71c803d249a3dc0c..febd2c7649100804ffb09ea65ec9fe586592554e 100644 >--- a/JSTests/ChakraCore/test/strict/multiunit.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/multiunit.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Cannot declare a parameter named 'a' in strict mode as it has already been declared. >-at multiunit.js:43 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/multiunit.js:43 >diff --git a/JSTests/ChakraCore/test/strict/nonSimpleParameterList.baseline-jsc b/JSTests/ChakraCore/test/strict/nonSimpleParameterList.baseline-jsc >index bb537db446100507bb8001a359f7eab5d2742841..4a4a3b8e12d4708b8cc14d0f7ca673fa35af2b8f 100644 >--- a/JSTests/ChakraCore/test/strict/nonSimpleParameterList.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/nonSimpleParameterList.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: 'use strict' directive not allowed inside a function with a non-simple parameter list. >-at nonSimpleParameterList.js:8 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/nonSimpleParameterList.js:8 >diff --git a/JSTests/ChakraCore/test/strict/strictargs-deferred.baseline-jsc b/JSTests/ChakraCore/test/strict/strictargs-deferred.baseline-jsc >index 1ab5e62811e97c207e10291d42990dd924ec8af1..849223fd50ecc521f6459f78675e0283ee187eb5 100644 >--- a/JSTests/ChakraCore/test/strict/strictargs-deferred.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/strictargs-deferred.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Cannot destructure to a parameter name 'arguments' in strict mode. >-at strictargs-deferred.js:8 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/strictargs-deferred.js:8 >diff --git a/JSTests/ChakraCore/test/strict/strictargs2-deferred.baseline-jsc b/JSTests/ChakraCore/test/strict/strictargs2-deferred.baseline-jsc >index 078216a8c9784d072b7c0c1fe0f32dda8fb6e0d9..802ad1fdc5bc59efa8d33e3dae193a06af907303 100644 >--- a/JSTests/ChakraCore/test/strict/strictargs2-deferred.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/strictargs2-deferred.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Cannot declare a variable named arguments in strict mode. >-at strictargs2-deferred.js:8 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/strictargs2-deferred.js:8 >diff --git a/JSTests/ChakraCore/test/strict/strictargs3-deferred.baseline-jsc b/JSTests/ChakraCore/test/strict/strictargs3-deferred.baseline-jsc >index 081b3ead2dfe647c0bd5f69ef82b59462649cd35..ca69abbd2c90b6e0d807ffb9b2db865d5e38c5e4 100644 >--- a/JSTests/ChakraCore/test/strict/strictargs3-deferred.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/strictargs3-deferred.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: 'arguments' is not a valid function name in strict mode. >-at strictargs3-deferred.js:8 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/strictargs3-deferred.js:8 >diff --git a/JSTests/ChakraCore/test/strict/stricteval-deferred.baseline-jsc b/JSTests/ChakraCore/test/strict/stricteval-deferred.baseline-jsc >index f8c86cf1bf32b7ac3abfc292920fc4d9347fa195..cf3912394ead1ea94a7cc13c1831dc8a2ce385c1 100644 >--- a/JSTests/ChakraCore/test/strict/stricteval-deferred.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/stricteval-deferred.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Cannot destructure to a parameter name 'eval' in strict mode. >-at stricteval-deferred.js:8 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/stricteval-deferred.js:8 >diff --git a/JSTests/ChakraCore/test/strict/stricteval2-deferred.baseline-jsc b/JSTests/ChakraCore/test/strict/stricteval2-deferred.baseline-jsc >index 0a23d8f78e4174b7281775796e03ace4736c95ec..07a246282c47457b98cc64664c87f11baff3c39b 100644 >--- a/JSTests/ChakraCore/test/strict/stricteval2-deferred.baseline-jsc >+++ b/JSTests/ChakraCore/test/strict/stricteval2-deferred.baseline-jsc >@@ -1,2 +1,2 @@ > Exception: SyntaxError: Cannot declare a variable named eval in strict mode. >-at stricteval2-deferred.js:8 >+at file:////Volumes/Data/clean/OpenSource/results/.tests/ChakraCore.yaml/ChakraCore/test/strict/stricteval2-deferred.js:8 >diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog >index 9e350a323faf25b7963d0be326807ff5799ed587..9b124678a1a52a7c6788547a199a86c517fd6cde 100644 >--- a/JSTests/ChangeLog >+++ b/JSTests/ChangeLog >@@ -1,3 +1,50 @@ >+2018-12-28 Keith Miller <keith_miller@apple.com> >+ >+ SourceProviders should use an actual URL instead of a string >+ https://bugs.webkit.org/show_bug.cgi?id=192734 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * ChakraCore/test/Basics/bug650104.baseline-jsc: >+ * ChakraCore/test/Error/NativeErrors_v4.baseline-jsc: >+ * ChakraCore/test/Error/inlineSameFunc.baseline-jsc: >+ * ChakraCore/test/Error/validate_line_column.baseline-jsc: >+ * ChakraCore/test/Function/deferredBadContinue.baseline-jsc: >+ * ChakraCore/test/LetConst/defer1.baseline-jsc: >+ * ChakraCore/test/LetConst/defer2.baseline-jsc: >+ * ChakraCore/test/LetConst/defer5.baseline-jsc: >+ * ChakraCore/test/Object/forIn.error.baseline-jsc: >+ * ChakraCore/test/StackTrace/ErrorPrototype.baseline-jsc: >+ * ChakraCore/test/StackTrace/FunctionName.js.baseline-jsc: >+ * ChakraCore/test/es6/globalCatchNewTargetSyntaxError.baseline-jsc: >+ * ChakraCore/test/es6/globalLambdaNewTargetSyntaxError.baseline-jsc: >+ * ChakraCore/test/es6/globalNewTargetSyntaxError.baseline-jsc: >+ * ChakraCore/test/es6/globalParamCatchNewTargetSyntaxError.baseline-jsc: >+ * ChakraCore/test/es6/supersyntax02.baseline-jsc: >+ * ChakraCore/test/es6/supersyntax05.baseline-jsc: >+ * ChakraCore/test/es6/supersyntax06.baseline-jsc: >+ * ChakraCore/test/es6/unicode_6_identifier_Blue511452.baseline-jsc: >+ * ChakraCore/test/es6/unicode_6_identifier_Blue524737.baseline-jsc: >+ * ChakraCore/test/es6/unicode_blue_533163_utf8.baseline-jsc: >+ * ChakraCore/test/fieldopts/fieldhoist6.baseline-jsc: >+ * ChakraCore/test/fieldopts/fieldhoist6b.baseline-jsc: >+ * ChakraCore/test/fieldopts/fieldhoist7.baseline-jsc: >+ * ChakraCore/test/fieldopts/fieldhoist_negzero.baseline-jsc: >+ * ChakraCore/test/fieldopts/fieldhoist_nullfieldhoist.baseline-jsc: >+ * ChakraCore/test/fieldopts/fieldhoist_undefined_global.baseline-jsc: >+ * ChakraCore/test/fieldopts/fieldhoist_unreachable.baseline-jsc: >+ * ChakraCore/test/strict/bug212755.baseline-jsc: >+ * ChakraCore/test/strict/delete.baseline-jsc: >+ * ChakraCore/test/strict/formal_samename1.baseline-jsc: >+ * ChakraCore/test/strict/formal_samename2.baseline-jsc: >+ * ChakraCore/test/strict/multiunit.baseline-jsc: >+ * ChakraCore/test/strict/nonSimpleParameterList.baseline-jsc: >+ * ChakraCore/test/strict/strictargs-deferred.baseline-jsc: >+ * ChakraCore/test/strict/strictargs2-deferred.baseline-jsc: >+ * ChakraCore/test/strict/strictargs3-deferred.baseline-jsc: >+ * ChakraCore/test/strict/stricteval-deferred.baseline-jsc: >+ * ChakraCore/test/strict/stricteval2-deferred.baseline-jsc: >+ > 2018-12-13 Yusuke Suzuki <yusukesuzuki@slowstart.org> > > [BigInt] Support BigInt in JSON.stringify
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192734
:
357375
|
357381
|
357382
|
357385
|
357386
|
357393
|
357396
|
358029
|
358045
|
358046
|
358047
|
358122
|
358155
|
358156