Attachment 358121 Details for Bug 193049 – Patch

[patch] Patch

bug-193049-20181228130319.patch (text/plain), 19.98 KB, created by Wenson Hsieh on 2018-12-28 13:03:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-12-28 13:03:20 PST

Size: 19.98 KB

patch

obsolete

>Subversion Revision: 239547
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a76adf4267554de6ecda4b8750f6e774b5dd215a..ad03e8b6f5263fb81e57047f4b04163f00919cf8 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,54 @@
>+2018-12-28  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Move WKEditCommandObjC and WKEditorUndoTargetObjC into a separate file
>+        https://bugs.webkit.org/show_bug.cgi?id=193049
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Pull common code (WKEditCommandObjC and WKEditorUndoTargetObjC) on iOS and macOS out into a separate file. No
>+        change in behavior.
>+
>+        * SourcesCocoa.txt:
>+        * UIProcess/Cocoa/WKEditCommand.h: Added.
>+        * UIProcess/Cocoa/WKEditCommand.mm: Added.
>+
>+        Rename WKEditCommandObjC to WKEditCommand, and WKEditorUndoTarget to WKEditorUndoTargetObjC. The ObjC suffix in
>+        the name seems to diverge from the common naming scheme in other parts of WebKit, where most WK- and _WK-
>+        prefixed names already refer to Objective-C objects.
>+
>+        (-[WKEditCommand initWithWebEditCommandProxy:]):
>+
>+        Make the return type instancetype instead of id, and also make this take a Ref<WebEditCommandProxy>&& instead
>+        of a RefPtr.
>+
>+        (-[WKEditCommand command]):
>+        (-[WKEditorUndoTarget undoEditing:]):
>+        (-[WKEditorUndoTarget redoEditing:]):
>+        * UIProcess/Cocoa/WebViewImpl.h:
>+        * UIProcess/Cocoa/WebViewImpl.mm:
>+        (WebKit::WebViewImpl::WebViewImpl):
>+        (WebKit::WebViewImpl::registerEditCommand):
>+
>+        Use WTFMove instead of copying the Ref when creating a WKEditCommand.
>+
>+        (-[WKEditCommandObjC initWithWebEditCommandProxy:]): Deleted.
>+        (-[WKEditCommandObjC command]): Deleted.
>+        (-[WKEditorUndoTargetObjC undoEditing:]): Deleted.
>+        (-[WKEditorUndoTargetObjC redoEditing:]): Deleted.
>+        * UIProcess/ios/PageClientImplIOS.h:
>+        * UIProcess/ios/PageClientImplIOS.mm:
>+        (WebKit::PageClientImpl::PageClientImpl):
>+        (WebKit::PageClientImpl::registerEditCommand):
>+
>+        Use WTFMove instead of creating a new RefPtr when creating a WKEditCommand.
>+
>+        (-[WKEditCommandObjC initWithWebEditCommandProxy:]): Deleted.
>+        (-[WKEditCommandObjC command]): Deleted.
>+        (-[WKEditorUndoTargetObjC undoEditing:]): Deleted.
>+        (-[WKEditorUndoTargetObjC redoEditing:]): Deleted.
>+        * UIProcess/mac/PageClientImplMac.h:
>+        * WebKit.xcodeproj/project.pbxproj:
>+
> 2018-12-26  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Add support for using the current text selection as the find string on iOS
>diff --git a/Source/WebKit/SourcesCocoa.txt b/Source/WebKit/SourcesCocoa.txt
>index 320173fa7b1260f2b4cccc369d19f747ca4234a9..56f3c45c4119e7dcfc8db4b09e53d2b005801e7a 100644
>--- a/Source/WebKit/SourcesCocoa.txt
>+++ b/Source/WebKit/SourcesCocoa.txt
>@@ -339,6 +339,7 @@ UIProcess/Cocoa/WebProcessPoolCocoa.mm
> UIProcess/Cocoa/WebProcessProxyCocoa.mm
> UIProcess/Cocoa/WebURLSchemeHandlerCocoa.mm
> UIProcess/Cocoa/WebViewImpl.mm
>+UIProcess/Cocoa/WKEditCommand.mm
> UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm
> UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm
> UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm
>diff --git a/Source/WebKit/UIProcess/Cocoa/WKEditCommand.h b/Source/WebKit/UIProcess/Cocoa/WKEditCommand.h
>new file mode 100644
>index 0000000000000000000000000000000000000000..8648476fe4cc6cc53c101a30c6bb4dc635d18b41
>--- /dev/null
>+++ b/Source/WebKit/UIProcess/Cocoa/WKEditCommand.h
>@@ -0,0 +1,45 @@
>+/*
>+ * Copyright (C) 2018 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#pragma once
>+
>+#include <wtf/Ref.h>
>+#include <wtf/RefPtr.h>
>+
>+namespace WebKit {
>+class WebEditCommandProxy;
>+}
>+
>+@interface WKEditCommand : NSObject {
>+    RefPtr<WebKit::WebEditCommandProxy> m_command;
>+}
>+- (instancetype)initWithWebEditCommandProxy:(Ref<WebKit::WebEditCommandProxy>&&)command;
>+- (WebKit::WebEditCommandProxy*)command;
>+@end
>+
>+@interface WKEditorUndoTarget : NSObject
>+- (void)undoEditing:(id)sender;
>+- (void)redoEditing:(id)sender;
>+@end
>diff --git a/Source/WebKit/UIProcess/Cocoa/WKEditCommand.mm b/Source/WebKit/UIProcess/Cocoa/WKEditCommand.mm
>new file mode 100644
>index 0000000000000000000000000000000000000000..119cbefef3e74670bfa3822897b06d6072e9b4a7
>--- /dev/null
>+++ b/Source/WebKit/UIProcess/Cocoa/WKEditCommand.mm
>@@ -0,0 +1,64 @@
>+/*
>+ * Copyright (C) 2018 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#import "config.h"
>+#import "WKEditCommand.h"
>+
>+#import "WebEditCommandProxy.h"
>+
>+@implementation WKEditCommand
>+
>+- (instancetype)initWithWebEditCommandProxy:(Ref<WebKit::WebEditCommandProxy>&&)command
>+{
>+    self = [super init];
>+    if (!self)
>+        return nil;
>+
>+    m_command = WTFMove(command);
>+    return self;
>+}
>+
>+- (WebKit::WebEditCommandProxy*)command
>+{
>+    return m_command.get();
>+}
>+
>+@end
>+
>+@implementation WKEditorUndoTarget
>+
>+- (void)undoEditing:(id)sender
>+{
>+    ASSERT([sender isKindOfClass:WKEditCommand.class]);
>+    [sender command]->unapply();
>+}
>+
>+- (void)redoEditing:(id)sender
>+{
>+    ASSERT([sender isKindOfClass:WKEditCommand.class]);
>+    [sender command]->reapply();
>+}
>+
>+@end
>diff --git a/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h b/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h
>index 028037cc59873079d7ba02420e907ae6ffa8c4f2..f757d8724f267fd91a000248f48d4291b323517f 100644
>--- a/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h
>+++ b/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h
>@@ -50,7 +50,7 @@ OBJC_CLASS NSTextInputContext;
> OBJC_CLASS NSView;
> OBJC_CLASS WKAccessibilitySettingsObserver;
> OBJC_CLASS WKBrowsingContextController;
>-OBJC_CLASS WKEditorUndoTargetObjC;
>+OBJC_CLASS WKEditorUndoTarget;
> OBJC_CLASS WKFullScreenWindowController;
> OBJC_CLASS WKImmediateActionController;
> OBJC_CLASS WKSafeBrowsingWarning;
>@@ -706,7 +706,7 @@ private:
>     CGSize m_lastRequestedFixedLayoutSize { 0, 0 };
> 
>     bool m_inSecureInputState { false };
>-    RetainPtr<WKEditorUndoTargetObjC> m_undoTarget;
>+    RetainPtr<WKEditorUndoTarget> m_undoTarget;
> 
>     ValidationMap m_validationMap;
> 
>diff --git a/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm b/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
>index 1061289cfd24f77eae698e572b4e51e253df6612..45b64deb2e0b829485c2dc916a4bf102ab90c458 100644
>--- a/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
>+++ b/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
>@@ -56,6 +56,7 @@
> #import "UndoOrRedo.h"
> #import "ViewGestureController.h"
> #import "WKBrowsingContextControllerInternal.h"
>+#import "WKEditCommand.h"
> #import "WKErrorInternal.h"
> #import "WKFullScreenWindowController.h"
> #import "WKImmediateActionController.h"
>@@ -403,53 +404,6 @@ - (void)_activeSpaceDidChange:(NSNotification *)notification
> 
> @end
> 
>-@interface WKEditCommandObjC : NSObject {
>-    RefPtr<WebKit::WebEditCommandProxy> m_command;
>-}
>-- (id)initWithWebEditCommandProxy:(RefPtr<WebKit::WebEditCommandProxy>)command;
>-- (WebKit::WebEditCommandProxy*)command;
>-@end
>-
>-@interface WKEditorUndoTargetObjC : NSObject
>-- (void)undoEditing:(id)sender;
>-- (void)redoEditing:(id)sender;
>-@end
>-
>-@implementation WKEditCommandObjC
>-
>-- (id)initWithWebEditCommandProxy:(RefPtr<WebKit::WebEditCommandProxy>)command
>-{
>-    self = [super init];
>-    if (!self)
>-        return nil;
>-
>-    m_command = command;
>-    return self;
>-}
>-
>-- (WebKit::WebEditCommandProxy*)command
>-{
>-    return m_command.get();
>-}
>-
>-@end
>-
>-@implementation WKEditorUndoTargetObjC
>-
>-- (void)undoEditing:(id)sender
>-{
>-    ASSERT([sender isKindOfClass:[WKEditCommandObjC class]]);
>-    [sender command]->unapply();
>-}
>-
>-- (void)redoEditing:(id)sender
>-{
>-    ASSERT([sender isKindOfClass:[WKEditCommandObjC class]]);
>-    [sender command]->reapply();
>-}
>-
>-@end
>-
> @interface WKFlippedView : NSView
> @end
> 
>@@ -1386,7 +1340,7 @@ WebViewImpl::WebViewImpl(NSView <WebViewImplDelegate> *view, WKWebView *outerWeb
>     , m_needsViewFrameInWindowCoordinates(m_page->preferences().pluginsEnabled())
>     , m_intrinsicContentSize(CGSizeMake(NSViewNoIntrinsicMetric, NSViewNoIntrinsicMetric))
>     , m_layoutStrategy([WKViewLayoutStrategy layoutStrategyWithPage:m_page view:view viewImpl:*this mode:kWKLayoutModeViewSize])
>-    , m_undoTarget(adoptNS([[WKEditorUndoTargetObjC alloc] init]))
>+    , m_undoTarget(adoptNS([[WKEditorUndoTarget alloc] init]))
>     , m_windowVisibilityObserver(adoptNS([[WKWindowVisibilityObserver alloc] initWithView:view impl:*this]))
>     , m_accessibilitySettingsObserver(adoptNS([[WKAccessibilitySettingsObserver alloc] initWithImpl:*this]))
>     , m_primaryTrackingArea(adoptNS([[NSTrackingArea alloc] initWithRect:view.frame options:trackingAreaOptions() owner:view userInfo:nil]))
>@@ -2723,8 +2677,8 @@ void WebViewImpl::executeEditCommandForSelector(SEL selector, const String& argu
> 
> void WebViewImpl::registerEditCommand(Ref<WebEditCommandProxy>&& command, UndoOrRedo undoOrRedo)
> {
>-    RetainPtr<WKEditCommandObjC> commandObjC = adoptNS([[WKEditCommandObjC alloc] initWithWebEditCommandProxy:command.ptr()]);
>-    String actionName = WebEditCommandProxy::nameForEditAction(command->editAction());
>+    auto actionName = WebEditCommandProxy::nameForEditAction(command->editAction());
>+    auto commandObjC = adoptNS([[WKEditCommand alloc] initWithWebEditCommandProxy:WTFMove(command)]);
> 
>     NSUndoManager *undoManager = [m_view undoManager];
>     [undoManager registerUndoWithTarget:m_undoTarget.get() selector:((undoOrRedo == UndoOrRedo::Undo) ? @selector(undoEditing:) : @selector(redoEditing:)) object:commandObjC.get()];
>diff --git a/Source/WebKit/UIProcess/ios/PageClientImplIOS.h b/Source/WebKit/UIProcess/ios/PageClientImplIOS.h
>index a8e1d6a36094a3d8e205f3a7dfda46787fbbab8c..de741c722abe6c08e5081622c80f478a3bd60894 100644
>--- a/Source/WebKit/UIProcess/ios/PageClientImplIOS.h
>+++ b/Source/WebKit/UIProcess/ios/PageClientImplIOS.h
>@@ -32,7 +32,7 @@
> #import <wtf/RetainPtr.h>
> 
> OBJC_CLASS WKContentView;
>-OBJC_CLASS WKEditorUndoTargetObjC;
>+OBJC_CLASS WKEditorUndoTarget;
> 
> namespace WebCore {
> struct PromisedAttachmentInfo;
>@@ -229,7 +229,7 @@ private:
>     void didFinishProcessingAllPendingMouseEvents() final { }
> 
>     WKContentView *m_contentView;
>-    RetainPtr<WKEditorUndoTargetObjC> m_undoTarget;
>+    RetainPtr<WKEditorUndoTarget> m_undoTarget;
> };
> } // namespace WebKit
> 
>diff --git a/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm b/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
>index e929e20dc16e5bb5f63566afdd1c69ca89c63a62..421521b7483bec1dd9198a3b0bb5eed154d6574f 100644
>--- a/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
>+++ b/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
>@@ -41,6 +41,7 @@
> #import "ViewSnapshotStore.h"
> #import "WKContentView.h"
> #import "WKContentViewInteraction.h"
>+#import "WKEditCommand.h"
> #import "WKGeolocationProviderIOS.h"
> #import "WKPasswordView.h"
> #import "WKProcessPoolInternal.h"
>@@ -64,61 +65,13 @@
> 
> #define MESSAGE_CHECK(assertion) MESSAGE_CHECK_BASE(assertion, m_webView.get()->_page->process().connection())
> 
>-@interface WKEditCommandObjC : NSObject
>-{
>-    RefPtr<WebKit::WebEditCommandProxy> m_command;
>-}
>-- (id)initWithWebEditCommandProxy:(Ref<WebKit::WebEditCommandProxy>&&)command;
>-- (WebKit::WebEditCommandProxy*)command;
>-@end
>-
>-@interface WKEditorUndoTargetObjC : NSObject
>-- (void)undoEditing:(id)sender;
>-- (void)redoEditing:(id)sender;
>-@end
>-
>-@implementation WKEditCommandObjC
>-
>-- (id)initWithWebEditCommandProxy:(Ref<WebKit::WebEditCommandProxy>&&)command
>-{
>-    self = [super init];
>-    if (!self)
>-        return nil;
>-    
>-    m_command = WTFMove(command);
>-    return self;
>-}
>-
>-- (WebKit::WebEditCommandProxy *)command
>-{
>-    return m_command.get();
>-}
>-
>-@end
>-
>-@implementation WKEditorUndoTargetObjC
>-
>-- (void)undoEditing:(id)sender
>-{
>-    ASSERT([sender isKindOfClass:[WKEditCommandObjC class]]);
>-    [sender command]->unapply();
>-}
>-
>-- (void)redoEditing:(id)sender
>-{
>-    ASSERT([sender isKindOfClass:[WKEditCommandObjC class]]);
>-    [sender command]->reapply();
>-}
>-
>-@end
>-
> namespace WebKit {
> using namespace WebCore;
> 
> PageClientImpl::PageClientImpl(WKContentView *contentView, WKWebView *webView)
>     : PageClientImplCocoa(webView)
>     , m_contentView(contentView)
>-    , m_undoTarget(adoptNS([[WKEditorUndoTargetObjC alloc] init]))
>+    , m_undoTarget(adoptNS([[WKEditorUndoTarget alloc] init]))
> {
> }
> 
>@@ -312,8 +265,8 @@ void PageClientImpl::didChangeViewportProperties(const ViewportAttributes&)
> 
> void PageClientImpl::registerEditCommand(Ref<WebEditCommandProxy>&& command, UndoOrRedo undoOrRedo)
> {
>-    RetainPtr<WKEditCommandObjC> commandObjC = adoptNS([[WKEditCommandObjC alloc] initWithWebEditCommandProxy:command.copyRef()]);
>-    String actionName = WebEditCommandProxy::nameForEditAction(command->editAction());
>+    auto actionName = WebEditCommandProxy::nameForEditAction(command->editAction());
>+    auto commandObjC = adoptNS([[WKEditCommand alloc] initWithWebEditCommandProxy:WTFMove(command)]);
>     
>     NSUndoManager *undoManager = [m_contentView undoManager];
>     [undoManager registerUndoWithTarget:m_undoTarget.get() selector:((undoOrRedo == UndoOrRedo::Undo) ? @selector(undoEditing:) : @selector(redoEditing:)) object:commandObjC.get()];
>diff --git a/Source/WebKit/UIProcess/mac/PageClientImplMac.h b/Source/WebKit/UIProcess/mac/PageClientImplMac.h
>index 491ea486aa42f47686435ea1b29ad855385d641b..4d87c9053e2186013692ab4ea9571a9c29408fab 100644
>--- a/Source/WebKit/UIProcess/mac/PageClientImplMac.h
>+++ b/Source/WebKit/UIProcess/mac/PageClientImplMac.h
>@@ -32,7 +32,7 @@
> #include "WebFullScreenManagerProxy.h"
> #include <wtf/RetainPtr.h>
> 
>-@class WKEditorUndoTargetObjC;
>+@class WKEditorUndoTarget;
> @class WKView;
> 
> namespace WebCore {
>diff --git a/Source/WebKit/WebKit.xcodeproj/project.pbxproj b/Source/WebKit/WebKit.xcodeproj/project.pbxproj
>index cb2252065d45bf4b3c53c15b96999fdd0a23d4fb..743d012853725c8ca9e7b5d00bcbd5d3f44da93b 100644
>--- a/Source/WebKit/WebKit.xcodeproj/project.pbxproj
>+++ b/Source/WebKit/WebKit.xcodeproj/project.pbxproj
>@@ -738,6 +738,7 @@
> 		2EA7B3D12026CEF8009CE5AC /* WKNumberPadViewController.h in Headers */ = {isa = PBXBuildFile; fileRef = 2EA7B3CF2026CEF8009CE5AC /* WKNumberPadViewController.h */; };
> 		2EA7B3D52026CF23009CE5AC /* WKNumberPadView.h in Headers */ = {isa = PBXBuildFile; fileRef = 2EA7B3D32026CF23009CE5AC /* WKNumberPadView.h */; };
> 		2EB6FC01203021960017E619 /* WKTimePickerViewController.h in Headers */ = {isa = PBXBuildFile; fileRef = 2EB6FBFF203021960017E619 /* WKTimePickerViewController.h */; };
>+		2ECF66CE21D6B77E009E5C3F /* WKEditCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 2ECF66CC21D6B77E009E5C3F /* WKEditCommand.h */; };
> 		2F8336861FA139DF00C6E080 /* TouchBarMenuData.h in Headers */ = {isa = PBXBuildFile; fileRef = 2FD43B911FA006A10083F51C /* TouchBarMenuData.h */; };
> 		310999C7146C9E3D0029DEB9 /* WebNotificationClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 31099968146C71F50029DEB9 /* WebNotificationClient.h */; };
> 		312C0C4A146DDC8A0016C911 /* WKNotificationProvider.h in Headers */ = {isa = PBXBuildFile; fileRef = 312C0C49146DDC8A0016C911 /* WKNotificationProvider.h */; settings = {ATTRIBUTES = (Private, ); }; };
>@@ -2820,6 +2821,8 @@
> 		2EA7B3D42026CF23009CE5AC /* WKNumberPadView.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = WKNumberPadView.mm; path = ios/forms/WKNumberPadView.mm; sourceTree = "<group>"; };
> 		2EB6FBFF203021960017E619 /* WKTimePickerViewController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = WKTimePickerViewController.h; path = ios/forms/WKTimePickerViewController.h; sourceTree = "<group>"; };
> 		2EB6FC00203021960017E619 /* WKTimePickerViewController.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = WKTimePickerViewController.mm; path = ios/forms/WKTimePickerViewController.mm; sourceTree = "<group>"; };
>+		2ECF66CC21D6B77E009E5C3F /* WKEditCommand.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WKEditCommand.h; sourceTree = "<group>"; };
>+		2ECF66CD21D6B77E009E5C3F /* WKEditCommand.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = WKEditCommand.mm; sourceTree = "<group>"; };
> 		2F809DD51FBD1BC9005FE63A /* TouchBarMenuItemData.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = TouchBarMenuItemData.cpp; sourceTree = "<group>"; };
> 		2F809DD91FBD1BF2005FE63A /* TouchBarMenuItemData.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = TouchBarMenuItemData.h; sourceTree = "<group>"; };
> 		2FD43B911FA006A10083F51C /* TouchBarMenuData.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TouchBarMenuData.h; sourceTree = "<group>"; };
>@@ -5344,6 +5347,8 @@
> 				51D124321E6DE521002B2820 /* WebURLSchemeHandlerCocoa.mm */,
> 				2DFC7DB91BCCC19500C1548C /* WebViewImpl.h */,
> 				2DFC7DBA1BCCC19500C1548C /* WebViewImpl.mm */,
>+				2ECF66CC21D6B77E009E5C3F /* WKEditCommand.h */,
>+				2ECF66CD21D6B77E009E5C3F /* WKEditCommand.mm */,
> 				E1AEA22D14687BDB00804569 /* WKFullKeyboardAccessWatcher.h */,
> 				E1AEA22E14687BDB00804569 /* WKFullKeyboardAccessWatcher.mm */,
> 				1AD01BCB1905D54900C9C45F /* WKReloadFrameErrorRecoveryAttempter.h */,
>@@ -9658,6 +9663,7 @@
> 				637281A221ADC744009E0DE6 /* WKDownloadProgress.h in Headers */,
> 				F409BA181E6E64BC009DA28E /* WKDragDestinationAction.h in Headers */,
> 				2DC18FAD218910490025A88D /* WKDrawingView.h in Headers */,
>+				2ECF66CE21D6B77E009E5C3F /* WKEditCommand.h in Headers */,
> 				1AF4592F19464B2000F9D4A2 /* WKError.h in Headers */,
> 				BCFD548C132D82680055D816 /* WKErrorCF.h in Headers */,
> 				37B5045219EEF31300CE2CF8 /* WKErrorPrivate.h in Headers */,

Flags:

sam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193049: 358121 | 358130 | 358131