WebKit Bugzilla
Attachment 358120 Details for
Bug 193048
: [iOS] Pressing Tab key doesn't move to next cell with Google Sheets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193048-20181228121836.patch (text/plain), 2.09 KB, created by
Daniel Bates
on 2018-12-28 12:18:37 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Daniel Bates
Created:
2018-12-28 12:18:37 PST
Size:
2.09 KB
patch
obsolete
>Subversion Revision: 239378 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index db8ac3abcae81448ff19815769169296a5470398..5aa7a56406c590963153fef56f941c333adefeba 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,20 @@ >+2018-12-28 Daniel Bates <dabates@apple.com> >+ >+ [iOS] Pressing Tab key doesn't move to next cell with Google Sheets >+ https://bugs.webkit.org/show_bug.cgi?id=193048 >+ <rdar://problem/46433836> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ WebCore knows how interpret the Tab and Shift + Tab keys. Remove key commands for handling >+ them from the UIProcess code so that UIKit sends key events for these commands to us. This >+ will make the behavior of these key commands when executed in an editable field match the >+ behavior of these command when executed in a non-editable field since both code paths will >+ now go through WebCore. >+ >+ * UIProcess/ios/WKContentViewInteraction.mm: >+ (-[WKContentView keyCommands]): Deleted. >+ > 2018-12-19 Daniel Bates <dabates@apple.com> > > [iOS] Interpret text key commands on keydown and app key commands on keypress >diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >index 7ac48754f6628119da6cc9b10e14667b654fdc94..091301781a94b843aff0f41bd597cd9de492d5d6 100644 >--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >@@ -3315,18 +3315,6 @@ - (void)accessoryDone > [self resignFirstResponder]; > } > >-- (NSArray *)keyCommands >-{ >- if (!_page->editorState().isContentEditable) >- return nil; >- >- static NSArray* editableKeyCommands = [@[ >- [UIKeyCommand keyCommandWithInput:@"\t" modifierFlags:0 action:@selector(_nextAccessoryTab:)], >- [UIKeyCommand keyCommandWithInput:@"\t" modifierFlags:UIKeyModifierShift action:@selector(_previousAccessoryTab:)] >- ] retain]; >- return editableKeyCommands; >-} >- > - (void)_nextAccessoryTabForWebView:(id)sender > { > [self accessoryTab:YES];
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193048
:
358120
|
358185
|
359811