Attachment 358090 Details for Bug 193041 – patch

[patch] patch

patch (text/plain), 3.98 KB, created by chris fleizach on 2018-12-26 18:08:23 PST

(hide)

Description:

Filename:

MIME Type:

Creator: chris fleizach

Created: 2018-12-26 18:08:23 PST

Size: 3.98 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 239554)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-12-26  Chris Fleizach  <cfleizach@apple.com>
>+
>+        AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
>+        https://bugs.webkit.org/show_bug.cgi?id=193041
>+        <rdar://problem/46954090>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * en.lproj/Localizable.strings:
>+        * platform/cocoa/LocalizedStringsCocoa.mm:
>+        (WebCore::AXHorizontalRuleDescriptionText):
>+
> 2018-12-26  Jim Mason  <jmason@ibinx.com>
> 
>         [FreeType] Restore conditional compilation logic for recent HarfBuzz refactoring
>Index: Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm
>===================================================================
>--- Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm	(revision 239270)
>+++ Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm	(working copy)
>@@ -230,7 +230,7 @@
> 
> String AXHorizontalRuleDescriptionText()
> {
>-    return WEB_UI_STRING("rule", "accessibility role description for a horizontal rule [<hr>]");
>+    return WEB_UI_STRING("separator", "accessibility role description for a horizontal rule [<hr>]");
> }
> 
> String AXMarkText()
>Index: Source/WebCore/en.lproj/Localizable.strings
>===================================================================
>--- Source/WebCore/en.lproj/Localizable.strings	(revision 239270)
>+++ Source/WebCore/en.lproj/Localizable.strings	(working copy)
>@@ -1250,7 +1250,7 @@
> "return to realtime" = "return to realtime";
> 
> /* accessibility role description for a horizontal rule [<hr>] */
>-"rule" = "rule";
>+"separator" = "separator";
> 
> /* An ARIA accessibility group that contains a search feature of a website. */
> "search" = "search";
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 239554)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-12-26  Chris Fleizach  <cfleizach@apple.com>
>+
>+        AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
>+        https://bugs.webkit.org/show_bug.cgi?id=193041
>+        <rdar://problem/46954090>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * accessibility/mac/hr-element-expected.txt:
>+
> 2018-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed GTK+ gardening. Rebaseline fast/text/zero-font-size.html after r239539.
>Index: LayoutTests/accessibility/mac/hr-element-expected.txt
>===================================================================
>--- LayoutTests/accessibility/mac/hr-element-expected.txt	(revision 239270)
>+++ LayoutTests/accessibility/mac/hr-element-expected.txt	(working copy)
>@@ -5,7 +5,7 @@
> 
> hr1 role: AXRole: AXSplitter
> hr1 subrole: AXSubrole: AXContentSeparator
>-hr1 roleDescription: AXRoleDescription: rule
>+hr1 roleDescription: AXRoleDescription: separator
> hr1 description: AXDescription: 
> hr1 is value settable: false
> hr1 orientation: AXOrientation: AXHorizontalOrientation
>@@ -13,7 +13,7 @@
> 
> hr2 role: AXRole: AXSplitter
> hr2 subrole: AXSubrole: AXContentSeparator
>-hr2 roleDescription: AXRoleDescription: rule
>+hr2 roleDescription: AXRoleDescription: separator
> hr2 description: AXDescription: 
> hr2 is value settable: false
> hr2 orientation: AXOrientation: AXHorizontalOrientation
>@@ -21,7 +21,7 @@
> 
> hr3 role: AXRole: AXSplitter
> hr3 subrole: AXSubrole: AXContentSeparator
>-hr3 roleDescription: AXRoleDescription: rule
>+hr3 roleDescription: AXRoleDescription: separator
> hr3 description: AXDescription: RULER
> hr3 is value settable: false
> hr3 orientation: AXOrientation: AXHorizontalOrientation
>@@ -29,7 +29,7 @@
> 
> hr4 role: AXRole: AXSplitter
> hr4 subrole: AXSubrole: AXContentSeparator
>-hr4 roleDescription: AXRoleDescription: rule
>+hr4 roleDescription: AXRoleDescription: separator
> hr4 description: AXDescription: 
> hr4 is value settable: false
> hr4 orientation: AXOrientation: AXVerticalOrientation

Flags:

ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 193041: 358090 | 358092 | 358094 | 358096 | 358100 | 358101 | 358102