Attachment 358049 Details for Bug 193023 – Patch

[patch] Patch

bug-193023-20181224161647.patch (text/plain), 2.18 KB, created by Daniel Bates on 2018-12-24 16:16:48 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-12-24 16:16:48 PST

Size: 2.18 KB

patch

obsolete

>Subversion Revision: 239548
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 8dcee1e52700fae0a737c5008d5a85f0f1a8f060..d901713fa3523c3b6fbbc965feb4cab91d4ba00f 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-12-24  Daniel Bates  <dabates@apple.com>
>+
>+        [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
>+        https://bugs.webkit.org/show_bug.cgi?id=193023
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
>+        not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
>+        enumerator values. We should just remove this code.
>+
>+        * lldb/lldb_webkit.py:
>+        (WTFOptionSetProvider.has_children):
>+        (WTFOptionSetProvider.num_children):
>+        (WTFOptionSetProvider.get_child_index):
>+        (WTFOptionSetProvider.get_child_at_index):
>+
> 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         WebDriver: warn about non existing tests when parsing expectations
>diff --git a/Tools/lldb/lldb_webkit.py b/Tools/lldb/lldb_webkit.py
>index af7bab0ac9c5a9fb0bd67e4c24ebc07ee0527ccc..47e51f6a9a7d3d299ffa9aad6acb74d26d0b9d24 100644
>--- a/Tools/lldb/lldb_webkit.py
>+++ b/Tools/lldb/lldb_webkit.py
>@@ -705,13 +705,10 @@ class WTFOptionSetProvider:
>     def has_children(self):
>         return bool(self._elements)
> 
>-    #  Metadata is stored at indices greater than or equal to the number of elements in the set.
>     def num_children(self):
>-        return len(self._elements) + 1
>+        return len(self._elements)
> 
>     def get_child_index(self, name):
>-        if name == 'm_storage':
>-            return self.num_children()
>         try:
>             return int(name.lstrip('[').rstrip(']'))
>         except:
>@@ -720,8 +717,6 @@ class WTFOptionSetProvider:
>     def get_child_at_index(self, index):
>         if index < 0 or not self.valobj.IsValid():
>             return None
>-        if index == self.num_children():
>-            return self.storage
>         if index < len(self._elements):
>             (name, value) = self._elements[index]
>             return self.valobj.CreateValueFromExpression(name, str(value))

Actions: View | Formatted Diff | Diff

Attachments on bug 193023: 358049