Attachment 358015 Details for Bug 193003 – Patch

[patch] Patch

bug-193003-20181221195824.patch (text/plain), 8.85 KB, created by Myles C. Maxfield on 2018-12-21 19:58:25 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2018-12-21 19:58:25 PST

Size: 8.85 KB

patch

obsolete

>Subversion Revision: 239523
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index afe006ab696f1e973a0e708ccae598398b09dbc6..8ea3cb7a7417efb68bd6eb325583441ae012646f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-12-21  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        Only hyphenate text for which there is a language specified
>+        https://bugs.webkit.org/show_bug.cgi?id=193003
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        CSS-Text-3 says "The UA must therefore only automatically hyphenate text for which the content language is known
>+        and for which it has an appropriate hyphenation resource."
>+
>+        However, for watch, we rely on words not being too wide for the screen, and we enable hyphenation by default in
>+        the watch's user agent style sheet. We should either 1) convince ourselves that enough content is language-
>+        tagged that this wouldn't be a usability regression, or 2) provide a way for the watch to opt-out of this patch.
>+
>+        Test: fast/text/hyphenate-locale.html
>+
>+        * platform/text/cf/HyphenationCF.cpp:
>+
> 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         [WebAuthN] userPresence should always be true
>diff --git a/Source/WebCore/platform/text/cf/HyphenationCF.cpp b/Source/WebCore/platform/text/cf/HyphenationCF.cpp
>index 1c70c413d8cc225004b17d7b2a669a737057f36d..4cb3ff608674496ef05bd09c23164e243dff0e48 100644
>--- a/Source/WebCore/platform/text/cf/HyphenationCF.cpp
>+++ b/Source/WebCore/platform/text/cf/HyphenationCF.cpp
>@@ -51,10 +51,7 @@ public:
> 
>     static RetainPtr<CFLocaleRef> createValueForNullKey()
>     {
>-        // CF hyphenation functions use locale (regional formats) language, which doesn't necessarily match primary UI language,
>-        // so we can't use default locale here. See <rdar://problem/14897664>.
>-        RetainPtr<CFLocaleRef> locale = adoptCF(CFLocaleCreate(kCFAllocatorDefault, defaultLanguage().createCFString().get()));
>-        return CFStringIsHyphenationAvailableForLocale(locale.get()) ? locale : nullptr;
>+        return nullptr;
>     }
> 
>     static RetainPtr<CFLocaleRef> createValueForKey(const AtomicString& localeIdentifier)
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 09e26b9dce86ab08d1713043dd658433e3806307..cf3b19ccb55df1b82b9c3e882c1137aeea6c713e 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-12-21  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        Only hyphenate text for which there is a language specified
>+        https://bugs.webkit.org/show_bug.cgi?id=193003
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/thirdparty/__init__.py:
>+        (AutoinstallImportHook._install_pylint):
>+
> 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         [WebAuthN] userPresence should always be true
>diff --git a/Tools/Scripts/webkitpy/thirdparty/__init__.py b/Tools/Scripts/webkitpy/thirdparty/__init__.py
>index 6bbe5908c5d4d5e16fb7c2f8e0f680f4b308df3e..fdcb0514f9b9436c15fcba543c3d5e3b62dd301a 100644
>--- a/Tools/Scripts/webkitpy/thirdparty/__init__.py
>+++ b/Tools/Scripts/webkitpy/thirdparty/__init__.py
>@@ -168,9 +168,9 @@ class AutoinstallImportHook(object):
>             files_to_remove = []
>             if sys.platform == 'win32':
>                 files_to_remove = ['test/data/write_protected_file.txt']
>-            installer.install("https://files.pythonhosted.org/packages/source/l/logilab-common/logilab-common-0.58.1.tar.gz", url_subpath="logilab-common-0.58.1", target_name="logilab/common", files_to_remove=files_to_remove)
>-            installer.install("https://files.pythonhosted.org/packages/source/l/logilab-astng/logilab-astng-0.24.1.tar.gz", url_subpath="logilab-astng-0.24.1", target_name="logilab/astng")
>-            installer.install('https://files.pythonhosted.org/packages/source/p/pylint/pylint-0.25.2.tar.gz', url_subpath="pylint-0.25.2", target_name="pylint")
>+            #installer.install("https://files.pythonhosted.org/packages/source/l/logilab-common/logilab-common-0.58.1.tar.gz", url_subpath="logilab-common-0.58.1", target_name="logilab/common", files_to_remove=files_to_remove)
>+            #installer.install("https://files.pythonhosted.org/packages/source/l/logilab-astng/logilab-astng-0.24.1.tar.gz", url_subpath="logilab-astng-0.24.1", target_name="logilab/astng")
>+            #installer.install('https://files.pythonhosted.org/packages/source/p/pylint/pylint-0.25.2.tar.gz', url_subpath="pylint-0.25.2", target_name="pylint")
> 
>     # autoinstalled.buildbot is used by BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py
>     # and should ideally match the version of BuildBot used at build.webkit.org.
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index d94c4558eb4853cbc8741dc558a873be294eef05..b7043a924ec102d41a871ccf67557a64602bd00d 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-12-21  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        Only hyphenate text for which there is a language specified
>+        https://bugs.webkit.org/show_bug.cgi?id=193003
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac/fast/text/hyphenate-locale-expected.txt:
>+
> 2018-12-21  Justin Michaud  <justin_michaud@apple.com>
> 
>         CSS variables don't work for colors in "border" property
>diff --git a/LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt b/LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt
>index 120733d673a4b66441a4ef3ec8704b7b4fe0f755..09bf171e44f6a00de8569644b683a878c7956198 100644
>--- a/LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt
>+++ b/LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt
>@@ -1,45 +1,43 @@
>-layer at (0,0) size 785x754
>+layer at (0,0) size 785x672
>   RenderView at (0,0) size 785x600
>-layer at (0,0) size 785x754
>-  RenderBlock {HTML} at (0,0) size 785x754
>-    RenderBody {BODY} at (8,8) size 769x738
>-      RenderBlock {DIV} at (0,0) size 130x369
>-        RenderBlock {DIV} at (0,0) size 130x82
>-          RenderText {#text} at (0,0) size 124x82
>-            text run at (0,0) width 124: "through" + hyphen string "-"
>-            text run at (0,41) width 47: "out"
>-        RenderBlock {DIV} at (0,82) size 130x82
>+layer at (0,0) size 785x672
>+  RenderBlock {HTML} at (0,0) size 785x672
>+    RenderBody {BODY} at (8,8) size 769x656
>+      RenderBlock {DIV} at (0,0) size 130x328
>+        RenderBlock {DIV} at (0,0) size 130x41
>+          RenderText {#text} at (0,0) size 158x41
>+            text run at (0,0) width 158: "throughout"
>+        RenderBlock {DIV} at (0,41) size 130x82
>           RenderText {#text} at (0,0) size 124x82
>             text run at (0,0) width 124: "through" + hyphen string "-"
>             text run at (0,41) width 47: "out"
>-        RenderBlock {DIV} at (0,164) size 130x82
>+        RenderBlock {DIV} at (0,123) size 130x82
>           RenderText {#text} at (0,0) size 124x82
>             text run at (0,0) width 124: "through" + hyphen string "-"
>             text run at (0,41) width 47: "out"
>-        RenderBlock {DIV} at (0,246) size 130x82
>+        RenderBlock {DIV} at (0,205) size 130x82
>           RenderText {#text} at (0,0) size 124x82
>             text run at (0,0) width 124: "through" + hyphen string "-"
>             text run at (0,41) width 47: "out"
>-        RenderBlock {DIV} at (0,328) size 130x41
>+        RenderBlock {DIV} at (0,287) size 130x41
>           RenderText {#text} at (0,0) size 158x41
>             text run at (0,0) width 158: "throughout"
>-      RenderBlock {DIV} at (0,369) size 135x369
>-        RenderBlock {DIV} at (0,0) size 135x82
>-          RenderText {#text} at (0,0) size 102x82
>-            text run at (0,0) width 66: "reci" + hyphen string "-"
>-            text run at (0,41) width 102: "procity"
>-        RenderBlock {DIV} at (0,82) size 135x82
>+      RenderBlock {DIV} at (0,328) size 135x328
>+        RenderBlock {DIV} at (0,0) size 135x41
>+          RenderText {#text} at (0,0) size 156x41
>+            text run at (0,0) width 156: "reciprocity"
>+        RenderBlock {DIV} at (0,41) size 135x82
>           RenderText {#text} at (0,0) size 102x82
>             text run at (0,0) width 66: "reci" + hyphen string "-"
>             text run at (0,41) width 102: "procity"
>-        RenderBlock {DIV} at (0,164) size 135x82
>+        RenderBlock {DIV} at (0,123) size 135x82
>           RenderText {#text} at (0,0) size 102x82
>             text run at (0,0) width 66: "reci" + hyphen string "-"
>             text run at (0,41) width 102: "procity"
>-        RenderBlock {DIV} at (0,246) size 135x82
>+        RenderBlock {DIV} at (0,205) size 135x82
>           RenderText {#text} at (0,0) size 128x82
>             text run at (0,0) width 40: "re" + hyphen string "-"
>             text run at (0,41) width 128: "ciprocity"
>-        RenderBlock {DIV} at (0,328) size 135x41
>+        RenderBlock {DIV} at (0,287) size 135x41
>           RenderText {#text} at (0,0) size 156x41
>             text run at (0,0) width 156: "reciprocity"

Actions: View | Formatted Diff | Diff

Attachments on bug 193003: 358015 | 358016 | 358017 | 358018 | 358020