Attachment 357999 Details for Bug 192996 – Patch

[patch] Patch

bug-192996-20181221160832.patch (text/plain), 1.85 KB, created by Daniel Bates on 2018-12-21 16:08:32 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-12-21 16:08:32 PST

Size: 1.85 KB

patch

obsolete

>Subversion Revision: 239517
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0fb7d97b13d81c09c073242ead0e25ec763fb4d1..09d0e9aec6f4d34a86c55a24285fa33cc12f1739 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-12-21  Daniel Bates  <dabates@apple.com>
>+
>+        REGRESSION (r238522): Erratic scrolling on Google flights search result page and vrbo.com
>+        https://bugs.webkit.org/show_bug.cgi?id=192996
>+        <rdar://problem/46573552>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Only scroll a text field if its inner text size changes and it is the currently active and
>+        focused element on the page.
>+
>+        * rendering/RenderTextControlSingleLine.cpp:
>+        (WebCore::RenderTextControlSingleLine::layout):
>+
> 2018-12-21  Justin Michaud  <justin_michaud@apple.com>
> 
>         CSS variables don't work for colors in "border" property
>diff --git a/Source/WebCore/rendering/RenderTextControlSingleLine.cpp b/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
>index 298fac2ac2a2563dbb8cc4630a28a265961a09cc..3054b44762c9dc49aaa2729bd4c79677af178a85 100644
>--- a/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
>+++ b/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
>@@ -212,7 +212,7 @@ void RenderTextControlSingleLine::layout()
>     if (inputElement().isSearchField())
>         RenderThemeIOS::adjustRoundBorderRadius(mutableStyle(), *this);
> #endif
>-    if (innerTextSizeChanged) {
>+    if (innerTextSizeChanged && frame().selection().isFocusedAndActive() && document().focusedElement() == &inputElement()) {
>         // The caps lock indicator was hidden or shown. If it is now visible then it may be occluding
>         // the current selection (say, the caret was after the last character in the text field).
>         // Schedule an update and reveal of the current selection.

Actions: View | Formatted Diff | Diff

Attachments on bug 192996: 357999 | 358387