Attachment 357990 Details for Bug 192123 – Patch

[patch] Patch

patch.txt (text/plain), 2.23 KB, created by Nikita Vasilyev on 2018-12-21 15:38:30 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2018-12-21 15:38:30 PST

Size: 2.23 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 0e46844587d..23466768984 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-21  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: editing focus lost when inspector is blurred
>+        https://bugs.webkit.org/show_bug.cgi?id=192123
>+        <rdar://problem/46800966>
>+
>+        Reviewed by Devin Rousso.
>+
>+        * UserInterface/Views/SpreadsheetSelectorField.js:
>+        (WI.SpreadsheetSelectorField.prototype._handleBlur):
>+        * UserInterface/Views/SpreadsheetTextField.js:
>+        (WI.SpreadsheetTextField.prototype._handleBlur):
>+
> 2018-12-20  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Dark Mode: Type profiler popovers have black text on dark background
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js
>index d1fc285fd68..24221bcd718 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js
>@@ -85,6 +85,10 @@ WI.SpreadsheetSelectorField = class SpreadsheetSelectorField
> 
>     _handleBlur(event)
>     {
>+        // Keep editing after tabbing out of Web Inspector window and back.
>+        if (document.activeElement === this._element)
>+            return;
>+
>         this.stopEditing();
> 
>         if (this._delegate && typeof this._delegate.spreadsheetSelectorFieldDidChange === "function")
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js
>index 40d35b4e910..109bbce34b0 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js
>@@ -213,6 +213,10 @@ WI.SpreadsheetTextField = class SpreadsheetTextField
>         if (!this._editing)
>             return;
> 
>+        // Keep editing after tabbing out of Web Inspector window and back.
>+        if (document.activeElement === this._element)
>+            return;
>+
>         this._applyCompletionHint();
>         this.discardCompletion();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192123: 357981 | 357984 | 357990