Attachment 357989 Details for Bug 192357 – Patch

[patch] Patch

bug-192357-20181221153354.patch (text/plain), 1.61 KB, created by zalan on 2018-12-21 15:33:55 PST

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2018-12-21 15:33:55 PST

Size: 1.61 KB

patch

obsolete

>Subversion Revision: 239515
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 74b6dad5c34d1a1d84d49b93a45e7a71901e66e4..76a6dd20961ba140de7f08b08f4f540706bbee66 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-21  Zalan Bujtas  <zalan@apple.com>
>+
>+        [iOS] Using file upload can trigger a crash under RenderThemeIOS::paintFileUploadIconDecorations()
>+        https://bugs.webkit.org/show_bug.cgi?id=192357
>+        <rdar://problem/42852260>
>+
>+        Reviewed by Simon Fraser.
>+
>+        Do not try to paint the file picker when painting is disabled.
>+
>+        * rendering/RenderFileUploadControl.cpp:
>+        (WebCore::RenderFileUploadControl::paintObject):
>+
> 2018-12-21  Justin Fan  <justin_fan@apple.com>
> 
>         [WebGPU] GPUBindGroupLayout refactoring: no HashMap, and failure logging
>diff --git a/Source/WebCore/rendering/RenderFileUploadControl.cpp b/Source/WebCore/rendering/RenderFileUploadControl.cpp
>index 6c547cf0581754004f60f0f48cad8fa48e7a5531..1cd32b3eb0b31bfd36f8782a434af62432df7c16 100644
>--- a/Source/WebCore/rendering/RenderFileUploadControl.cpp
>+++ b/Source/WebCore/rendering/RenderFileUploadControl.cpp
>@@ -117,6 +117,9 @@ void RenderFileUploadControl::paintObject(PaintInfo& paintInfo, const LayoutPoin
>     if (style().visibility() != Visibility::Visible)
>         return;
>     
>+    if (paintInfo.context().paintingDisabled())
>+        return;
>+
>     // Push a clip.
>     GraphicsContextStateSaver stateSaver(paintInfo.context(), false);
>     if (paintInfo.phase == PaintPhase::Foreground || paintInfo.phase == PaintPhase::ChildBlockBackgrounds) {

Actions: View | Formatted Diff | Diff

Attachments on bug 192357: 356477 | 357985 | 357989