Attachment 357969 Details for Bug 192061 – Part 5.

[patch] Part 5.

bug-192061-20181221125658.patch (text/plain), 2.70 KB, created by Jiewen Tan on 2018-12-21 12:56:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jiewen Tan

Created: 2018-12-21 12:56:59 PST

Size: 2.70 KB

patch

obsolete

>Subversion Revision: 239465
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 6f5c5959550a02b6e1ec4c74605ea0d6ff4b22ed..13820c772364449380d3925b1b05cd695350aae4 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=192061
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part 5.
>+
>+        Add some additional temporary logging info to determine if the time out value passed to the timer is respected.
>+        Once the bug is determined and fixed, we should remove all logging added in this patch.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebAuthentication/AuthenticatorManager.cpp:
>+        (WebKit::AuthenticatorManager::initTimeOutTimer):
>+        (WebKit::AuthenticatorManager::timeOutTimerFired):
>+
> 2018-12-20  Chris Dumez  <cdumez@apple.com>
> 
>         Use Optional::valueOr() instead of Optional::value_or()
>diff --git a/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp b/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
>index 73f55a4835f128831bc3288c8ad254370578c2f4..2f924c93174c304a8b14b95faab5f26b49be7512 100644
>--- a/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
>+++ b/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
>@@ -30,6 +30,7 @@
> 
> #include <WebCore/AuthenticatorTransport.h>
> #include <WebCore/PublicKeyCredentialCreationOptions.h>
>+#include <wtf/MonotonicTime.h>
> 
> namespace WebKit {
> using namespace WebCore;
>@@ -226,15 +227,16 @@ void AuthenticatorManager::initTimeOutTimer(const Optional<unsigned>& timeOutInM
> 
>     unsigned timeOutInMsValue = std::min(maxTimeOutValue, timeOutInMs.valueOr(maxTimeOutValue));
>     // FIXME(192061)
>-    LOG_ERROR("Start timer. %d", timeOutInMsValue);
>+    LOG_ERROR("Start timer: %d. Current time: %f.", timeOutInMsValue, MonotonicTime::now().secondsSinceEpoch().value());
>     m_requestTimeOutTimer.startOneShot(Seconds::fromMilliseconds(timeOutInMsValue));
>+    LOG_ERROR("Seconds until fire: %f", m_requestTimeOutTimer.secondsUntilFire().value());
> }
> 
> void AuthenticatorManager::timeOutTimerFired()
> {
>     ASSERT(m_requestTimeOutTimer.isActive());
>     // FIXME(192061)
>-    LOG_ERROR("Timer fired.");
>+    LOG_ERROR("Timer fired: %f, Current time: %f", m_requestTimeOutTimer.secondsUntilFire().value(), MonotonicTime::now().secondsSinceEpoch().value());
>     m_pendingCompletionHandler((ExceptionData { NotAllowedError, "Operation timed out."_s }));
>     clearStateAsync();
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 192061: 356665 | 357284 | 357480 | 357622 | 357969 | 358635 | 358758 | 358844 | 358846 | 358851