Attachment 357958 Details for Bug 192986 – Patch

[patch] Patch

wk-hb-zero-font-size.diff (text/plain), 1.58 KB, created by Carlos Garcia Campos on 2018-12-21 10:40:35 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2018-12-21 10:40:35 PST

Size: 1.58 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1675be7bfc8..9e3ede154de 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [HarfBuzz] Width not correctly reported as 0 for zero font size
>+        https://bugs.webkit.org/show_bug.cgi?id=192986
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fixes test fast/text/font-size-zero.html
>+
>+        * platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
>+        (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Use empty advances for glyps when the font
>+        size is zero.
>+
> 2018-12-20  Justin Fan  <justin_fan@apple.com>
> 
>         [WebGPU] Convert WebGPUBindGroups into MTLArgumentEncoders
>diff --git a/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp b/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp
>index 0e0aa6cad15..5532d189932 100644
>--- a/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp
>+++ b/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp
>@@ -156,7 +156,7 @@ ComplexTextController::ComplexTextRun::ComplexTextRun(hb_buffer_t* buffer, const
>         m_coreTextIndices[i] = glyphInfos[i].cluster;
> 
>         uint16_t glyph = glyphInfos[i].codepoint;
>-        if (m_font.isZeroWidthSpaceGlyph(glyph)) {
>+        if (m_font.isZeroWidthSpaceGlyph(glyph) || !m_font.platformData().size()) {
>             m_glyphs[i] = glyph;
>             m_baseAdvances[i] = { };
>             m_glyphOrigins[i] = { };

Flags:

mcatanzaro: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 192986: 357958