Attachment 357936 Details for Bug 192979 – Patch

[patch] Patch

wd-removed-tests-expectations.diff (text/plain), 1.74 KB, created by Carlos Garcia Campos on 2018-12-21 02:39:32 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2018-12-21 02:39:32 PST

Size: 1.74 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index ac5c9a28448..a86dc81cad5 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        WebDriver: warn about non existing tests when parsing expectations
>+        https://bugs.webkit.org/show_bug.cgi?id=192979
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It's common to update web driver tests and forget updating the test expectations in case of tests removed or
>+        renamed.
>+
>+        * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
>+        (WebDriverTestRunner.__init__):
>+
> 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
> 
>         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
>diff --git a/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py b/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py
>index ad6ae951141..f9e6133f51c 100644
>--- a/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py
>+++ b/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py
>@@ -56,6 +56,9 @@ class WebDriverTestRunner(object):
>         expectations_file = os.path.join(self._tests_dir, 'TestExpectations.json')
>         build_type = 'Debug' if self._port.get_option('debug') else 'Release'
>         self._expectations = TestExpectations(self._port.name(), expectations_file, build_type)
>+        for test in self._expectations._expectations.keys():
>+            if not os.path.isfile(os.path.join(self._tests_dir, test)):
>+                _log.warning('Test %s does not exist' % test)
> 
>         env = self._display_driver._setup_environ_for_test()
>         self._runners = [runner_cls(self._port, driver, env, self._expectations) for runner_cls in self.RUNNER_CLASSES]

Flags:

mcatanzaro: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 192979: 357936