Attachment 357934 Details for Bug 192976 – Patch

[patch] Patch

wd-connection-closed.diff (text/plain), 1.31 KB, created by Carlos Garcia Campos on 2018-12-21 00:31:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2018-12-21 00:31:40 PST

Size: 1.31 KB

patch

obsolete

>diff --git a/Source/WebDriver/ChangeLog b/Source/WebDriver/ChangeLog
>index 2a9dbf9fdc1..67193beff51 100644
>--- a/Source/WebDriver/ChangeLog
>+++ b/Source/WebDriver/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GLIB] WebDriver: dbusConnectionClosedCallback can be called after SessionHost has been deleted
>+        https://bugs.webkit.org/show_bug.cgi?id=192976
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Disconnect DBus connection signals using SessionHost as user data in SessionHost destructor.
>+
>+        * glib/SessionHostGlib.cpp:
>+        (WebDriver::SessionHost::~SessionHost):
>+
> 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         WebDriver: Session::findElements should handle user prompts
>diff --git a/Source/WebDriver/glib/SessionHostGlib.cpp b/Source/WebDriver/glib/SessionHostGlib.cpp
>index 0b2ddaa45e0..364ca80f893 100644
>--- a/Source/WebDriver/glib/SessionHostGlib.cpp
>+++ b/Source/WebDriver/glib/SessionHostGlib.cpp
>@@ -41,6 +41,8 @@ namespace WebDriver {
> 
> SessionHost::~SessionHost()
> {
>+    if (m_dbusConnection)
>+        g_signal_handlers_disconnect_matched(m_dbusConnection.get(), G_SIGNAL_MATCH_DATA, 0, 0, nullptr, nullptr, this);
>     g_cancellable_cancel(m_cancellable.get());
>     if (m_browser)
>         g_subprocess_force_exit(m_browser.get());

Flags:

alex: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 192976: 357933 | 357934