Attachment 357916 Details for Bug 192968 – Patch

[patch] Patch

bug-192968-20181221115807.patch (text/plain), 8.88 KB, created by Fujii Hironori on 2018-12-20 18:58:08 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-12-20 18:58:08 PST

Size: 8.88 KB

patch

obsolete

>Subversion Revision: 239487
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 5c3ec33f3f7635b3164e62b8c7d99388f76e1e16..c4e1b605fb972945e097965acd4e5ede7375a5c5 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,26 @@
>+2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [WebKit][Win] Remove using namespace in the global space
>+        https://bugs.webkit.org/show_bug.cgi?id=192968
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Moved using namespace statements in the global scope to inside
>+        namespaces.
>+        <https://webkit.org/code-style-guidelines/#using-position>
>+
>+        * NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp:
>+        * NetworkProcess/curl/NetworkDataTaskCurl.cpp:
>+        * NetworkProcess/curl/NetworkProcessCurl.cpp:
>+        * NetworkProcess/curl/NetworkSessionCurl.cpp:
>+        * NetworkProcess/curl/RemoteNetworkingContextCurl.cpp:
>+        * Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp:
>+        * Shared/WebWheelEvent.cpp:
>+        * Shared/curl/WebCoreArgumentCodersCurl.cpp:
>+        * Shared/win/NativeWebKeyboardEventWin.cpp:
>+        * Shared/win/WebEventFactory.cpp:
>+        * UIProcess/Automation/WebAutomationSession.cpp:
>+
> 2018-12-20  Alex Christensen  <achristensen@webkit.org>
> 
>         Remove unused NetworkProcessCreationParameters
>diff --git a/Source/WebKit/NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp b/Source/WebKit/NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp
>index ed1b333fe4491f909e5d349927aeb1123b69b195..f373e1a0a9164f13bdd8eb789e8df0de6cbbd5cc 100644
>--- a/Source/WebKit/NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp
>+++ b/Source/WebKit/NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp
>@@ -31,10 +31,10 @@
> #include <WebCore/NetworkStorageSession.h>
> #include <wtf/text/CString.h>
> 
>-using namespace WebCore;
>-
> namespace WebKit {
> 
>+using namespace WebCore;
>+
> void WebCookieManager::platformSetHTTPCookieAcceptPolicy(HTTPCookieAcceptPolicy)
> {
> }
>diff --git a/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp b/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp
>index 4871c213b86167d3626db44bb2518ab9b9f7bb56..f3ad88be4ea788003b1ad455dce9b9ba4e673e24 100644
>--- a/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp
>+++ b/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp
>@@ -37,10 +37,10 @@
> #include <WebCore/ResourceError.h>
> #include <WebCore/SameSiteInfo.h>
> 
>-using namespace WebCore;
>-
> namespace WebKit {
> 
>+using namespace WebCore;
>+
> NetworkDataTaskCurl::NetworkDataTaskCurl(NetworkSession& session, NetworkDataTaskClient& client, const ResourceRequest& requestWithCredentials, StoredCredentialsPolicy storedCredentialsPolicy, ContentSniffingPolicy shouldContentSniff, ContentEncodingSniffingPolicy, bool shouldClearReferrerOnHTTPSToHTTPRedirect, bool dataTaskIsForMainFrameNavigation)
>     : NetworkDataTask(session, client, requestWithCredentials, storedCredentialsPolicy, shouldClearReferrerOnHTTPSToHTTPRedirect, dataTaskIsForMainFrameNavigation)
> {
>diff --git a/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp b/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp
>index e7a3b47c9b16e1d9004aad922554cecf99f9a254..28afa8d7cfd5e8eae758b30e25e625dc4c75e07b 100644
>--- a/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp
>+++ b/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp
>@@ -32,10 +32,10 @@
> #include <WebCore/NetworkStorageSession.h>
> #include <WebCore/NotImplemented.h>
> 
>-using namespace WebCore;
>-
> namespace WebKit {
> 
>+using namespace WebCore;
>+
> void NetworkProcess::platformInitializeNetworkProcess(const NetworkProcessCreationParameters& parameters)
> {
>     if (!parameters.cookiePersistentStorageFile.isEmpty())
>diff --git a/Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp b/Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp
>index fa68b6eb7cac10c4a9a8a27cfe13d5d3fb8b6ddf..781eb42dbb503167ed6565dc38f4ec00cbab7eb0 100644
>--- a/Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp
>+++ b/Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp
>@@ -30,10 +30,10 @@
> #include <WebCore/CurlContext.h>
> #include <WebCore/NetworkStorageSession.h>
> 
>-using namespace WebCore;
>-
> namespace WebKit {
> 
>+using namespace WebCore;
>+
> NetworkSessionCurl::NetworkSessionCurl(NetworkSessionCreationParameters&& parameters)
>     : NetworkSession(parameters.sessionID)
> {
>diff --git a/Source/WebKit/NetworkProcess/curl/RemoteNetworkingContextCurl.cpp b/Source/WebKit/NetworkProcess/curl/RemoteNetworkingContextCurl.cpp
>index 75939b2e835caeb0f17d26b48a8a7374fb143c74..504644a2fd12a81276a75a47524601efa8560745 100644
>--- a/Source/WebKit/NetworkProcess/curl/RemoteNetworkingContextCurl.cpp
>+++ b/Source/WebKit/NetworkProcess/curl/RemoteNetworkingContextCurl.cpp
>@@ -31,10 +31,10 @@
> #include "WebsiteDataStoreParameters.h"
> #include <WebCore/NetworkStorageSession.h>
> 
>-using namespace WebCore;
>-
> namespace WebKit {
> 
>+using namespace WebCore;
>+
> void RemoteNetworkingContext::ensureWebsiteDataStoreSession(WebsiteDataStoreParameters&& parameters)
> {
>     auto sessionID = parameters.networkSessionParameters.sessionID;
>diff --git a/Source/WebKit/Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp b/Source/WebKit/Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp
>index 4e2f71c8c3995b39468ec1428866cc4658ff8883..ce80829adefb7d0a06edd9c5be7cabf62d75e569 100644
>--- a/Source/WebKit/Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp
>+++ b/Source/WebKit/Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp
>@@ -29,10 +29,10 @@
> 
> #include "NetscapePluginModule.h"
> 
>-using namespace WebCore;
>-
> namespace WebKit {
> 
>+using namespace WebCore;
>+
> bool NetscapePluginModule::getPluginInfo(const String&, PluginModuleInfo&)
> {
>     return false;
>diff --git a/Source/WebKit/Shared/WebWheelEvent.cpp b/Source/WebKit/Shared/WebWheelEvent.cpp
>index ba10e90e99a18c419ae1df25a6b265106dd0ef9b..9ec757598fa67d17b65dbda398e2db61220805db 100644
>--- a/Source/WebKit/Shared/WebWheelEvent.cpp
>+++ b/Source/WebKit/Shared/WebWheelEvent.cpp
>@@ -28,7 +28,8 @@
> 
> #include "WebCoreArgumentCoders.h"
> 
>-namespace WebKit {    
>+namespace WebKit {
>+
> using namespace WebCore;
> 
> WebWheelEvent::WebWheelEvent(Type type, const IntPoint& position, const IntPoint& globalPosition, const FloatSize& delta, const FloatSize& wheelTicks, Granularity granularity, Modifiers modifiers, WallTime timestamp)
>diff --git a/Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp b/Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp
>index 825f875c8d699388fbd3332c82ca030c099bbd80..027385da16db67e80335fe1b7688b5af10ebcfb6 100644
>--- a/Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp
>+++ b/Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp
>@@ -35,10 +35,10 @@
> #include <WebCore/ResourceResponse.h>
> #include <wtf/text/CString.h>
> 
>-using namespace WebCore;
>-
> namespace IPC {
> 
>+using namespace WebCore;
>+
> void ArgumentCoder<ResourceRequest>::encodePlatformData(Encoder& encoder, const ResourceRequest& resourceRequest)
> {
>     resourceRequest.encodeWithPlatformData(encoder);
>diff --git a/Source/WebKit/Shared/win/NativeWebKeyboardEventWin.cpp b/Source/WebKit/Shared/win/NativeWebKeyboardEventWin.cpp
>index 6417a38e4d3155361a02e3492661231d5620b6e8..9be929263335be209d22013bd67880570bfb2f78 100644
>--- a/Source/WebKit/Shared/win/NativeWebKeyboardEventWin.cpp
>+++ b/Source/WebKit/Shared/win/NativeWebKeyboardEventWin.cpp
>@@ -29,10 +29,10 @@
> 
> #include "WebEventFactory.h"
> 
>-using namespace WebCore;
>-
> namespace WebKit {
> 
>+using namespace WebCore;
>+
> NativeWebKeyboardEvent::NativeWebKeyboardEvent(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
>     : WebKeyboardEvent(WebEventFactory::createWebKeyboardEvent(hwnd, message, wParam, lParam))
>     , m_nativeEvent(createNativeEvent(hwnd, message, wParam, lParam))
>diff --git a/Source/WebKit/Shared/win/WebEventFactory.cpp b/Source/WebKit/Shared/win/WebEventFactory.cpp
>index 0d328c3a3d44ab331ba5878720a47c8a5c0001d6..91e04fa922919e440859e354727ee478149f4cd8 100644
>--- a/Source/WebKit/Shared/win/WebEventFactory.cpp
>+++ b/Source/WebKit/Shared/win/WebEventFactory.cpp
>@@ -34,10 +34,10 @@
> #include <windowsx.h>
> #include <wtf/ASCIICType.h>
> 
>-using namespace WebCore;
>-
> namespace WebKit {
> 
>+using namespace WebCore;
>+
> static inline LPARAM relativeCursorPosition(HWND hwnd)
> {
>     POINT point = { -1, -1 };
>diff --git a/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp b/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
>index ba527d26010368a7a8a857f05cfe80011605d8d8..d209fae99d3ea7600c72c6af3ea84430a2f1ff49 100644
>--- a/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
>+++ b/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
>@@ -51,10 +51,10 @@
> #include <wtf/UUID.h>
> #include <wtf/text/StringConcatenate.h>
> 
>-using namespace Inspector;
>-
> namespace WebKit {
> 
>+using namespace Inspector;
>+
> String AutomationCommandError::toProtocolString()
> {
>     String protocolErrorName = Inspector::Protocol::AutomationHelpers::getEnumConstantValue(type);

Flags:

achristensen: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 192968: 357916