Attachment 357909 Details for Bug 192835 – Patch

[patch] Patch

bug-192835-20181220173905.patch (text/plain), 3.11 KB, created by Jiewen Tan on 2018-12-20 17:39:06 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jiewen Tan

Created: 2018-12-20 17:39:06 PST

Size: 3.11 KB

patch

obsolete

>Subversion Revision: 239465
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 6c10bac620ed624c6f2f1c07551afd5f72f42b6b..a60a558912da4233f023f9d9427df2ff36c6f23e 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [WebAuthN] userPresence should always be true
>+        https://bugs.webkit.org/show_bug.cgi?id=192835
>+        <rdar://problem/46538788>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In the current spec as of 7 August 2018, userPresence is suggested to set to the inverse of userVerification.
>+        This doesn't comply with the CTAP spec. Details in: https://github.com/w3c/webauthn/issues/1123.
>+        The change is made to follow my suggestion in the issue as no one has objected it.
>+
>+        Covered by exisiting tests.
>+
>+        * Modules/webauthn/fido/DeviceRequestConverter.cpp:
>+        (fido::encodeGetAssertionRequestAsCBOR):
>+
> 2018-12-20  Chris Dumez  <cdumez@apple.com>
> 
>         Use Optional::valueOr() instead of Optional::value_or()
>diff --git a/Source/WebCore/Modules/webauthn/fido/DeviceRequestConverter.cpp b/Source/WebCore/Modules/webauthn/fido/DeviceRequestConverter.cpp
>index 2d2d9223367d55b6beb30fbf3cb2c0321ace1e56..ebdb19253b2efba6aa4560516361ac72d15aa851 100644
>--- a/Source/WebCore/Modules/webauthn/fido/DeviceRequestConverter.cpp
>+++ b/Source/WebCore/Modules/webauthn/fido/DeviceRequestConverter.cpp
>@@ -159,7 +159,7 @@ Vector<uint8_t> encodeGetAssertionRequestAsCBOR(const Vector<uint8_t>& hash, con
>         requireUserVerification = false;
>     }
>     optionMap[CBORValue(kUserVerificationMapKey)] = CBORValue(requireUserVerification);
>-    optionMap[CBORValue(kUserPresenceMapKey)] = CBORValue(!requireUserVerification);
>+    optionMap[CBORValue(kUserPresenceMapKey)] = CBORValue(true);
> 
>     if (!optionMap.empty())
>         cborMap[CBORValue(5)] = CBORValue(WTFMove(optionMap));
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 368db4c37415566bb085bdf814ac52a2de38aff2..efba223a5b799e152de26ef5a0df40dbc603cbca 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [WebAuthN] userPresence should always be true
>+        https://bugs.webkit.org/show_bug.cgi?id=192835
>+        <rdar://problem/46538788>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
>+        (TestWebKitAPI::TEST):
>+
> 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
> 
>         webkitpy: Autoinstall package URLs have changed
>diff --git a/Tools/TestWebKitAPI/Tests/WebCore/FidoTestData.h b/Tools/TestWebKitAPI/Tests/WebCore/FidoTestData.h
>index efea65bf2a02d73c68d220c62c0a0690f6f1387c..60d37f5a7a9c0468f19094b179a67940f7c48d1d 100644
>--- a/Tools/TestWebKitAPI/Tests/WebCore/FidoTestData.h
>+++ b/Tools/TestWebKitAPI/Tests/WebCore/FidoTestData.h
>@@ -344,8 +344,8 @@ constexpr uint8_t kTestComplexCtapGetAssertionRequest[] = {
>     0xa2,
>     // key -"up"
>     0x62, 0x75, 0x70,
>-    // value - False(20)
>-    0xf4,
>+    // value - True(21)
>+    0xf5,
>     // key - "uv"
>     0x62, 0x75, 0x76,
>     // value - True(21)

Flags:

bfulgham: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 192835: 357908 | 357909 | 357983