Attachment 357904 Details for Bug 192916 – Patch

[patch] Patch

patch.txt (text/plain), 3.64 KB, created by Nikita Vasilyev on 2018-12-20 17:17:22 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2018-12-20 17:17:22 PST

Size: 3.64 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b464cca872a..c58990aa9d2 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-12-20  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Dark Mode: Type profiler popovers have black text on dark background
>+        https://bugs.webkit.org/show_bug.cgi?id=192916
>+        <rdar://problem/46863518>
>+
>+        Reviewed by Devin Rousso.
>+
>+        * UserInterface/Views/SourceCodeTextEditor.css:
>+        (.popover .debugger-popover-content > .body):
>+        * UserInterface/Views/TypeTreeElement.css:
>+        (.item.type-tree-element.prototype):
>+        (.item.type-tree-element.prototype:hover,):
>+        * UserInterface/Views/TypeTreeView.css:
>+        (.type-tree):
>+        * UserInterface/Views/Variables.css:
>+        (:root):
>+
> 2018-12-19  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Audit: fix descriptions for default tests
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css b/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css
>index 072afc85bd4..af1c2e08bb1 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css
>@@ -144,7 +144,7 @@
> }
> 
> .popover .debugger-popover-content > .body {
>-    border-top: 1px solid hsla(0, 0%, 0%, 0.3);
>+    border-top: 1px solid var(--text-color-quaternary);
>     overflow: auto;
>     padding-top: 2px;
> }
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css b/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css
>index d1f48d1ba81..338d9b27bd6 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css
>@@ -74,8 +74,9 @@ body[dir=rtl] .item.type-tree-element.parent > .disclosure-button {
> .item.type-tree-element.prototype {
>     display: inline-block;
> 
>-    border: 1px solid hsla(0, 0%, 0%, 0.06);
>-    background-color: hsla(0, 0%, 0%, 0.03);
>+    /* Unusual order of values because of <webkit.org/b/192922>. */
>+    border: hsla(0, 0%, var(--foreground-lightness), 0.06) solid 1px;
>+    background-color: hsla(0, 0%, var(--foreground-lightness), 0.03);
>     border-radius: 3px;
> 
>     padding-bottom: 1px;
>@@ -98,7 +99,7 @@ body[dir=rtl] .item.type-tree-element.prototype {
> 
> .item.type-tree-element.prototype:hover,
> .item.type-tree-element.prototype:focus {
>-    border-color: hsla(0, 0%, 0%, 0.1);
>+    border-color: hsla(0, 0%, var(--foreground-lightness), 0.1);
> }
> 
> .item.type-tree-element.prototype + ol {
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css b/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css
>index bfa2ab0792b..e979d7b3a56 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css
>@@ -27,7 +27,7 @@
>     position: relative;
>     display: block;
> 
>-    color: black;
>+    color: var(--text-color);
>     font-family: -webkit-system-font, sans-serif;
>     font-size: 12px;
> }
>diff --git a/Source/WebInspectorUI/UserInterface/Views/Variables.css b/Source/WebInspectorUI/UserInterface/Views/Variables.css
>index 3c357fa12ee..d2b4f4b474a 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/Variables.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/Variables.css
>@@ -37,6 +37,9 @@
>     --text-color: black;
>     --text-color-active: black;
> 
>+    /* Dividers, separators, background fills */
>+    --text-color-quaternary: hsl(0, 0%, 85%);
>+
>     --background-color: white;
> 
>     --background-color-content: white;

Actions: View | Formatted Diff | Diff

Attachments on bug 192916: 357783 | 357784 | 357785 | 357799 | 357859 | 357904