WebKit Bugzilla
Attachment 357900 Details for
Bug 192961
: Remove unused NetworkProcessCreationParameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192961-20181220165552.patch (text/plain), 4.31 KB, created by
Alex Christensen
on 2018-12-20 16:55:53 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alex Christensen
Created:
2018-12-20 16:55:53 PST
Size:
4.31 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 239477) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,22 @@ >+2018-12-20 Alex Christensen <achristensen@webkit.org> >+ >+ Remove unused NetworkProcessCreationParameters >+ https://bugs.webkit.org/show_bug.cgi?id=192961 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ loadThrottleLatency isn't used since I replaced it with NetworkSessionCreationParameters.loadThrottleLatency in r238654 >+ presentingApplicationPID has no effect because that value is only used in the WebProcess in NetworkExtensionContentFilter::initialize >+ >+ * NetworkProcess/NetworkProcess.cpp: >+ (WebKit::NetworkProcess::initializeNetworkProcess): >+ * NetworkProcess/NetworkProcessCreationParameters.cpp: >+ (WebKit::NetworkProcessCreationParameters::encode const): >+ (WebKit::NetworkProcessCreationParameters::decode): >+ * NetworkProcess/NetworkProcessCreationParameters.h: >+ * UIProcess/WebProcessPool.cpp: >+ (WebKit::WebProcessPool::ensureNetworkProcess): >+ > 2018-12-20 Chris Dumez <cdumez@apple.com> > > Use Optional::hasValue() instead of Optional::has_value() >Index: Source/WebKit/NetworkProcess/NetworkProcess.cpp >=================================================================== >--- Source/WebKit/NetworkProcess/NetworkProcess.cpp (revision 239461) >+++ Source/WebKit/NetworkProcess/NetworkProcess.cpp (working copy) >@@ -275,7 +275,6 @@ void NetworkProcess::initializeNetworkPr > WTF::setProcessPrivileges({ ProcessPrivilege::CanAccessRawCookies, ProcessPrivilege::CanAccessCredentials }); > #endif > WebCore::NetworkStorageSession::permitProcessToUseCookieAPI(true); >- WebCore::setPresentingApplicationPID(parameters.presentingApplicationPID); > platformInitializeNetworkProcess(parameters); > > WTF::Thread::setCurrentThreadIsUserInitiated(); >Index: Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp >=================================================================== >--- Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp (revision 239461) >+++ Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp (working copy) >@@ -64,7 +64,6 @@ void NetworkProcessCreationParameters::e > encoder << shouldSuppressMemoryPressureHandler; > encoder << shouldUseTestingNetworkSession; > encoder << urlSchemesRegisteredForCustomProtocols; >- encoder << presentingApplicationPID; > #if PLATFORM(COCOA) > encoder << uiProcessBundleIdentifier; > encoder << uiProcessSDKVersion; >@@ -170,8 +169,6 @@ bool NetworkProcessCreationParameters::d > return false; > if (!decoder.decode(result.urlSchemesRegisteredForCustomProtocols)) > return false; >- if (!decoder.decode(result.presentingApplicationPID)) >- return false; > #if PLATFORM(COCOA) > if (!decoder.decode(result.uiProcessBundleIdentifier)) > return false; >Index: Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h >=================================================================== >--- Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h (revision 239461) >+++ Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h (working copy) >@@ -73,10 +73,8 @@ struct NetworkProcessCreationParameters > #endif > bool shouldSuppressMemoryPressureHandler { false }; > bool shouldUseTestingNetworkSession { false }; >- Seconds loadThrottleLatency; > > Vector<String> urlSchemesRegisteredForCustomProtocols; >- ProcessID presentingApplicationPID { 0 }; > > #if PLATFORM(COCOA) > String uiProcessBundleIdentifier; >Index: Source/WebKit/UIProcess/WebProcessPool.cpp >=================================================================== >--- Source/WebKit/UIProcess/WebProcessPool.cpp (revision 239461) >+++ Source/WebKit/UIProcess/WebProcessPool.cpp (working copy) >@@ -515,7 +515,6 @@ NetworkProcessProxy& WebProcessPool::ens > #endif > > parameters.shouldUseTestingNetworkSession = m_shouldUseTestingNetworkSession; >- parameters.presentingApplicationPID = m_configuration->presentingApplicationPID(); > > parameters.urlSchemesRegisteredAsSecure = copyToVector(m_schemesToRegisterAsSecure); > parameters.urlSchemesRegisteredAsBypassingContentSecurityPolicy = copyToVector(m_schemesToRegisterAsBypassingContentSecurityPolicy);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
aestes
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192961
: 357900