Attachment 357894 Details for Bug 192957 – Patch

[patch] Patch

bug-192957-20181220161349.patch (text/plain), 3.58 KB, created by Wenson Hsieh on 2018-12-20 16:13:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-12-20 16:13:49 PST

Size: 3.58 KB

patch

obsolete

>Subversion Revision: 239455
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 42a1dd952c8363878b25143a0266e7a2097bbb80..be69074a942cb07dbd258d9ad3acdad3af6e8533 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,25 @@
>+2018-12-20  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS] Some layout tests are failing after r239441
>+        https://bugs.webkit.org/show_bug.cgi?id=192957
>+        <rdar://problem/46781759>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix several failing layout tests after r239441.
>+
>+        * fast/events/ios/click-event-while-editing-node.html:
>+
>+        This test started failing after r239441 because it taps the bottom of the editable element, and then expects
>+        WebKit to scroll the web view up to reveal the touched location. This was exactly the bug that r239441 fixed, so
>+        we should just make this test no longer depend on the broken behavior.
>+
>+        * fast/forms/ios/focus-long-textarea-expected.txt:
>+        * fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt:
>+
>+        Rebaseline a couple of test expectations to account for the change in margin around the selection rect, in
>+        -[WKWebView _zoomToFocusRect:â¦:].
>+
> 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         [iOS] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/update-registration-with-type.https.html is a flaky failure
>diff --git a/LayoutTests/fast/events/ios/click-event-while-editing-node.html b/LayoutTests/fast/events/ios/click-event-while-editing-node.html
>index 4de09dc130657eca42b4abd63272b42ca92af8b2..f6b34e5dbe99fe4afa9cdd2051d6b74a0baa7326 100644
>--- a/LayoutTests/fast/events/ios/click-event-while-editing-node.html
>+++ b/LayoutTests/fast/events/ios/click-event-while-editing-node.html
>@@ -24,8 +24,8 @@ editable.addEventListener("click", function(){
> if (window.testRunner) {
>     testRunner.dumpAsText();
>     jsTestIsAsync = true;
>-    UIHelper.activateAndWaitForInputSessionAt(50, 300).then(() => {
>-        UIHelper.tapAt(50, 300).then(() => {
>+    UIHelper.activateAndWaitForInputSessionAt(50, 200).then(() => {
>+        UIHelper.tapAt(50, 200).then(() => {
>             shouldBeEqualToString("document.getElementById('clicks').textContent", `${clickCount}`);
>             finishJSTest();
>         });
>diff --git a/LayoutTests/fast/forms/ios/focus-long-textarea-expected.txt b/LayoutTests/fast/forms/ios/focus-long-textarea-expected.txt
>index c26e8e0e92d0ef5b49e139c52d0f5aaeec8148aa..cbc0ff444f37f36a9eaa69ffee230828fc2f0262 100644
>--- a/LayoutTests/fast/forms/ios/focus-long-textarea-expected.txt
>+++ b/LayoutTests/fast/forms/ios/focus-long-textarea-expected.txt
>@@ -3,4 +3,4 @@ Tests zooming into a tall textarea on tap.
> 
> tap location	{ x: 38.000, y: 664.000 }
> scale	1.455
>-visibleRect	{ left: 0.000, top: 506.294, width: 219.979, height: 376.713 }
>+visibleRect	{ left: 0.000, top: 498.045, width: 219.979, height: 376.713 }
>diff --git a/LayoutTests/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt b/LayoutTests/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt
>index 7e693100dbb1c8e0ea0606a1ebbe3ec106850ef0..d66b06b3ef594f8cec5664adb91dbc3e9163f2a2 100644
>--- a/LayoutTests/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt
>+++ b/LayoutTests/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt
>@@ -3,4 +3,4 @@ Tests zooming to an offset in a wide text input on tap.
> 
> tap location	{ x: 328.000, y: 862.000 }
> scale	1.455
>-visibleRect	{ left: 122.707, top: 776.803, width: 219.980, height: 376.715 }
>+visibleRect	{ left: 114.458, top: 776.803, width: 219.980, height: 376.715 }

Actions: View | Formatted Diff | Diff

Attachments on bug 192957: 357894