Attachment 357849 Details for Bug 165171 – Patch

[patch] Patch

bug-165171-20181220122155.patch (text/plain), 3.16 KB, created by Keith Miller on 2018-12-20 12:21:56 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2018-12-20 12:21:56 PST

Size: 3.16 KB

patch

obsolete

>Subversion Revision: 239460
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index d439e4be00ad606874f469978daaaa8cca32245c..442faace2581c0341c75cf4dc4bdf79b4e2b8efc 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-20  Keith Miller  <keith_miller@apple.com>
>+
>+        Add support for globalThis
>+        https://bugs.webkit.org/show_bug.cgi?id=165171
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch adds spport for the globalThis property on the global
>+        object. The globalThis property spec is in stage three and is
>+        quite simple. For reference: http://tc39.github.io/proposal-global/
>+
>+        * runtime/JSGlobalObject.cpp:
>+
> 2018-12-20  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         ITMLKit Inspector: Elements tab does not show DOM Tree
>diff --git a/Source/JavaScriptCore/runtime/JSGlobalObject.cpp b/Source/JavaScriptCore/runtime/JSGlobalObject.cpp
>index a4fb84ccdef3c47a03d20e0e200f7776db0e3999..e86e82cfc6621c2a3493079bf8a429e64f58510d 100644
>--- a/Source/JavaScriptCore/runtime/JSGlobalObject.cpp
>+++ b/Source/JavaScriptCore/runtime/JSGlobalObject.cpp
>@@ -302,6 +302,7 @@ const GlobalObjectMethodTable JSGlobalObject::s_globalObjectMethodTable = {
>   encodeURI             globalFuncEncodeURI                          DontEnum|Function 1
>   encodeURIComponent    globalFuncEncodeURIComponent                 DontEnum|Function 1
>   EvalError             JSGlobalObject::m_evalErrorConstructor       DontEnum|CellProperty
>+  globalThis            JSGlobalObject::m_globalThis                 DontEnum|CellProperty
>   ReferenceError        JSGlobalObject::m_referenceErrorConstructor  DontEnum|CellProperty
>   SyntaxError           JSGlobalObject::m_syntaxErrorConstructor     DontEnum|CellProperty
>   URIError              JSGlobalObject::m_URIErrorConstructor        DontEnum|CellProperty
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index d4fb2a194a385e575dd5a974158719f020f56046..4cd8dbb0ff341ee90907d12a30eb08b755b92d02 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-12-20  Keith Miller  <keith_miller@apple.com>
>+
>+        Add support for globalThis
>+        https://bugs.webkit.org/show_bug.cgi?id=165171
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * test262/config.yaml:
>+
> 2018-12-19  Keith Miller  <keith_miller@apple.com>
> 
>         Update test262 configuration to not run tests dependent on ICU version.
>diff --git a/JSTests/test262/config.yaml b/JSTests/test262/config.yaml
>index 91c7dcb52de28218ff61ce83f5b18d3f0ba51b00..0bf6d95438efba76a2faf9ab68ac9d6465b3140e 100644
>--- a/JSTests/test262/config.yaml
>+++ b/JSTests/test262/config.yaml
>@@ -48,10 +48,6 @@ skip:
>     # https://bugs.webkit.org/show_bug.cgi?id=186691
>     - test/built-ins/Reflect/ownKeys/return-on-corresponding-order-large-index.js
> 
>-    # https://bugs.webkit.org/show_bug.cgi?id=186785
>-    - test/built-ins/global/global-object.js
>-    - test/built-ins/global/property-descriptor.js
>-
>     # https://bugs.webkit.org/show_bug.cgi?id=192920
>     - test/intl402/PluralRules/prototype/resolvedOptions/order.js
>     - test/intl402/PluralRules/prototype/resolvedOptions/pluralCategories.js

Actions: View | Formatted Diff | Diff

Attachments on bug 165171: 295668 | 295677 | 295680 | 295682 | 295703 | 297576 | 357848 | 357849 | 357852