Attachment 357824 Details for Bug 192918 – Patch

[patch] Patch

bug-192918-20181220104814.patch (text/plain), 2.02 KB, created by Devin Rousso on 2018-12-20 09:48:15 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-12-20 09:48:15 PST

Size: 2.02 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b464cca872adb4c7d9ec8de955bcd3ab2d9a6637..81ced79483a2f53e5e8b990202d182a27bddfccf 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-12-20  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Audits: don't cache default audits
>+        https://bugs.webkit.org/show_bug.cgi?id=192918
>+        <rdar://problem/46626543>
>+
>+        Reviewed by Brian Burg.
>+
>+        Instead of adding the default audits to the "audits" `WI.ObjectStore`, which preserves them
>+        across WebInspector sessions, load them every time WebInspector is opened (unless there are
>+        existing audits) so that the localized strings are able to respond to locale changes.
>+
>+        * UserInterface/Controllers/AuditManager.js:
>+        (WI.AuditManager.prototype.removeTest):
>+        (WI.AuditManager.prototype.addDefaultTestsIfNeeded):
>+
> 2018-12-19  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Audit: fix descriptions for default tests
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js b/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js
>index 3f727f3ab83e1a9572212eb2904a164aa37f25ca..7684b4d9601f445b1397f326b824a15a24b42ef0 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js
>@@ -172,7 +172,8 @@ WI.AuditManager = class AuditManager extends WI.Object
> 
>         this.dispatchEventToListeners(WI.AuditManager.Event.TestRemoved, {test});
> 
>-        WI.objectStores.audits.deleteObject(test);
>+        if (!test.__default)
>+            WI.objectStores.audits.deleteObject(test);
>     }
> 
>     // Private
>@@ -253,8 +254,8 @@ WI.AuditManager = class AuditManager extends WI.Object
>         ];
> 
>         for (let test of defaultTests) {
>+            test.__default = true;
>             this._addTest(test);
>-            WI.objectStores.audits.addObject(test);
>         }
>     }
> };

Actions: View | Formatted Diff | Diff

Attachments on bug 192918: 357788 | 357824