Attachment 357789 Details for Bug 192887 – Patch

[patch] Patch

bug-192887-20181219235746.patch (text/plain), 4.52 KB, created by Devin Rousso on 2018-12-19 22:57:47 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-12-19 22:57:47 PST

Size: 4.52 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b464cca872adb4c7d9ec8de955bcd3ab2d9a6637..904be0f3de0ae3aa0e7434c381a29475c560e399 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,24 @@
>+2018-12-19  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Dark Mode: unreadable background color for tables containing object previews
>+        https://bugs.webkit.org/show_bug.cgi?id=192887
>+        <rdar://problem/46855270>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/LogContentView.css:
>+        (.console-messages:focus .console-item .data-grid tr.selected td:not(:last-child)): Added.
>+        (@media (prefers-dark-interface) .console-item .data-grid tr.selected): Added.
>+        (@media (prefers-dark-interface) .console-messages:focus .console-item.selected .data-grid tr.selected): Added.
>+        (@media (prefers-dark-interface) .console-messages:focus .console-item .data-grid tr.selected td:not(:last-child)): Added.
>+
>+        * UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
>+        (.content-view.indexed-database-object-store > .data-grid tr.selected):
>+        (.content-view.indexed-database-object-store > .data-grid:focus tr.selected): Added.
>+        (@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid tr.selected): Added.
>+        (@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid:focus tr.selected): Added.
>+        (@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid:focus tr.selected td:not(:last-child)): Added.
>+
> 2018-12-19  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Audit: fix descriptions for default tests
>diff --git a/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.css b/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.css
>index 6bfc3a1be356c14b08eb8c6d6101f5af4b3743c4..2c663853f10c5a23c989686a12209e15baba18f0 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.css
>@@ -32,6 +32,10 @@
> }
> 
> .content-view.indexed-database-object-store > .data-grid tr.selected {
>+    background-color: hsl(210, 0%, 90%) !important;
>+}
>+
>+.content-view.indexed-database-object-store > .data-grid:focus tr.selected {
>     background-color: hsl(210, 90%, 90%) !important;
> }
> 
>@@ -43,3 +47,17 @@
>  /* The line-height inside a data-grid is 17px instead of 13px, this will center vertically on the top line. */
>     top: 2px;
> }
>+
>+@media (prefers-dark-interface) {
>+    .content-view.indexed-database-object-store > .data-grid tr.selected {
>+        background-color: hsl(210, 0%, 30%) !important;
>+    }
>+
>+    .content-view.indexed-database-object-store > .data-grid:focus tr.selected {
>+        background-color: hsl(210, 90%, 30%) !important;
>+    }
>+
>+    .content-view.indexed-database-object-store > .data-grid:focus tr.selected td:not(:last-child) {
>+        border-right-color: hsl(210, 70%, 25%);
>+    }
>+}
>diff --git a/Source/WebInspectorUI/UserInterface/Views/LogContentView.css b/Source/WebInspectorUI/UserInterface/Views/LogContentView.css
>index d3d5368bbd47c366d1bc2f93a13c2f8cd1626d4a..3108453dede02613116c07945c2eabc6d641229f 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/LogContentView.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/LogContentView.css
>@@ -134,6 +134,10 @@ body[dir=rtl] .log-scope-bar > li.unread::before {
>     background-color: hsl(210, 0%, 90%) !important;
> }
> 
>+.console-messages:focus .console-item .data-grid tr.selected td:not(:last-child) {
>+    border-right-color: hsl(210, 70%, 75%);
>+}
>+
> .console-messages:focus .console-item.selected {
>     background-color: hsl(210, 98%, 96%);
>     border-color: hsl(210, 90%, 93%);
>@@ -259,6 +263,18 @@ body[dir=rtl] .console-group-title::before {
>         border-top-color: var(--console-message-separator);
>     }
> 
>+    .console-item .data-grid tr.selected {
>+        background-color: hsl(210, 0%, 35%) !important;
>+    }
>+
>+    .console-messages:focus .console-item.selected .data-grid tr.selected {
>+        background-color: hsl(210, 90%, 35%) !important;
>+    }
>+
>+    .console-messages:focus .console-item .data-grid tr.selected td:not(:last-child) {
>+        border-right-color: hsl(210, 70%, 25%);
>+    }
>+
>     .console-messages {
>         --background-color-selected: hsl(233, 30%, 30%);
>         --border-color-selected: hsl(224, 30%, 35%);

Actions: View | Formatted Diff | Diff

Attachments on bug 192887: 357757 | 357758 | 357789