Attachment 357774 Details for Bug 192913 – Patch

[patch] Patch

bug-192913-20181219230346.patch (text/plain), 2.00 KB, created by Michael Catanzaro on 2018-12-19 21:03:47 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2018-12-19 21:03:47 PST

Size: 2.00 KB

patch

obsolete

>Subversion Revision: 239428
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index d069393c3432179af7494fd45c965f0e1e9adffe..3ade27112c6254e075748982dbfb75fdf5adb77a 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        UserMedia test should use WKPageNavigationClient
>+        https://bugs.webkit.org/show_bug.cgi?id=192913
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The test currently uses the deprecated WKPageLoaderClient. It should use
>+        WKPageNavigationClient instead, which provides the same callback under a similar name.
>+
>+        * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
>+        (TestWebKitAPI::TEST):
>+
> 2018-12-19  Chris Dumez  <cdumez@apple.com>
> 
>         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
>diff --git a/Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp b/Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp
>index 2f0cbe203b92d881dc1855069d30e70ccdd321cf..91c27863b2a61f8917760e916de2d9df99c66d96 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp
>@@ -132,11 +132,11 @@ TEST(WebKit, OnDeviceChangeCrash)
>     // Load a second page in same process.
>     PlatformWebView webView2(context.get(), pageGroup.get());
>     WKPageSetPageUIClient(webView2.page(), &uiClient.base);
>-    WKPageLoaderClientV0 loaderClient;
>-    memset(&loaderClient, 0, sizeof(loaderClient));
>-    loaderClient.base.version = 0;
>-    loaderClient.processDidCrash = didCrashCallback;
>-    WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base);
>+    WKPageNavigationClientV0 navigationClient;
>+    memset(&navigationClient, 0, sizeof(navigationClient));
>+    navigationClient.base.version = 0;
>+    navigationClient.webProcessDidCrash = didCrashCallback;
>+    WKPageSetPageNavigationClient(webView2.page(), &navigationClient.base);
> 
>     wasPrompted = false;
>     url = adoptWK(Util::createURLForResource("getUserMedia", "html"));

Actions: View | Formatted Diff | Diff

Attachments on bug 192913: 357774