Attachment 357753 Details for Bug 192899 – Patch

[patch] Patch

bug-192899-20181219164243.patch (text/plain), 1.47 KB, created by Tim Horton on 2018-12-19 16:42:44 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2018-12-19 16:42:44 PST

Size: 1.47 KB

patch

obsolete

>Subversion Revision: 239402
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index d7e45efb8847aaac053ee8c0f6096ea5191f21d1..78efe773f3b6f0ef9716f74d0eaa8c164a96bf68 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-12-19  Tim Horton  <timothy_horton@apple.com>
>+
>+        Use delegate instead of drawingDelegate in WKDrawingView
>+        https://bugs.webkit.org/show_bug.cgi?id=192899
>+        <rdar://problem/46733339>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ios/WKDrawingView.mm:
>+        (-[WKDrawingView initWithEmbeddedViewID:webPageProxy:]):
>+        Do the dance.
>+
> 2018-12-19  Tim Horton  <timothy_horton@apple.com>
> 
>         UI process crash when focusing an editable image
>diff --git a/Source/WebKit/UIProcess/ios/WKDrawingView.mm b/Source/WebKit/UIProcess/ios/WKDrawingView.mm
>index 885fd97856486bef6bc9a684ece7f578e74ba74a..ce07d48796202a7dd6b3cfbe161f93186b3252a0 100644
>--- a/Source/WebKit/UIProcess/ios/WKDrawingView.mm
>+++ b/Source/WebKit/UIProcess/ios/WKDrawingView.mm
>@@ -60,10 +60,7 @@ - (instancetype)initWithEmbeddedViewID:(WebCore::GraphicsLayer::EmbeddedViewID)e
>     [_pencilView setFingerDrawingEnabled:NO];
>     [_pencilView setUserInteractionEnabled:YES];
>     [_pencilView setOpaque:NO];
>-
>-    ALLOW_DEPRECATED_DECLARATIONS_BEGIN
>-    [_pencilView setDrawingDelegate:self];
>-    ALLOW_DEPRECATED_DECLARATIONS_END
>+    [_pencilView setDelegate:self];
> 
>     [self addSubview:_pencilView.get()];
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192899: 357753