Attachment 357751 Details for Bug 192896 – Patch

[patch] Patch

bug-192896-20181219163442.patch (text/plain), 1.59 KB, created by Jer Noble on 2018-12-19 16:34:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-12-19 16:34:43 PST

Size: 1.59 KB

patch

obsolete

>Subversion Revision: 238907
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 235ffc81673ace33f08c31f62e71d0d8023d7046..29c3216203fb1da98357b4ab161700f9c7a19b60 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-19  Jer Noble  <jer.noble@apple.com>
>+
>+        Leak of MTAudioProcessingTap (304 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
>+        https://bugs.webkit.org/show_bug.cgi?id=192896
>+        <rdar://46732186>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
>+        (WebCore::AudioSourceProviderAVFObjC::initCallback):
>+
> 2018-12-18  Jer Noble  <jer.noble@apple.com>
> 
>         [WebKitLegacy] Media playback pauses on scroll
>diff --git a/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm b/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm
>index 605d87337f70ae2ffc219d30654e8b231fa55518..481ea368e9803641e9b557987db95cbf4c490c80 100644
>--- a/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm
>+++ b/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm
>@@ -237,7 +237,7 @@ void AudioSourceProviderAVFObjC::initCallback(MTAudioProcessingTapRef tap, void*
> {
>     ASSERT(tap);
>     AudioSourceProviderAVFObjC* _this = static_cast<AudioSourceProviderAVFObjC*>(clientInfo);
>-    _this->m_tap = tap;
>+    _this->m_tap = adoptCF(tap);
>     _this->m_tapStorage = new TapStorage(_this);
>     _this->init(clientInfo, tapStorageOut);
>     *tapStorageOut = _this->m_tapStorage;

Actions: View | Formatted Diff | Diff

Attachments on bug 192896: 357751