Attachment 357750 Details for Bug 192784 – Patch

[patch] Patch

patch.txt (text/plain), 1.46 KB, created by Nikita Vasilyev on 2018-12-19 16:32:00 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2018-12-19 16:32:00 PST

Size: 1.46 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 9152ad45a76..0cbb7534e4b 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-19  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: shift-clicking a color-swatch to change formats starts editing the color
>+        https://bugs.webkit.org/show_bug.cgi?id=192784
>+        <rdar://problem/46801028>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SpreadsheetStyleProperty.js:
>+        (WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):
>+
> 2018-12-15  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: toggling selected properties may cause data corruption
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>index 9ae9fa9112f..2dde4e00ba7 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>@@ -481,7 +481,7 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
> 
>         // Prevent the value from editing when clicking on the swatch.
>         swatch.element.addEventListener("click", (event) => {
>-            if (this._swatchActive)
>+            if (this._swatchActive || event.shiftKey)
>                 event.stop();
>         });
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192784: 357750 | 357752