Attachment 357716 Details for Bug 192871 – Patch

[patch] Patch

bug-192871-20181219135030.patch (text/plain), 1.81 KB, created by Matt Baker on 2018-12-19 13:50:31 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2018-12-19 13:50:31 PST

Size: 1.81 KB

patch

obsolete

>Subversion Revision: 239225
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 84b773c202811041f1f198e7e697b367b0cb804e..27aad014a842d32b9472d2851b8425c97fa0ba32 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-12-19  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: Elements tab: arrow key after undoing a DOM node delete selects the wrong element
>+        https://bugs.webkit.org/show_bug.cgi?id=192871
>+        <rdar://problem/46849060>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Undoing a DOM node removal reinserts the node into the DOMTreeOutline.
>+        When the reinserted node precedes the selected node in the tree, the
>+        SelectionController should update `_lastSelectedIndex`.
>+
>+        * UserInterface/Controllers/SelectionController.js:
>+        (WI.SelectionController.prototype.didInsertItem):
>+
> 2018-12-13  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: remove DOM.BackendNodeId and associated commands/events
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js b/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js
>index 7066a3dfbf3769030a911bbecb5613e01045f421..b65f9f031f7c5e55277f554052245081eb526d66 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js
>@@ -212,6 +212,11 @@ WI.SelectionController = class SelectionController extends WI.Object
> 
>             current = this._selectedIndexes.indexLessThan(current);
>         }
>+
>+        if (this._lastSelectedIndex >= index)
>+            this._lastSelectedIndex += 1;
>+        if (this._shiftAnchorIndex >= index)
>+            this._shiftAnchorIndex += 1;
>     }
> 
>     didRemoveItems(indexes)

Actions: View | Formatted Diff | Diff

Attachments on bug 192871: 357716 | 357748