WebKit Bugzilla
Attachment 357707 Details for
Bug 192869
: Remove RTCRtpTransceiver.setDirection
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192869-20181219120927.patch (text/plain), 3.03 KB, created by
youenn fablet
on 2018-12-19 12:09:30 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
youenn fablet
Created:
2018-12-19 12:09:30 PST
Size:
3.03 KB
patch
obsolete
>Subversion Revision: 239282 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 180f78199d76c3090c8bea0d8a27f7b5fbe1598a..aebb1145063af5d82a1673e351520e709956e2a1 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,14 @@ >+2018-12-19 Youenn Fablet <youenn@apple.com> >+ >+ Remove RTCRtpTransceiver.setDirection >+ https://bugs.webkit.org/show_bug.cgi?id=192869 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Covered by rebased test. >+ >+ * Modules/mediastream/RTCRtpTransceiver.idl: >+ > 2018-12-17 Zalan Bujtas <zalan@apple.com> > > Unreviewed build fix. >diff --git a/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl b/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl >index cc640f42987dbcdc1efff03b44df766ba73399a0..ef59b0225aa354be72cd5913d165658b28b9c216 100644 >--- a/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl >+++ b/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl >@@ -41,8 +41,6 @@ typedef RTCRtpTransceiverDirection RtpTransceiverDirection; > readonly attribute boolean stopped; > attribute RtpTransceiverDirection direction; > [EnabledAtRuntime=WebRTCUnifiedPlan] readonly attribute RTCRtpTransceiverDirection? currentDirection; >- // FIXME: Remove setDirection >- void setDirection(RtpTransceiverDirection direction); > void stop(); > // FIXME 169662: missing setCodecPreferences > }; >diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog >index 46260f5754da65c8b3f93aee763d506f31cdbfa2..78aac78b309596e103b46c1d4b38105272215461 100644 >--- a/LayoutTests/imported/w3c/ChangeLog >+++ b/LayoutTests/imported/w3c/ChangeLog >@@ -1,3 +1,12 @@ >+2018-12-19 Youenn Fablet <youenn@apple.com> >+ >+ Remove RTCRtpTransceiver.setDirection >+ https://bugs.webkit.org/show_bug.cgi?id=192869 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * web-platform-tests/webrtc/historical-expected.txt: >+ > 2018-12-14 Youenn Fablet <youenn@apple.com> > > getSenders/getReceivers() should not return closed transceiver senders/receivers >diff --git a/LayoutTests/imported/w3c/web-platform-tests/webrtc/historical-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/webrtc/historical-expected.txt >index 543897c383415bdfc231a0c2547793b6b880c8a7..c8c89845b899514d8e5963ec55f1023060c3c246 100644 >--- a/LayoutTests/imported/w3c/web-platform-tests/webrtc/historical-expected.txt >+++ b/LayoutTests/imported/w3c/web-platform-tests/webrtc/historical-expected.txt >@@ -9,7 +9,7 @@ PASS RTCPeerConnection member onaddstream should not exist > PASS RTCPeerConnection member onremovestream should not exist > PASS RTCPeerConnection member removeStream should not exist > PASS RTCPeerConnection member updateIce should not exist >-FAIL RTCRtpTransceiver member setDirection should not exist assert_false: expected false got true >+PASS RTCRtpTransceiver member setDirection should not exist > PASS DataChannel interface should not exist > PASS mozRTCIceCandidate interface should not exist > PASS mozRTCPeerConnection interface should not exist
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192869
: 357707