Attachment 357704 Details for Bug 192866 – Patch

[patch] Patch

bug-192866-20181219115808.patch (text/plain), 1.43 KB, created by youenn fablet on 2018-12-19 11:58:12 PST

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-12-19 11:58:12 PST

Size: 1.43 KB

patch

obsolete

>Subversion Revision: 239282
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 746ea55189f93f259494989a4a9b3be8c83904ae..53ce9ee0101d2e035dc0779de4a6545dbcb73263 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-12-19  Youenn Fablet  <youenn@apple.com>
>+
>+        [ MacOS iOS ] Layout Test webrtc/no-port-zero-in-upd-candidates.html is flaky timeout
>+        https://bugs.webkit.org/show_bug.cgi?id=192866
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * webrtc/no-port-zero-in-upd-candidates.html:
>+        Add some more logging in the test in case of time out.
>+
> 2018-12-18  Youenn Fablet  <youenn@apple.com>
> 
>         Make fast/frames/detached-frame-property.html testharness-based
>diff --git a/LayoutTests/webrtc/no-port-zero-in-upd-candidates.html b/LayoutTests/webrtc/no-port-zero-in-upd-candidates.html
>index 54d5411c59e43c7865813bf0b832332d3a44cd16..661e8e5d266a2a977762c13157589b68606e214c 100644
>--- a/LayoutTests/webrtc/no-port-zero-in-upd-candidates.html
>+++ b/LayoutTests/webrtc/no-port-zero-in-upd-candidates.html
>@@ -12,6 +12,9 @@ function gatherCandidates(pc)
> {
>     var candidates = [];
>     return new Promise((resolve, reject) => {
>+        setTimeout(() => {
>+            reject("gathering did time out with " + candidates.length + " candidates");
>+        }, 10000);
>         pc.onicecandidate = (event) => {
>             if (event.candidate === null) {
>                 resolve(candidates);

Actions: View | Formatted Diff | Diff

Attachments on bug 192866: 357704