Attachment 357680 Details for Bug 192854 – Patch

[patch] Patch

bug-192854-20181219181438.patch (text/plain), 1.25 KB, created by Claudio Saavedra on 2018-12-19 08:14:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Claudio Saavedra

Created: 2018-12-19 08:14:40 PST

Size: 1.25 KB

patch

obsolete

>Subversion Revision: 239378
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index e6746ddceac50203acf3a2f5daa4ab8011e7b175..3145ecec5e292c631939cd5f04bd9de6b3e0bf49 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-19  Claudio Saavedra  <csaavedra@igalia.com>
>+
>+        ContentExtensions: DFANode.cpp:66:44: error: narrowing conversion of '-1' from 'int' to 'char' inside { }
>+        https://bugs.webkit.org/show_bug.cgi?id=192854
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * contentextensions/DFANode.h: Define CharRange's chars as signed
>+
> 2018-12-19  Alicia Boya GarcÃa  <aboya@igalia.com>
> 
>         [MSE] Remove unused method: stopAskingForMoreSamples()
>diff --git a/Source/WebCore/contentextensions/DFANode.h b/Source/WebCore/contentextensions/DFANode.h
>index 3fbc8480bf667c5a056dc267e250c8e6b17ace9a..7e607535349e41b408895dc2d5f37ff93e530613 100644
>--- a/Source/WebCore/contentextensions/DFANode.h
>+++ b/Source/WebCore/contentextensions/DFANode.h
>@@ -38,8 +38,8 @@ namespace ContentExtensions {
> struct DFA;
> 
> struct CharRange {
>-    char first;
>-    char last;
>+    signed char first;
>+    signed char last;
>     unsigned size() const { return last - first + 1; }
> };
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192854: 357680 | 357681