Attachment 357660 Details for Bug 192845 – Patch

[patch] Patch

patch.txt (text/plain), 1.68 KB, created by Nikita Vasilyev on 2018-12-18 23:09:16 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2018-12-18 23:09:16 PST

Size: 1.68 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index af75c50aec8..bfe23093bd9 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-12-18  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: column sort controls in Layers tab sidebar don't render correctly in dark mode
>+        https://bugs.webkit.org/show_bug.cgi?id=192845
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/DataGrid.css:
>+        (@media (prefers-dark-interface)):
>+        (.data-grid th.sortable:active):
>+        Drive-by: replace obnoxiously light background of the pressed header with a more subtle gray.
>+
>+        (.data-grid th.sort-ascending > div:first-child::after, .data-grid th.sort-descending > div:first-child::after):
>+        Invert colors of the arrow glyph.
>+
> 2018-12-18  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Computed: make UI more usable when the panel is narrow
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DataGrid.css b/Source/WebInspectorUI/UserInterface/Views/DataGrid.css
>index a9e7e304889..f963dc42e9c 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DataGrid.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/DataGrid.css
>@@ -446,4 +446,13 @@ body:not(.window-inactive, .window-docked-inactive) .data-grid:focus tr.editable
>         color: var(--text-color-secondary);
>         background-color: unset;
>     }
>+
>+    .data-grid th.sortable:active {
>+        background-color: hsl(0, 0%, 40%);
>+    }
>+
>+    .data-grid th.sort-ascending > div:first-child::after,
>+    .data-grid th.sort-descending > div:first-child::after {
>+        filter: invert();
>+    }
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 192845: 357659 | 357660 | 357661