Attachment 357628 Details for Bug 192837 – Patch

[patch] Patch

bug-192837-20181218160428.patch (text/plain), 1.29 KB, created by Alex Christensen on 2018-12-18 16:04:29 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-12-18 16:04:29 PST

Size: 1.29 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 239360)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-12-18  Alex Christensen  <achristensen@webkit.org>
>+
>+        REGRESSION(r239134) iOS safe browsing warning unable to show details
>+        https://bugs.webkit.org/show_bug.cgi?id=192837
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
>+        (-[WKSafeBrowsingWarning addContent]):
>+        I added a call to updateContentSize in r239134 which was necessary on watchOS but it makes iOS unable to show the details.
>+
> 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
> 
>         Clean up IndexedDB files between tests
>Index: Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm
>===================================================================
>--- Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm	(revision 239338)
>+++ Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm	(working copy)
>@@ -359,7 +359,7 @@ - (void)addContent
>             [[goBack.bottomAnchor anchorWithOffsetToAnchor:box.bottomAnchor] constraintEqualToConstant:marginSize],
>         ]];
>     }
>-#if !PLATFORM(MAC)
>+#if PLATFORM(WATCHOS)
>     [self updateContentSize];
> #endif
> #endif

Actions: View | Formatted Diff | Diff

Attachments on bug 192837: 357628 | 357637