WebKit Bugzilla
Attachment 357623 Details for
Bug 192832
: Error message for `-x ** y` contains a typo.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-192832-20181218152741.patch (text/plain), 4.65 KB, created by
Ross Kirsling
on 2018-12-18 15:27:41 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Ross Kirsling
Created:
2018-12-18 15:27:41 PST
Size:
4.65 KB
patch
obsolete
>Subversion Revision: 239356 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index fc9bd589c15d00c1771000ca30712b9f2c9f4ed2..c323b235f3ca7fad9b9ff9a9d83ae944e942ff59 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,14 @@ >+2018-12-18 Ross Kirsling <ross.kirsling@sony.com> >+ >+ Error message for `-x ** y` contains a typo. >+ https://bugs.webkit.org/show_bug.cgi?id=192832 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * parser/Parser.cpp: >+ (JSC::Parser<LexerType>::parseBinaryExpression): >+ Correct spelling in error message: "amiguous" -> "ambiguous" >+ > 2018-12-18 Mark Lam <mark.lam@apple.com> > > JSON.stringify() should throw OOM on StringBuilder overflows. >diff --git a/Source/JavaScriptCore/parser/Parser.cpp b/Source/JavaScriptCore/parser/Parser.cpp >index 6faedb5bad8dc1c346366f5fe01a46118b168b5c..3db844ebbe9fd6b67c5b1e0db9074e3e05fec7a4 100644 >--- a/Source/JavaScriptCore/parser/Parser.cpp >+++ b/Source/JavaScriptCore/parser/Parser.cpp >@@ -3886,7 +3886,7 @@ template <class TreeBuilder> TreeExpression Parser<LexerType>::parseBinaryExpres > // Check this. > // If the binary operator <> has higher precedence than one of "**", this check does not work. > // But it's OK for ** because the operator "**" has the highest operator precedence in the binary operators. >- failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Amiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression"); >+ failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Ambiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression"); > > int precedence = isBinaryOperator(m_token.m_type); > if (!precedence) >diff --git a/JSTests/ChakraCore/test/UnitTestFramework/UnitTestFramework.js b/JSTests/ChakraCore/test/UnitTestFramework/UnitTestFramework.js >index ca645e77e627d61a0e66f8f66144a22c59eafd83..d40d253eb091594e9904074c76494cd12cd47032 100644 >--- a/JSTests/ChakraCore/test/UnitTestFramework/UnitTestFramework.js >+++ b/JSTests/ChakraCore/test/UnitTestFramework/UnitTestFramework.js >@@ -366,7 +366,7 @@ var assert = function assert() { > }, > { > regexp: /Invalid unary operator on the left hand side of exponentiation \(\*\*\) operator/, >- replStr: "Unexpected token '**'. Amiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression." >+ replStr: "Unexpected token '**'. Ambiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression." > }, > { > regexp: /Assignment to read-only properties is not allowed in strict mode/, >diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog >index e71a84520ebb2f5e40fcc07af88d6ea42e798cc3..c4b4f3435d23fa942317d76963d6c41ca63f99e9 100644 >--- a/JSTests/ChangeLog >+++ b/JSTests/ChangeLog >@@ -1,3 +1,16 @@ >+2018-12-18 Ross Kirsling <ross.kirsling@sony.com> >+ >+ Error message for `-x ** y` contains a typo. >+ https://bugs.webkit.org/show_bug.cgi?id=192832 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * ChakraCore/test/UnitTestFramework/UnitTestFramework.js: >+ (assert.assert.return.throws): >+ * stress/pow-expects-update-expression-on-lhs.js: >+ (throw.new.Error): >+ Update test expectations which match against the exact error message. >+ > 2018-12-18 Mark Lam <mark.lam@apple.com> > > JSON.stringify() should throw OOM on StringBuilder overflows. >diff --git a/JSTests/stress/pow-expects-update-expression-on-lhs.js b/JSTests/stress/pow-expects-update-expression-on-lhs.js >index cd4cd2eb41d946ae96c3312eaa38ba33a71cec80..c9390e897e913a3d171a8fd2995827cd8cf0d246 100644 >--- a/JSTests/stress/pow-expects-update-expression-on-lhs.js >+++ b/JSTests/stress/pow-expects-update-expression-on-lhs.js >@@ -38,7 +38,7 @@ function testSyntaxError(script, message) { > { > return ${token} a ** b; > } >- `, `SyntaxError: Unexpected token '**'. Amiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression.`); >+ `, `SyntaxError: Unexpected token '**'. Ambiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression.`); > } > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192832
:
357623
|
357654