Attachment 357622 Details for Bug 192061 – Part 4.

[patch] Part 4.

bug-192061-20181218152202.patch (text/plain), 1.83 KB, created by Jiewen Tan on 2018-12-18 15:22:03 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jiewen Tan

Created: 2018-12-18 15:22:03 PST

Size: 1.83 KB

patch

obsolete

>Subversion Revision: 239355
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 324e9086aaeb54aceca37b3bf51e2d758e598069..0f87a890041ca8f41f70b9e784c1ac1122ceaefc 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-12-18  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=192061
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part 4.
>+
>+        Add some additional temporary logging info to determine if the time out value passed to the timer is right.
>+        Once the bug is determined and fixed, we should remove all logging added in this patch.
>+
>+        * UIProcess/WebAuthentication/AuthenticatorManager.cpp:
>+        (WebKit::AuthenticatorManager::initTimeOutTimer):
>+
> 2018-12-18  Vivek Seth  <v_seth@apple.com>
> 
>         HTTPS Upgrade: Scripts / preprocessing necessary to create new database in future
>diff --git a/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp b/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
>index c1a6832edf3c1ae7bdd8997f08379ebc5c1877f4..7e9cf7f08ccbce5547b8389f8aa3276aa56e20fd 100644
>--- a/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
>+++ b/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
>@@ -226,7 +226,7 @@ void AuthenticatorManager::initTimeOutTimer(const std::optional<unsigned>& timeO
> 
>     unsigned timeOutInMsValue = std::min(maxTimeOutValue, timeOutInMs.value_or(maxTimeOutValue));
>     // FIXME(192061)
>-    LOG_ERROR("Start timer.");
>+    LOG_ERROR("Start timer. %d", timeOutInMsValue);
>     m_requestTimeOutTimer.startOneShot(Seconds::fromMilliseconds(timeOutInMsValue));
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192061: 356665 | 357284 | 357480 | 357622 | 357969 | 358635 | 358758 | 358844 | 358846 | 358851