Attachment 357616 Details for Bug 192820 – Patch

[patch] Patch

bug-192820-20181218145338.patch (text/plain), 3.02 KB, created by Eric Carlson on 2018-12-18 14:53:39 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2018-12-18 14:53:39 PST

Size: 3.02 KB

patch

obsolete

>Subversion Revision: 239329
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index f54952cb4fbe04e67129de96c27f609542524cae..d09540ff29afb333fc400b9a78575463f2b97cb4 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-12-18  Eric Carlson  <eric.carlson@apple.com>
>+
>+        [MediaStream] Force system camera/microphone TCC prompt if necessary
>+        https://bugs.webkit.org/show_bug.cgi?id=192820
>+        <rdar://problem/42680098>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/Platform.h: Define HAVE_AUTHORIZATION_STATUS_FOR_MEDIA_TYPE.
>+
> 2018-12-17  Chris Fleizach  <cfleizach@apple.com>
> 
>         Some builds are broken after r239262
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a196ae855ac757771a13f2e8ddc94d0a03e465c9..5ecafb29c77a1c90200231f16ad5fe7eb36bb422 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-12-18  Eric Carlson  <eric.carlson@apple.com>
>+
>+        [MediaStream] Force system camera/microphone TCC prompt if necessary
>+        https://bugs.webkit.org/show_bug.cgi?id=192820
>+        <rdar://problem/42680098>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/Cocoa/UIDelegate.mm:
>+        (WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest): Enable TCC check 
>+        and prompt on Mojave.
>+
> 2018-12-17  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
>diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h
>index b859f4a99ac520cf7047882eb2a4656d18f58141..c68b2aeca15b85ba5202e6581c5410bd529af3f7 100644
>--- a/Source/WTF/wtf/Platform.h
>+++ b/Source/WTF/wtf/Platform.h
>@@ -1462,3 +1462,7 @@
> #if PLATFORM(MAC)
> #define ENABLE_FULL_KEYBOARD_ACCESS 1
> #endif
>+
>+#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101400)
>+#define HAVE_AUTHORIZATION_STATUS_FOR_MEDIA_TYPE 1
>+#endif
>diff --git a/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm b/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
>index ce84a8884789735d1a132b1eb6ea6de2803a786d..0ed93086470a49b5cfed04608c01172b642a5df3 100644
>--- a/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
>+++ b/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
>@@ -55,7 +55,7 @@
> #import <wtf/BlockPtr.h>
> #import <wtf/URL.h>
> 
>-#if PLATFORM(IOS_FAMILY)
>+#if HAVE(AUTHORIZATION_STATUS_FOR_MEDIA_TYPE)
> #import <AVFoundation/AVCaptureDevice.h>
> #import <AVFoundation/AVMediaFormat.h>
> #import <wtf/SoftLinking.h>
>@@ -912,7 +912,7 @@ bool UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest(WebPageProx
>         return true;
>     }
> 
>-#if PLATFORM(IOS_FAMILY)
>+#if HAVE(AUTHORIZATION_STATUS_FOR_MEDIA_TYPE)
>     bool usingMockCaptureDevices = page.preferences().mockCaptureDevicesEnabled();
>     auto requestCameraAuthorization = makeBlockPtr([this, &frame, protectedRequest = makeRef(request), webView = RetainPtr<WKWebView>(m_uiDelegate.m_webView), usingMockCaptureDevices]() {
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192820: 357616