Attachment 357614 Details for Bug 192810 – Patch

[patch] Patch

file_192810.txt (text/plain), 3.10 KB, created by David Quesada on 2018-12-18 14:45:41 PST

(hide)

Description:

Filename:

MIME Type:

Creator: David Quesada

Created: 2018-12-18 14:45:41 PST

Size: 3.10 KB

patch

obsolete

>commit 58b6d9a6df468470d0deb0029b82d9f95f9128e8
>Author: David Quesada <david_quesada@apple.com>
>Date:   Tue Dec 18 14:44:44 2018 -0800
>
>    REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
>    https://bugs.webkit.org/show_bug.cgi?id=192810
>    <rdar://problem/46812536>
>    
>    Reviewed by NOBODY (OOPS!).
>    
>    * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
>    (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
>        After releasing our reference to the web view, wait until the next turn of the runloop
>        before checking that the originatingWebView has been zeroed, since the web view might
>        still be referenced in the autorelease pool. This _WKDownload unit test isn't about
>        testing general memory management of WKWebViews, only that _WKDownload does not retain
>        its web view via the 'originatingWebView' property.
>
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index cf5a6af1c5e..96c829458ba 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-12-18  David Quesada  <david_quesada@apple.com>
>+
>+        REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=192810
>+        <rdar://problem/46812536>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
>+        (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
>+            After releasing our reference to the web view, wait until the next turn of the runloop
>+            before checking that the originatingWebView has been zeroed, since the web view might
>+            still be referenced in the autorelease pool. This _WKDownload unit test isn't about
>+            testing general memory management of WKWebViews, only that _WKDownload does not retain
>+            its web view via the 'originatingWebView' property.
>+
> 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
> 
>         webkitpy: Ignore device type for test when using --force
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
>index dae0d2710c8..8068933bdd0 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
>@@ -41,6 +41,7 @@
> #import <WebKit/WKUIDelegatePrivate.h>
> #import <WebKit/WKWebView.h>
> #import <WebKit/WKWebViewConfiguration.h>
>+#import <wtf/MainThread.h>
> #import <wtf/RetainPtr.h>
> #import <wtf/text/WTFString.h>
> 
>@@ -253,13 +254,13 @@ - (instancetype)initWithWebView:(WKWebView *)webView
> 
> - (void)_downloadDidStart:(_WKDownload *)download
> {
>-    @autoreleasepool {
>-        EXPECT_EQ([download originatingWebView], _webView);
>-    }
>-
>+    EXPECT_EQ([download originatingWebView], _webView);
>     _webView = nullptr;
>-    EXPECT_NULL([download originatingWebView]);
>-    isDone = true;
>+
>+    WTF::callOnMainThread([retainedDownload = RetainPtr<_WKDownload> { download }] {
>+        EXPECT_NULL([retainedDownload originatingWebView]);
>+        isDone = true;
>+    });
> }
> 
> @end

Flags:

achristensen: review+
achristensen: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 192810: 357614 | 357621