Attachment 357612 Details for Bug 192792 – Patch

[patch] Patch

bug-192792-20181218142458.patch (text/plain), 22.07 KB, created by Jiewen Tan on 2018-12-18 14:24:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jiewen Tan

Created: 2018-12-18 14:24:59 PST

Size: 22.07 KB

patch

obsolete

>Subversion Revision: 239282
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 180f78199d76c3090c8bea0d8a27f7b5fbe1598a..2ce9a6d1bc689d6e3dfa9f1c7b92170f295ef328 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-12-17  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [WebAuthN] Add a runtime flag for local authenticator
>+        https://bugs.webkit.org/show_bug.cgi?id=192792
>+        <rdar://problem/46798738>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No tests.
>+
>+        This patch adds a runtime flag for local authenticator and removes ways to
>+        set the runtime flag for web authentication in LegacyWebKit.
>+
>+        * page/RuntimeEnabledFeatures.h:
>+        (WebCore::RuntimeEnabledFeatures::setWebAuthenticationLocalAuthenticatorEnabled):
>+        (WebCore::RuntimeEnabledFeatures::webAuthenticationLocalAuthenticatorEnabled const):
>+
> 2018-12-17  Zalan Bujtas  <zalan@apple.com>
> 
>         Unreviewed build fix.
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index cc9c4ab4fa4c7dca456962bff2591f4c082d317b..583bef4c7f991b4a231eeb5b2f40b366f2e86370 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-12-17  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [WebAuthN] Add a runtime flag for local authenticator
>+        https://bugs.webkit.org/show_bug.cgi?id=192792
>+        <rdar://problem/46798738>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferences.yaml:
>+        * UIProcess/API/C/WKPreferences.cpp:
>+        (WKPreferencesSetWebAuthenticationLocalAuthenticatorEnabled):
>+        (WKPreferencesGetWebAuthenticationLocalAuthenticatorEnabled):
>+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
>+        * UIProcess/WebAuthentication/Cocoa/LocalService.mm:
>+        (WebKit::LocalService::isAvailable):
>+
> 2018-12-17  Zan Dobersek  <zdobersek@igalia.com>
> 
>         Unreviewed WPE build fix after r239277.
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index 48ad40d35f456bafa45b566782527db9d43d444f..ae65c7eb49a07f756778431e6690c9d7908bbfca 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-12-17  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [WebAuthN] Add a runtime flag for local authenticator
>+        https://bugs.webkit.org/show_bug.cgi?id=192792
>+        <rdar://problem/46798738>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebView/WebPreferenceKeysPrivate.h:
>+        * WebView/WebPreferences.mm:
>+        (+[WebPreferences initialize]):
>+        (-[WebPreferences webAuthenticationEnabled]): Deleted.
>+        (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
>+        * WebView/WebPreferencesPrivate.h:
>+        * WebView/WebView.mm:
>+        (-[WebView _preferencesChanged:]):
>+
> 2018-12-17  Zalan Bujtas  <zalan@apple.com>
> 
>         Unreviewed build fix.
>diff --git a/Source/WebCore/page/RuntimeEnabledFeatures.h b/Source/WebCore/page/RuntimeEnabledFeatures.h
>index 2ddcc485e9e1694f6467180f82db18f0d190761a..114558efa65818dbf6b38dae4abc46a2fb3e31b6 100644
>--- a/Source/WebCore/page/RuntimeEnabledFeatures.h
>+++ b/Source/WebCore/page/RuntimeEnabledFeatures.h
>@@ -104,6 +104,9 @@ public:
>     void setWebAuthenticationEnabled(bool isEnabled) { m_isWebAuthenticationEnabled = isEnabled; }
>     bool webAuthenticationEnabled() const { return m_isWebAuthenticationEnabled; }
> 
>+    void setWebAuthenticationLocalAuthenticatorEnabled(bool isEnabled) { m_isWebAuthenticationLocalAuthenticatorEnabled = isEnabled; }
>+    bool webAuthenticationLocalAuthenticatorEnabled() const { return m_isWebAuthenticationLocalAuthenticatorEnabled; }
>+
>     void setIsSecureContextAttributeEnabled(bool isEnabled) { m_isSecureContextAttributeEnabled = isEnabled; }
>     bool isSecureContextAttributeEnabled() const { return m_isSecureContextAttributeEnabled; }
> 
>@@ -347,6 +350,7 @@ private:
>     bool m_isUserTimingEnabled { false };
>     bool m_isInteractiveFormValidationEnabled { false };
>     bool m_isWebAuthenticationEnabled { false };
>+    bool m_isWebAuthenticationLocalAuthenticatorEnabled { false };
>     bool m_isSecureContextAttributeEnabled { false };
>     bool m_isDisplayContentsEnabled { true };
>     bool m_isShadowDOMEnabled { true };
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 077bde35ea562ec343ece0cb5205ca9e1db1000e..64930b130285c40473be1075e74bfa2e2a1a8007 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -746,6 +746,14 @@ WebAuthenticationEnabled:
>   category: experimental
>   condition: ENABLE(WEB_AUTHN)
> 
>+WebAuthenticationLocalAuthenticatorEnabled:
>+  type: bool
>+  defaultValue: false
>+  humanReadableName: "Web Authentication Local Authenticator"
>+  humanReadableDescription: "Enable Web Authentication local authenticator support"
>+  webcoreBinding: RuntimeEnabledFeatures
>+  condition: ENABLE(WEB_AUTHN)
>+
> ModernMediaControlsEnabled:
>   type: bool
>   defaultValue: DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED
>diff --git a/Source/WebKit/UIProcess/API/C/WKPreferences.cpp b/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
>index 9bc94b477548b1f961b5f019f298416bd42a9450..3051330c0c6732395a3ebe5db820279fc158f381 100644
>--- a/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
>+++ b/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
>@@ -878,6 +878,16 @@ bool WKPreferencesGetWebAuthenticationEnabled(WKPreferencesRef preferencesRef)
>     return toImpl(preferencesRef)->webAuthenticationEnabled();
> }
> 
>+void WKPreferencesSetWebAuthenticationLocalAuthenticatorEnabled(WKPreferencesRef preferencesRef, bool flag)
>+{
>+    toImpl(preferencesRef)->setWebAuthenticationLocalAuthenticatorEnabled(flag);
>+}
>+
>+bool WKPreferencesGetWebAuthenticationLocalAuthenticatorEnabled(WKPreferencesRef preferencesRef)
>+{
>+    return toImpl(preferencesRef)->webAuthenticationLocalAuthenticatorEnabled();
>+}
>+
> void WKPreferencesSetInvisibleMediaAutoplayPermitted(WKPreferencesRef preferencesRef, bool flag)
> {
>     toImpl(preferencesRef)->setInvisibleAutoplayNotPermitted(!flag);
>diff --git a/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h b/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>index 3b31fa24ba047c19a6fffc38c5e9343b8511bccc..7c135d83942195756b7d67325d8b8168a9023c41 100644
>--- a/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>+++ b/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>@@ -520,6 +520,10 @@ WK_EXPORT bool WKPreferencesGetMediaPreloadingEnabled(WKPreferencesRef);
> WK_EXPORT void WKPreferencesSetWebAuthenticationEnabled(WKPreferencesRef, bool flag);
> WK_EXPORT bool WKPreferencesGetWebAuthenticationEnabled(WKPreferencesRef);
> 
>+// Defaults to false
>+WK_EXPORT void WKPreferencesSetWebAuthenticationLocalAuthenticatorEnabled(WKPreferencesRef, bool flag);
>+WK_EXPORT bool WKPreferencesGetWebAuthenticationLocalAuthenticatorEnabled(WKPreferencesRef);
>+
> // Defaults to true.
> WK_EXPORT void WKPreferencesSetInvisibleMediaAutoplayPermitted(WKPreferencesRef, bool flag);
> WK_EXPORT bool WKPreferencesGetInvisibleMediaAutoplayPermitted(WKPreferencesRef);
>diff --git a/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm b/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm
>index 02b63a6b50ddd5949cda87e154fbe2391a6b5c84..d4ff83f2a9bd41fa8cb658bf14d6a7d1162388e5 100644
>--- a/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm
>+++ b/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm
>@@ -30,6 +30,7 @@
> 
> #import "LocalAuthenticator.h"
> #import "LocalConnection.h"
>+#import <WebCore/RuntimeEnabledFeatures.h>
> 
> #import "LocalAuthenticationSoftLink.h"
> 
>@@ -46,6 +47,9 @@ bool LocalService::isAvailable()
> #if !PLATFORM(IOS_FAMILY)
>     return false;
> #else
>+    if (!RuntimeEnabledFeatures::sharedFeatures().webAuthenticationLocalAuthenticatorEnabled())
>+        return false;
>+
>     auto context = adoptNS([allocLAContextInstance() init]);
>     NSError *error = nil;
>     if (![context canEvaluatePolicy:LAPolicyDeviceOwnerAuthenticationWithBiometrics error:&error]) {
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>index b73f6cb6830430fa18124b678520a06c14a4cc80..090b8380687f02823524569cdf1a07c72e1d0fb7 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>@@ -190,7 +190,6 @@
> #define WebKitPeerConnectionEnabledPreferenceKey @"WebKitPeerConnectionEnabled"
> #define WebKitLinkPreloadEnabledPreferenceKey @"WebKitLinkPreloadEnabled"
> #define WebKitMediaPreloadingEnabledPreferenceKey @"WebKitMediaPreloadingEnabled"
>-#define WebKitWebAuthenticationEnabledPreferenceKey @"WebKitWebAuthenticationEnabled"
> #define WebKitMediaUserGestureInheritsFromDocument @"WebKitMediaUserGestureInheritsFromDocument"
> #define WebKitIsSecureContextAttributeEnabledPreferenceKey @"WebKitIsSecureContextAttributeEnabled"
> #define WebKitViewportFitEnabledPreferenceKey @"WebKitViewportFitEnabled"
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>index 7e1cfc1b1e29b46d6dbd1f33cb44c0b11591517a..22aa954cd61d01d4039796e9a12945380adbb49a 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>@@ -674,7 +674,6 @@ + (void)initialize
>         @YES, WebKitDisplayContentsEnabledPreferenceKey,
>         @NO, WebKitUserTimingEnabledPreferenceKey,
>         @NO, WebKitResourceTimingEnabledPreferenceKey,
>-        @NO, WebKitWebAuthenticationEnabledPreferenceKey,
>         @NO, WebKitMediaUserGestureInheritsFromDocument,
>         @NO, WebKitIsSecureContextAttributeEnabledPreferenceKey,
>         @YES, WebKitLegacyEncryptedMediaAPIEnabledKey,
>@@ -3197,16 +3196,6 @@ - (void)setResourceTimingEnabled:(BOOL)flag
>     [self _setBoolValue:flag forKey:WebKitResourceTimingEnabledPreferenceKey];
> }
> 
>-- (BOOL)webAuthenticationEnabled
>-{
>-    return [self _boolValueForKey:WebKitWebAuthenticationEnabledPreferenceKey];
>-}
>-
>-- (void)setWebAuthenticationEnabled:(BOOL)flag
>-{
>-    [self _setBoolValue:flag forKey:WebKitWebAuthenticationEnabledPreferenceKey];
>-}
>-
> - (BOOL)mediaUserGestureInheritsFromDocument
> {
>     return [self _boolValueForKey:WebKitMediaUserGestureInheritsFromDocument];
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>index 20b33429510785e706c1563331209661017a5e56..162ada1d6449f71aae288c9e1fe4a41a333a8e8f 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>@@ -570,9 +570,6 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification WEBKIT_DEPR
> - (void)setWebAnimationsCSSIntegrationEnabled:(BOOL)flag;
> - (BOOL)webAnimationsCSSIntegrationEnabled;
> 
>-- (void)setWebAuthenticationEnabled:(BOOL)flag;
>-- (BOOL)webAuthenticationEnabled;
>-
> - (void)setIntersectionObserverEnabled:(BOOL)flag;
> - (BOOL)intersectionObserverEnabled;
> 
>@@ -600,7 +597,6 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification WEBKIT_DEPR
> @property (nonatomic) BOOL userTimingEnabled;
> @property (nonatomic) BOOL resourceTimingEnabled;
> @property (nonatomic) BOOL linkPreloadEnabled;
>-@property (nonatomic) BOOL webAuthenticationEnabled;
> @property (nonatomic) BOOL mediaUserGestureInheritsFromDocument;
> @property (nonatomic) BOOL isSecureContextAttributeEnabled;
> @property (nonatomic) BOOL legacyEncryptedMediaAPIEnabled;
>diff --git a/Source/WebKitLegacy/mac/WebView/WebView.mm b/Source/WebKitLegacy/mac/WebView/WebView.mm
>index 5eb9575282c1b653dcbc9aa6a47ed70c05e7d5ef..4aec6ec561ca8a85df79cdb2ae6e1bf9647d26ff 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebView.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebView.mm
>@@ -3137,7 +3137,6 @@ - (void)_preferencesChanged:(WebPreferences *)preferences
>     RuntimeEnabledFeatures::sharedFeatures().setResourceTimingEnabled(preferences.resourceTimingEnabled);
>     RuntimeEnabledFeatures::sharedFeatures().setLinkPreloadEnabled(preferences.linkPreloadEnabled);
>     RuntimeEnabledFeatures::sharedFeatures().setMediaPreloadingEnabled(preferences.mediaPreloadingEnabled);
>-    RuntimeEnabledFeatures::sharedFeatures().setWebAuthenticationEnabled(preferences.webAuthenticationEnabled);
>     RuntimeEnabledFeatures::sharedFeatures().setIsSecureContextAttributeEnabled(preferences.isSecureContextAttributeEnabled);
>     RuntimeEnabledFeatures::sharedFeatures().setDirectoryUploadEnabled([preferences directoryUploadEnabled]);
>     RuntimeEnabledFeatures::sharedFeatures().setMenuItemElementEnabled([preferences menuItemElementEnabled]);
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index e7c0324a8cc02f13896c2d323169ed189ed6796a..92df19303f98d55ec4ca4a9992850092d9928be1 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-12-17  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [WebAuthN] Add a runtime flag for local authenticator
>+        https://bugs.webkit.org/show_bug.cgi?id=192792
>+        <rdar://problem/46798738>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * DumpRenderTree/TestOptions.cpp:
>+        (TestOptions::TestOptions):
>+        * DumpRenderTree/TestOptions.h:
>+        * DumpRenderTree/mac/DumpRenderTree.mm:
>+        (enableExperimentalFeatures):
>+        (setWebPreferencesForTestOptions):
>+        * WebKitTestRunner/TestController.cpp:
>+        (WTR::TestController::resetPreferencesToConsistentValues):
>+        (WTR::updateTestOptionsFromTestHeader):
>+        * WebKitTestRunner/TestOptions.h:
>+        (WTR::TestOptions::hasSameInitializationOptions const):
>+
> 2018-12-17  Daniel Bates  <dabates@apple.com>
> 
>         Support concatenating StringView with other string types
>diff --git a/Tools/DumpRenderTree/TestOptions.cpp b/Tools/DumpRenderTree/TestOptions.cpp
>index 81b2487b23389239547055e011a5dd7845cfbfd6..82d87e13ac80ee46b570964983579368e1ad2978 100644
>--- a/Tools/DumpRenderTree/TestOptions.cpp
>+++ b/Tools/DumpRenderTree/TestOptions.cpp
>@@ -85,8 +85,6 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>             enableModernMediaControls = parseBooleanTestHeaderValue(value);
>         else if (key == "enablePointerLock")
>             enablePointerLock = parseBooleanTestHeaderValue(value);
>-        else if (key == "enableWebAuthentication")
>-            enableWebAuthentication = parseBooleanTestHeaderValue(value);
>         else if (key == "enableDragDestinationActionLoad")
>             enableDragDestinationActionLoad = parseBooleanTestHeaderValue(value);
>         else if (key == "layerBackedWebView")
>diff --git a/Tools/DumpRenderTree/TestOptions.h b/Tools/DumpRenderTree/TestOptions.h
>index 8aedb946417f8a6a5fc567b86daadfdcc86d7e43..a44ea1faac9a6433a404d8e827a1a4a6ad62d8e1 100644
>--- a/Tools/DumpRenderTree/TestOptions.h
>+++ b/Tools/DumpRenderTree/TestOptions.h
>@@ -35,7 +35,6 @@ struct TestOptions {
>     bool enableMenuItemElement { false };
>     bool enableModernMediaControls { true };
>     bool enablePointerLock { false };
>-    bool enableWebAuthentication { true };
>     bool enableDragDestinationActionLoad { false };
>     bool layerBackedWebView { false };
>     bool enableIsSecureContextAttribute { true };
>diff --git a/Tools/DumpRenderTree/mac/DumpRenderTree.mm b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>index 5de612c59f367c4d094c8fb3178286ed3bdcbff0..e8c73de3e5bf2ec95f5871092eb4def734aad42c 100644
>--- a/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>+++ b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>@@ -855,7 +855,6 @@ static void enableExperimentalFeatures(WebPreferences* preferences)
>     [preferences setWebGL2Enabled:YES];
>     [preferences setWebMetalEnabled:YES];
>     // FIXME: AsyncFrameScrollingEnabled
>-    [preferences setWebAuthenticationEnabled:NO];
>     [preferences setCacheAPIEnabled:NO];
>     [preferences setReadableByteStreamAPIEnabled:YES];
>     [preferences setWritableStreamAPIEnabled:YES];
>@@ -1003,7 +1002,6 @@ static void setWebPreferencesForTestOptions(const TestOptions& options)
>     preferences.acceleratedDrawingEnabled = options.useAcceleratedDrawing;
>     preferences.menuItemElementEnabled = options.enableMenuItemElement;
>     preferences.modernMediaControlsEnabled = options.enableModernMediaControls;
>-    preferences.webAuthenticationEnabled = options.enableWebAuthentication;
>     preferences.isSecureContextAttributeEnabled = options.enableIsSecureContextAttribute;
>     preferences.inspectorAdditionsEnabled = options.enableInspectorAdditions;
>     preferences.allowCrossOriginSubresourcesToAskForCredentials = options.allowCrossOriginSubresourcesToAskForCredentials;
>diff --git a/Tools/WebKitTestRunner/TestController.cpp b/Tools/WebKitTestRunner/TestController.cpp
>index 2f98ed32396da759f6ffdeddeadc935d11e558d2..6d4dffb49656524c64d962e79fe238384c69c0c6 100644
>--- a/Tools/WebKitTestRunner/TestController.cpp
>+++ b/Tools/WebKitTestRunner/TestController.cpp
>@@ -756,6 +756,7 @@ void TestController::resetPreferencesToConsistentValues(const TestOptions& optio
>     WKPreferencesSetMenuItemElementEnabled(preferences, options.enableMenuItemElement);
>     WKPreferencesSetModernMediaControlsEnabled(preferences, options.enableModernMediaControls);
>     WKPreferencesSetWebAuthenticationEnabled(preferences, options.enableWebAuthentication);
>+    WKPreferencesSetWebAuthenticationLocalAuthenticatorEnabled(preferences, options.enableWebAuthenticationLocalAuthenticator);
>     WKPreferencesSetIsSecureContextAttributeEnabled(preferences, options.enableIsSecureContextAttribute);
>     WKPreferencesSetAllowCrossOriginSubresourcesToAskForCredentials(preferences, options.allowCrossOriginSubresourcesToAskForCredentials);
>     WKPreferencesSetColorFilterEnabled(preferences, options.enableColorFilter);
>@@ -1231,6 +1232,8 @@ static void updateTestOptionsFromTestHeader(TestOptions& testOptions, const std:
>             testOptions.enablePointerLock = parseBooleanTestHeaderValue(value);
>         else if (key == "enableWebAuthentication")
>             testOptions.enableWebAuthentication = parseBooleanTestHeaderValue(value);
>+        else if (key == "enableWebAuthenticationLocalAuthenticator")
>+            testOptions.enableWebAuthenticationLocalAuthenticator = parseBooleanTestHeaderValue(value);
>         else if (key == "enableIsSecureContextAttribute")
>             testOptions.enableIsSecureContextAttribute = parseBooleanTestHeaderValue(value);
>         else if (key == "enableInspectorAdditions")
>diff --git a/Tools/WebKitTestRunner/TestOptions.h b/Tools/WebKitTestRunner/TestOptions.h
>index 10786e04125c7192fcd282503b68d96b853b0c88..05a4efbf90e5cce9dc404e841c700612278a60e5 100644
>--- a/Tools/WebKitTestRunner/TestOptions.h
>+++ b/Tools/WebKitTestRunner/TestOptions.h
>@@ -51,6 +51,7 @@ struct TestOptions {
>     bool enableModernMediaControls { true };
>     bool enablePointerLock { false };
>     bool enableWebAuthentication { true };
>+    bool enableWebAuthenticationLocalAuthenticator { true };
>     bool enableIsSecureContextAttribute { true };
>     bool enableInspectorAdditions { false };
>     bool shouldShowTouches { false };
>@@ -94,6 +95,7 @@ struct TestOptions {
>             || enableModernMediaControls != options.enableModernMediaControls
>             || enablePointerLock != options.enablePointerLock
>             || enableWebAuthentication != options.enableWebAuthentication
>+            || enableWebAuthenticationLocalAuthenticator != options.enableWebAuthenticationLocalAuthenticator
>             || enableIsSecureContextAttribute != options.enableIsSecureContextAttribute
>             || enableInspectorAdditions != options.enableInspectorAdditions
>             || dumpJSConsoleLogInStdErr != options.dumpJSConsoleLogInStdErr
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index e57880bb57ba499f3dbcbed59e527da907e639db..dd5665be1597a0e00b6753fde53bf23680007d7f 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-18  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [WebAuthN] Add a runtime flag for local authenticator
>+        https://bugs.webkit.org/show_bug.cgi?id=192792
>+        <rdar://problem/46798738>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac-highsierra-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
>+        * platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
>+
> 2018-12-17  Zalan Bujtas  <zalan@apple.com>
> 
>         Reproducible ASSERTion failure when toggling layer borders with find-in-page up
>diff --git a/LayoutTests/platform/mac-highsierra-wk1/fast/dom/navigator-detached-no-crash-expected.txt b/LayoutTests/platform/mac-highsierra-wk1/fast/dom/navigator-detached-no-crash-expected.txt
>index 9f7621e879e10e0a04c55c09102c0a5c79cdee30..ec805140e7568bd7b779693e7102fa8e6fa9bcd4 100644
>--- a/LayoutTests/platform/mac-highsierra-wk1/fast/dom/navigator-detached-no-crash-expected.txt
>+++ b/LayoutTests/platform/mac-highsierra-wk1/fast/dom/navigator-detached-no-crash-expected.txt
>@@ -4,7 +4,6 @@ navigator.appCodeName is OK
> navigator.appName is OK
> navigator.appVersion is OK
> navigator.cookieEnabled is OK
>-navigator.credentials is OK
> navigator.getStorageUpdates() is OK
> navigator.javaEnabled() is OK
> navigator.language is OK
>@@ -24,7 +23,6 @@ navigator.appCodeName is OK
> navigator.appName is OK
> navigator.appVersion is OK
> navigator.cookieEnabled is OK
>-navigator.credentials is OK
> navigator.getStorageUpdates() is OK
> navigator.javaEnabled() is OK
> navigator.language is OK
>diff --git a/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt b/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt
>index 567339c99a232fb0dd2d73e61b11280abd3f27b9..aecf6ac2fa6f72909afc75ec4af24d7bfb3aff36 100644
>--- a/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt
>+++ b/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt
>@@ -5,7 +5,6 @@ navigator.appCodeName is OK
> navigator.appName is OK
> navigator.appVersion is OK
> navigator.cookieEnabled is OK
>-navigator.credentials is OK
> navigator.getStorageUpdates() is OK
> navigator.javaEnabled() is OK
> navigator.language is OK
>@@ -26,7 +25,6 @@ navigator.appCodeName is OK
> navigator.appName is OK
> navigator.appVersion is OK
> navigator.cookieEnabled is OK
>-navigator.credentials is OK
> navigator.getStorageUpdates() is OK
> navigator.javaEnabled() is OK
> navigator.language is OK

Actions: View | Formatted Diff | Diff

Attachments on bug 192792: 357516 | 357523 | 357528 | 357612