Attachment 357585 Details for Bug 192815 – Patch

[patch] Patch

bug-192815-20181218201717.patch (text/plain), 1.87 KB, created by Xabier Rodríguez Calvar on 2018-12-18 11:17:18 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Xabier Rodríguez Calvar

Created: 2018-12-18 11:17:18 PST

Size: 1.87 KB

patch

obsolete

>Subversion Revision: 239009
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index e440931452070d9d5047ad434965cfbd7acb1e27..1c313816c4ccec013ff83a8d17668edf850b2eeb 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-12-18  Xabier Rodriguez Calvar  <calvaris@igalia.com>
>+
>+        [EME] MediaKeySystemConfiguration distinctiveIdentifier and persistentState should default to optional
>+        https://bugs.webkit.org/show_bug.cgi?id=192815
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        https://www.w3.org/TR/encrypted-media/#dom-mediakeysystemconfiguration
>+        says that distinctiveIdentifier and persistentState default to
>+        optional. Our implementation does not define a default leaving it
>+        to the first option of the enum, which currently is Required.
>+
>+        * platform/encryptedmedia/CDMKeySystemConfiguration.h:
>+
> 2018-12-07  Eric Carlson  <eric.carlson@apple.com>
> 
>         [MediaStream] 'devicechange' event should not fire in frames that can't access capture devices
>diff --git a/Source/WebCore/platform/encryptedmedia/CDMKeySystemConfiguration.h b/Source/WebCore/platform/encryptedmedia/CDMKeySystemConfiguration.h
>index 385492101b9be9bff7e71aa9acc6ba484491fddb..612d645faa5248f71f1c1567f4507e89f3b31ce5 100644
>--- a/Source/WebCore/platform/encryptedmedia/CDMKeySystemConfiguration.h
>+++ b/Source/WebCore/platform/encryptedmedia/CDMKeySystemConfiguration.h
>@@ -45,8 +45,8 @@ struct CDMKeySystemConfiguration {
>     Vector<String> initDataTypes;
>     Vector<CDMMediaCapability> audioCapabilities;
>     Vector<CDMMediaCapability> videoCapabilities;
>-    CDMRequirement distinctiveIdentifier;
>-    CDMRequirement persistentState;
>+    CDMRequirement distinctiveIdentifier { CDMRequirement::Optional };
>+    CDMRequirement persistentState { CDMRequirement::Optional };
>     Vector<CDMSessionType> sessionTypes;
> };
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192815: 357585