Attachment 357582 Details for Bug 192814 – Patch v1

[patch] Patch v1

bug-192814-20181218110425.patch (text/plain), 2.45 KB, created by David Kilzer (:ddkilzer) on 2018-12-18 11:04:26 PST

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2018-12-18 11:04:26 PST

Size: 2.45 KB

patch

obsolete

>Subversion Revision: 239276
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 9c12c632ad2329ae738fea32d5ae63cf9e4dd6ff..81819dec9ea792b35deef2303e7c19671d845727 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-12-18  David Kilzer  <ddkilzer@apple.com>
>+
>+        clang-tidy: Use const reference for MediaTime parameter to prevent object copy
>+        <https://webkit.org/b/192814>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * runtime/JSCJSValue.h:
>+        (JSC::jsNumber):
>+
> 2018-12-17  Matt Lewis  <jlewis3@apple.com>
> 
>         Unreviewed, rolling out r239254.
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 572af287919e83f9f719faf914fa6747727ee130..04d41b131f50847caaacf14072e557f550c8e532 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-12-18  David Kilzer  <ddkilzer@apple.com>
>+
>+        clang-tidy: Use const reference for MediaTime parameter to prevent object copy
>+        <https://webkit.org/b/192814>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * bindings/js/JSDOMConvertNumbers.h:
>+        (WebCore::JSConverter<IDLUnrestrictedDouble>::convert):
>+
> 2018-12-17  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
>diff --git a/Source/JavaScriptCore/runtime/JSCJSValue.h b/Source/JavaScriptCore/runtime/JSCJSValue.h
>index 90d8f9f9693031c73e3331f2f49f4c80fce20e35..582530d44c0f7d24e82a97dbc9513a53e2de0276 100644
>--- a/Source/JavaScriptCore/runtime/JSCJSValue.h
>+++ b/Source/JavaScriptCore/runtime/JSCJSValue.h
>@@ -551,7 +551,7 @@ ALWAYS_INLINE JSValue jsNumber(double d)
>     return JSValue(d);
> }
> 
>-ALWAYS_INLINE JSValue jsNumber(MediaTime t)
>+ALWAYS_INLINE JSValue jsNumber(const MediaTime& t)
> {
>     return jsNumber(t.toDouble());
> }
>diff --git a/Source/WebCore/bindings/js/JSDOMConvertNumbers.h b/Source/WebCore/bindings/js/JSDOMConvertNumbers.h
>index ee9c900718b5a5f9ebbaadbed47863622c5b0e30..29472c356c566a63c207bc68029976c94992e743 100644
>--- a/Source/WebCore/bindings/js/JSDOMConvertNumbers.h
>+++ b/Source/WebCore/bindings/js/JSDOMConvertNumbers.h
>@@ -389,7 +389,7 @@ template<> struct JSConverter<IDLUnrestrictedDouble> {
>     }
> 
>     // Add overload for MediaTime.
>-    static JSC::JSValue convert(MediaTime value)
>+    static JSC::JSValue convert(const MediaTime& value)
>     {
>         return JSC::jsNumber(JSC::purifyNaN(value.toDouble()));
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 192814: 357582 | 357599