Attachment 357572 Details for Bug 192809 – Patch

[patch] Patch

bug-192809-20181218093858.patch (text/plain), 3.69 KB, created by Brent Fulgham on 2018-12-18 09:38:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2018-12-18 09:38:59 PST

Size: 3.69 KB

patch

obsolete

>Subversion Revision: 239210
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 0109f1a48b0f999666f8286f4f3ba065862ec3c1..64e81b1507df86c3ef9b9674790ac31c14fcdb5e 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-18  Brent Fulgham  <bfulgham@apple.com>
>+
>+        WKWebView default UA doesn't freeze the build number
>+        https://bugs.webkit.org/show_bug.cgi?id=192809
>+        <rdar://problem/44687185>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Always reports the frozen build number.
>+
>+        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
>+        (defaultApplicationNameForUserAgent): Do not expose the actual build number through this API.
>+
> 2018-12-14  Chris Dumez  <cdumez@apple.com>
> 
>         [PSON] WebsitePolicies are lost on process-swap
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index 3570259861438dfaf540882c263c9945b1099ea6..c6741a6acd4cc3b6d1f07563f975179b969b0c10 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-12-18  Brent Fulgham  <bfulgham@apple.com>
>+
>+        WKWebView default UA doesn't freeze the build number
>+        https://bugs.webkit.org/show_bug.cgi?id=192809
>+        <rdar://problem/44687185>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Always reports the frozen build number.
>+
>+        * WebView/WebView.mm:
>+        (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
>+        actual build number through this method call.
>+        (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
>+
> 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Make TextInputController.legacyAttributedString take DOM nodes and offsets
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
>index d287fd95bdc79bc9486c3ed4f836e6ec003203ec..38c91a4d2c0fe0b563d8f1ef81a4f0e1c644d92b 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
>@@ -456,7 +456,7 @@ - (void)setWebsiteDataStore:(WKWebsiteDataStore *)websiteDataStore
> static NSString *defaultApplicationNameForUserAgent()
> {
> #if PLATFORM(IOS_FAMILY)
>-    return [@"Mobile/" stringByAppendingString:[UIDevice currentDevice].buildVersion];
>+    return @"Mobile/15E148";
> #else
>     return nil;
> #endif
>diff --git a/Source/WebKitLegacy/mac/WebView/WebView.mm b/Source/WebKitLegacy/mac/WebView/WebView.mm
>index 5eb9575282c1b653dcbc9aa6a47ed70c05e7d5ef..0110bbd61625b54ccc5069c579b02b0065d4a768 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebView.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebView.mm
>@@ -1158,12 +1158,15 @@ + (NSString *)_standardUserAgentWithApplicationName:(NSString *)applicationName
> #if PLATFORM(IOS_FAMILY)
> - (void)_setBrowserUserAgentProductVersion:(NSString *)productVersion buildVersion:(NSString *)buildVersion bundleVersion:(NSString *)bundleVersion
> {
>-    [self setApplicationNameForUserAgent:[NSString stringWithFormat:@"Version/%@ Mobile/%@ Safari/%@", productVersion, buildVersion, bundleVersion]];
>+    // The web-visible build and bundle versions are frozen to remove a fingerprinting surface
>+    UNUSED_PARAM(buildVersion);
>+    [self setApplicationNameForUserAgent:[NSString stringWithFormat:@"Version/%@ Mobile/15E148 Safari/%@", productVersion, bundleVersion]];
> }
> 
> - (void)_setUIWebViewUserAgentWithBuildVersion:(NSString *)buildVersion
> {
>-    [self setApplicationNameForUserAgent:[@"Mobile/" stringByAppendingString:buildVersion]];
>+    UNUSED_PARAM(buildVersion);
>+    [self setApplicationNameForUserAgent:@"Mobile/15E148"];
> }
> #endif // PLATFORM(IOS_FAMILY)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192809: 357572