Attachment 357540 Details for Bug 191373 – proposed patch.

[patch] proposed patch.

bug-191373.patch (text/plain), 1.15 KB, created by Mark Lam on 2018-12-17 23:08:55 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Lam

Created: 2018-12-17 23:08:55 PST

Size: 1.15 KB

patch

obsolete

>Index: JSTests/ChangeLog
>===================================================================
>--- JSTests/ChangeLog	(revision 239325)
>+++ JSTests/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-12-17  Mark Lam  <mark.lam@apple.com>
>+
>+        Skip the stress/materialize-regexp-cyclic-regexp.js test on 32-bit.
>+        https://bugs.webkit.org/show_bug.cgi?id=191373
>+        <rdar://problem/46525458>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The test is already slow running with a JIT on 64-bit.  It will always timeout
>+        on 32-bit without a JIT.
>+
>+        * stress/materialize-regexp-cyclic-regexp.js:
>+
> 2018-12-17  Mark Lam  <mark.lam@apple.com>
> 
>         Array unshift/shift should not race against the AI in the compiler thread.
>Index: JSTests/stress/materialize-regexp-cyclic-regexp.js
>===================================================================
>--- JSTests/stress/materialize-regexp-cyclic-regexp.js	(revision 239325)
>+++ JSTests/stress/materialize-regexp-cyclic-regexp.js	(working copy)
>@@ -1,3 +1,5 @@
>+//@ skip if $architecture != "arm64" and $architecture != "x86-64"
>+
> function shouldBe(actual, expected)
> {
>     if (actual !== expected)

Actions: View | Formatted Diff | Diff

Attachments on bug 191373: 357540