Attachment 357533 Details for Bug 192797 – Patch

[patch] Patch

bug-192797-20181217213048.patch (text/plain), 1.95 KB, created by Wenson Hsieh on 2018-12-17 21:30:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-12-17 21:30:49 PST

Size: 1.95 KB

patch

obsolete

>Subversion Revision: 239318
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index b39a0e0878dae184a4bb0c68ab03cd611669d5d9..37a4468108d40138e970219cd372500c1a430517 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Tap highlights should not be shown on iOSMac
>+        https://bugs.webkit.org/show_bug.cgi?id=192797
>+        <rdar://problem/46793995>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WKWebViews in iOSMac should avoid painting tap highlights, since tap highlights are not present in the rest of
>+        the macOS platform. Simply disable this functionality by bailing in `-[WKContentView _showTapHighlight]`.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _showTapHighlight]):
>+
> 2018-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Unreviewed, fix the iOSMac engineering build again
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 026f1f7a8762b9894a338c2c4878ffa38462d870..dee8988c420adccd57edb2cdc9b429a1f5e9c7b4 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -1256,6 +1256,10 @@ - (void)_updateTapHighlight
> - (void)_showTapHighlight
> {
>     auto shouldPaintTapHighlight = [&](const WebCore::FloatRect& rect) {
>+#if PLATFORM(IOSMAC)
>+        UNUSED_PARAM(rect);
>+        return NO;
>+#else
>         static const float highlightPaintThreshold = 0.3; // 30%
>         float highlightArea = 0;
>         for (auto highlightQuad : _tapHighlightInformation.quads) {
>@@ -1265,6 +1269,7 @@ - (void)_showTapHighlight
>                 return false;
>         }
>         return highlightArea < rect.area() * highlightPaintThreshold;
>+#endif
>     };
> 
>     if (!shouldPaintTapHighlight(_page->unobscuredContentRect()) && !_showDebugTapHighlightsForFastClicking)

Actions: View | Formatted Diff | Diff

Attachments on bug 192797: 357533