Attachment 357500 Details for Bug 192789 – Patch

[patch] Patch

bug-192789-20181217164341.patch (text/plain), 1.59 KB, created by Chris Dumez on 2018-12-17 16:43:41 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-12-17 16:43:41 PST

Size: 1.59 KB

patch

obsolete

>Subversion Revision: 239294
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 00c097afeda38753805fd4fdcf809ac849c5e408..fda37528e8b5b350b5ed895ad3a6af9093af6884 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-12-17  Chris Dumez  <cdumez@apple.com>
>+
>+        Allow passing nil as session state to [WKWebView _restoreSessionState:]
>+        https://bugs.webkit.org/show_bug.cgi?id=192789
>+        <rdar://problem/46755277>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Allow passing nil as session state to [WKWebView _restoreSessionState:] instead of crashing.
>+
>+        * UIProcess/API/Cocoa/WKWebView.mm:
>+        (-[WKWebView _restoreSessionState:andNavigate:]):
>+
> 2018-12-17  Chris Dumez  <cdumez@apple.com>
> 
>         Unreviewed, revert recent CrashReporterClient build fixes as they are no longer needed.
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>index ba2048eabaab68cd733825c64f8b920fab96441e..8dc30f18dcd36705c2e89f2f9bda017d85132d8e 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>@@ -4712,7 +4712,7 @@ - (void)_restoreFromSessionStateData:(NSData *)sessionStateData
> 
> - (WKNavigation *)_restoreSessionState:(_WKSessionState *)sessionState andNavigate:(BOOL)navigate
> {
>-    return wrapper(_page->restoreFromSessionState(sessionState->_sessionState, navigate));
>+    return wrapper(_page->restoreFromSessionState(sessionState ? sessionState->_sessionState : WebKit::SessionState { }, navigate));
> }
> 
> - (void)_close

Actions: View | Formatted Diff | Diff

Attachments on bug 192789: 357500 | 357501