Attachment 357493 Details for Bug 192783 – Patch

[patch] Patch

bug-192783-20181217161239.patch (text/plain), 2.04 KB, created by Devin Rousso on 2018-12-17 16:12:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2018-12-17 16:12:40 PST

Size: 2.04 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 9152ad45a76b7b16c7970000dfa89f9f834c0cdf..2a14af275de3024e739727ba552230d2a7199d69 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-12-17  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'effectiveDOMNode.enabledPseudoClasses')
>+        https://bugs.webkit.org/show_bug.cgi?id=192783
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
>+        (WI.GeneralStyleDetailsSidebarPanel.prototype._forcedPseudoClassCheckboxChanged):
>+        (WI.GeneralStyleDetailsSidebarPanel.prototype._updatePseudoClassCheckboxes):
>+
> 2018-12-15  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: toggling selected properties may cause data corruption
>diff --git a/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
>index 52d396751d720a4a88640c7b58432b4df8f9a971..c73b0b93406337e0a71622bbaa0c135961f35434 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
>@@ -272,6 +272,8 @@ WI.GeneralStyleDetailsSidebarPanel = class GeneralStyleDetailsSidebarPanel exten
>             return;
> 
>         let effectiveDOMNode = this.domNode.isPseudoElement() ? this.domNode.parentNode : this.domNode;
>+        if (!effectiveDOMNode)
>+            return;
> 
>         effectiveDOMNode.setPseudoClassEnabled(pseudoClass, event.target.checked);
> 
>@@ -284,6 +286,8 @@ WI.GeneralStyleDetailsSidebarPanel = class GeneralStyleDetailsSidebarPanel exten
>             return;
> 
>         let effectiveDOMNode = this.domNode.isPseudoElement() ? this.domNode.parentNode : this.domNode;
>+        if (!effectiveDOMNode)
>+            return;
> 
>         let enabledPseudoClasses = effectiveDOMNode.enabledPseudoClasses;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 192783: 357493